Skip to content

VkPipelineStageFlags uses VkPipelineStageFlagBits2 value (and more broadly, what should be done with inconsistent use of *2 calls/structures) #49

@buhman

Description

@buhman

As a specific example, both the article and code contain the statement,

VkPipelineStageFlags waitStages = VK_PIPELINE_STAGE_2_COLOR_ATTACHMENT_OUTPUT_BIT;

However, this should either be:

VkPipelineStageFlags waitStages = VK_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT;

or

VkPipelineStageFlags2 waitStages = VK_PIPELINE_STAGE_2_COLOR_ATTACHMENT_OUTPUT_BIT;

(with cascaded changes VkSubmitInfo -> VkSubmitInfo2, etc..)

This is not the only place where "legacy functionality" is used in the code and article. What should be done, both with this specific case, and as a policy for the entire repository?

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions