Remove most of warnings from DAL

Author: antoineatstariongroup

SysML2.NET.CodeGenerator/Templates/Uml/core-dal-element-uml-extensions.hbs

@@ -76,14 +76,14 @@ namespace SysML2.NET.Dal
         /// and the provided cache to find the referenced object.
         /// </summary>
         /// <param name="poco">
-        /// The <see cref=""/> that is to be updated
+        /// The <see cref="Core.POCO.Root.Elements.IElement"/> that is to be updated
         /// </param>
         /// <param name="dto">
-        /// The DTO that is used to update the <see cref="Core.POCO.Root.Elements.IElement"/> with
+        /// The DTO that is used to update the <see cref="Core.DTO.Root.Elements.IElement"/> with
         /// </param>
         /// <param name="cache">
-        /// The <see cref="ConcurrentDictionary{String, Lazy{Core.POCO.Root.Elements.IElement}}"/> that contains the
-        /// <see cref="ModelThing"/>s that are know and cached.
+        /// The <see cref="ConcurrentDictionary{String, Lazy}"/> that contains the
+        /// ModelThings that are know and cached.
         /// </param>
         /// <exception cref="ArgumentNullException"></exception>
         public static void UpdateReferenceProperties(this Core.POCO.Root.Elements.IElement poco, Core.DTO.Root.Elements.IElement dto, ConcurrentDictionary<Guid, Lazy<Core.POCO.Root.Elements.IElement>> cache)

SysML2.NET.CodeGenerator/Templates/Uml/core-dal-poco-uml-extensions.hbs

@@ -32,20 +32,20 @@ namespace SysML2.NET.Dal
     using Core.POCO.{{ #NamedElement.WriteFullyQualifiedNameSpace this }};
 
     /// <summary>
-    /// A static class that provides extension methods for the <see cref="{{ this.Name }}"/> class
+    /// A static class that provides extension methods for the <see cref="Core.POCO.{{ #NamedElement.WriteFullyQualifiedNameSpace this }}.{{ this.Name }}"/> class
     /// </summary>
     public static class {{ this.Name }}Extensions
     {
         /// <summary>
-        /// Updates the value properties of the <see cref="{{ this.Name }}"/> by setting the value equal to that of the dto
+        /// Updates the value properties of the <see cref="Core.POCO.{{ #NamedElement.WriteFullyQualifiedNameSpace this }}.{{ this.Name }}"/> by setting the value equal to that of the dto
         /// Removes deleted objects from the reference properties and returns the unique identifiers
         /// of the objects that have been removed from contained properties
         /// </summary>
         /// <param name="poco">
-        /// The <see cref="{{ this.Name }}"/> that is to be updated
+        /// The <see cref="Core.POCO.{{ #NamedElement.WriteFullyQualifiedNameSpace this }}.{{ this.Name }}"/> that is to be updated
         /// </param>
         /// <param name="dto">
-        /// The DTO that is used to update the <see cref="{{ this.Name }}"/> with
+        /// The DTO that is used to update the <see cref="Core.DTO.{{ #NamedElement.WriteFullyQualifiedNameSpace this }}.{{ this.Name }}"/> with
         /// </param>
         /// <returns>
         /// The unique identifiers of the objects that have been removed from contained properties
@@ -100,17 +100,17 @@ namespace SysML2.NET.Dal
         }
 
         /// <summary>
-        /// Updates the Reference properties of the <see cref="{{ this.Name }}"/> using the data (identifiers) encapsulated in the DTO
+        /// Updates the Reference properties of the <see cref="Core.POCO.{{ #NamedElement.WriteFullyQualifiedNameSpace this }}.{{ this.Name }}"/> using the data (identifiers) encapsulated in the DTO
         /// and the provided cache to find the referenced object.
         /// </summary>
         /// <param name="poco">
-        /// The <see cref="{{ this.Name }}"/> that is to be updated
+        /// The <see cref="Core.POCO.{{ #NamedElement.WriteFullyQualifiedNameSpace this }}.{{ this.Name }}"/> that is to be updated
         /// </param>
         /// <param name="dto">
-        /// The DTO that is used to update the <see cref="{{ this.Name }}"/> with
+        /// The DTO that is used to update the <see cref="Core.DTO.{{ #NamedElement.WriteFullyQualifiedNameSpace this }}.{{ this.Name }}"/> with
         /// </param>
         /// <param name="cache">
-        /// The <see cref="ConcurrentDictionary{Guid, Lazy{Core.POCO.Root.Elements.IElement}}"/> that contains the
+        /// The <see cref="ConcurrentDictionary{Guid, Lazy}"/> that contains the
         /// <see cref="Core.POCO.Root.Elements.IElement"/>s that are know and cached.
         /// </param>
         /// <exception cref="ArgumentNullException"></exception>

SysML2.NET.CodeGenerator/Templates/Uml/core-element-dal-uml-factory.hbs

@@ -55,8 +55,7 @@ namespace SysML2.NET.Dal
             {
                 {{#each this as | class |}}
                 case Core.DTO.{{ #NamedElement.WriteFullyQualifiedNameSpace this }}.{{ class.Name }} {{ String.LowerCaseFirstLetter class.Name }}Dto:
-                    var {{ String.LowerCaseFirstLetter class.Name }}Factory = new {{ class.Name }}Factory();
-                    return {{ String.LowerCaseFirstLetter class.Name }}Factory.Create({{ String.LowerCaseFirstLetter class.Name }}Dto);
+                    return {{ class.Name }}Factory.Create({{ String.LowerCaseFirstLetter class.Name }}Dto);
                 {{/each}}
                 default:
                     throw new NotSupportedException($"{dto.GetType().Name} not yet supported");

SysML2.NET.CodeGenerator/Templates/Uml/core-poco-dal-uml-factory.hbs

@@ -45,7 +45,7 @@ namespace SysML2.NET.Dal
         /// <exception cref="ArgumentNullException">
         /// thrown when <paramref name="dto"/> is null
         /// </exception>
-        public Core.POCO.{{ #NamedElement.WriteFullyQualifiedNameSpace this }}.{{this.Name}} Create(Core.DTO.{{ #NamedElement.WriteFullyQualifiedNameSpace this }}.{{this.Name}} dto)
+        public static Core.POCO.{{ #NamedElement.WriteFullyQualifiedNameSpace this }}.{{this.Name}} Create(Core.DTO.{{ #NamedElement.WriteFullyQualifiedNameSpace this }}.{{this.Name}} dto)
         {
             if (dto == null)
             {

SysML2.NET.Dal/Core/AutoGenElementFactory/AcceptActionUsageFactory.cs

@@ -45,7 +45,7 @@ public class AcceptActionUsageFactory
         /// <exception cref="ArgumentNullException">
         /// thrown when <paramref name="dto"/> is null
         /// </exception>
-        public Core.POCO.Systems.Actions.AcceptActionUsage Create(Core.DTO.Systems.Actions.AcceptActionUsage dto)
+        public static Core.POCO.Systems.Actions.AcceptActionUsage Create(Core.DTO.Systems.Actions.AcceptActionUsage dto)
         {
             if (dto == null)
             {

SysML2.NET.Dal/Core/AutoGenElementFactory/ActionDefinitionFactory.cs

@@ -45,7 +45,7 @@ public class ActionDefinitionFactory
         /// <exception cref="ArgumentNullException">
         /// thrown when <paramref name="dto"/> is null
         /// </exception>
-        public Core.POCO.Systems.Actions.ActionDefinition Create(Core.DTO.Systems.Actions.ActionDefinition dto)
+        public static Core.POCO.Systems.Actions.ActionDefinition Create(Core.DTO.Systems.Actions.ActionDefinition dto)
         {
             if (dto == null)
             {

SysML2.NET.Dal/Core/AutoGenElementFactory/ActionUsageFactory.cs

@@ -45,7 +45,7 @@ public class ActionUsageFactory
         /// <exception cref="ArgumentNullException">
         /// thrown when <paramref name="dto"/> is null
         /// </exception>
-        public Core.POCO.Systems.Actions.ActionUsage Create(Core.DTO.Systems.Actions.ActionUsage dto)
+        public static Core.POCO.Systems.Actions.ActionUsage Create(Core.DTO.Systems.Actions.ActionUsage dto)
         {
             if (dto == null)
             {

SysML2.NET.Dal/Core/AutoGenElementFactory/ActorMembershipFactory.cs

@@ -45,7 +45,7 @@ public class ActorMembershipFactory
         /// <exception cref="ArgumentNullException">
         /// thrown when <paramref name="dto"/> is null
         /// </exception>
-        public Core.POCO.Systems.Requirements.ActorMembership Create(Core.DTO.Systems.Requirements.ActorMembership dto)
+        public static Core.POCO.Systems.Requirements.ActorMembership Create(Core.DTO.Systems.Requirements.ActorMembership dto)
         {
             if (dto == null)
             {

SysML2.NET.Dal/Core/AutoGenElementFactory/AllocationDefinitionFactory.cs

@@ -45,7 +45,7 @@ public class AllocationDefinitionFactory
         /// <exception cref="ArgumentNullException">
         /// thrown when <paramref name="dto"/> is null
         /// </exception>
-        public Core.POCO.Systems.Allocations.AllocationDefinition Create(Core.DTO.Systems.Allocations.AllocationDefinition dto)
+        public static Core.POCO.Systems.Allocations.AllocationDefinition Create(Core.DTO.Systems.Allocations.AllocationDefinition dto)
         {
             if (dto == null)
             {

SysML2.NET.Dal/Core/AutoGenElementFactory/AllocationUsageFactory.cs

@@ -45,7 +45,7 @@ public class AllocationUsageFactory
         /// <exception cref="ArgumentNullException">
         /// thrown when <paramref name="dto"/> is null
         /// </exception>
-        public Core.POCO.Systems.Allocations.AllocationUsage Create(Core.DTO.Systems.Allocations.AllocationUsage dto)
+        public static Core.POCO.Systems.Allocations.AllocationUsage Create(Core.DTO.Systems.Allocations.AllocationUsage dto)
         {
             if (dto == null)
             {