[Code Quality] Implement SonarQube improvements

samatstariongroup · samatstariongroup · commit 2d3d679be1e5 · 2025-08-12T14:59:09.000+02:00
diff --git a/SySML2.NET.REST.Tests/RestClientTestFixture.cs b/SySML2.NET.REST.Tests/RestClientTestFixture.cs
@@ -38,7 +38,7 @@ public class RestClientTestFixture
         
         private CancellationTokenSource cancellationTokenSource;
 
-        private IRestClient restClient;
+        private RestClient restClient;
         
         [SetUp]
 		public void Setup()
diff --git a/SysML2.NET.CodeGenerator.Tests/DataModelLoaderTestFixture.cs b/SysML2.NET.CodeGenerator.Tests/DataModelLoaderTestFixture.cs
@@ -44,7 +44,7 @@ public void Verify_that_the_expected_SysML2_model_is_returned()
             
             var classes = ePacakge.EClassifiers.OfType<EClass>();
             
-            var rootClass = classes.Single(x => !x.ESuperTypes.Any());
+            var rootClass = classes.Single(x => x.ESuperTypes.Count == 0);
 
             Assert.That(rootClass.Name, Is.EqualTo("Element"));
 
diff --git a/SysML2.NET.CodeGenerator/Extensions/EcoreExtensions.cs b/SysML2.NET.CodeGenerator/Extensions/EcoreExtensions.cs
@@ -409,7 +409,7 @@ public static string RemoveUnwantedHtmlTags(this string html, List<string> unwan
 
             HtmlNodeCollection tryGetNodes = document.DocumentNode.SelectNodes("./*|./text()");
 
-            if (tryGetNodes == null || !tryGetNodes.Any())
+            if (tryGetNodes == null || tryGetNodes.Count == 0)
             {
                 return html;
             }
diff --git a/SysML2.NET.CodeGenerator/Generators/UmlHandleBarsGenerators/HandlebarsPayload.cs b/SysML2.NET.CodeGenerator/Generators/UmlHandleBarsGenerators/HandlebarsPayload.cs
@@ -112,6 +112,6 @@ public HandlebarsPayload(IPackage rootPackage, IEnumerable<IPackage> packages, I
         /// <summary>
         /// Gets the version of the reporting library
         /// </summary>
-        public string Version => Assembly.GetExecutingAssembly().GetName().Version?.ToString();
+        public static string Version => Assembly.GetExecutingAssembly().GetName().Version?.ToString();
     }
 }
diff --git a/SysML2.NET.CodeGenerator/Generators/UmlHandleBarsGenerators/SysML2PropertyHelper.cs b/SysML2.NET.CodeGenerator/Generators/UmlHandleBarsGenerators/SysML2PropertyHelper.cs
@@ -54,7 +54,7 @@ public static void RegisterPropertyHelper(this IHandlebars handlebars)
 
                 var sb = new StringBuilder();
                 sb.Append(property.Visibility.ToString().ToLower());
-                sb.Append(" ");
+                sb.Append(' ');
 
                 if (property.RedefinedProperty.Any())
                 {
@@ -66,32 +66,32 @@ public static void RegisterPropertyHelper(this IHandlebars handlebars)
                     if (property.QueryIsReferenceProperty())
                     {
                         sb.Append($"List<Guid>");
-                        sb.Append(" ");
+                        sb.Append(' ');
                     }
                     else
                     {
                         sb.Append($"List<{property.QueryCSharpTypeName()}>");
-                        sb.Append(" ");
+                        sb.Append(' ');
                     }
                 }
                 else
                 {
                     if (property.QueryIsReferenceProperty())
                     {
                         sb.Append($"Guid");
-                        sb.Append(" ");
+                        sb.Append(' ');
                     }
                     else
                     {
                         sb.Append($"{property.QueryCSharpTypeName()}");
-                        sb.Append(" ");
+                        sb.Append(' ');
                     }
                 }
 
                 var propertyName = property.Name.Trim().CapitalizeFirstLetter();
 
                 sb.Append(propertyName);
-                sb.Append(" ");
+                sb.Append(' ');
 
                 if (property.IsDerived || property.IsDerivedUnion)
                 {
@@ -122,7 +122,7 @@ public static void RegisterPropertyHelper(this IHandlebars handlebars)
                 if (!isRedefinedByProperty)
                 {
                     sb.Append(property.Visibility.ToString().ToLower(CultureInfo.InvariantCulture));
-                    sb.Append(" ");
+                    sb.Append(' ');
                 }
 
                 if (property.RedefinedProperty.Any())
@@ -135,25 +135,25 @@ public static void RegisterPropertyHelper(this IHandlebars handlebars)
                     if (property.QueryIsReferenceProperty())
                     {
                         sb.Append($"List<Guid>");
-                        sb.Append(" ");
+                        sb.Append(' ');
                     }
                     else
                     {
                         sb.Append($"List<{property.QueryCSharpTypeName()}>");
-                        sb.Append(" ");
+                        sb.Append(' ');
                     }
                 }
                 else
                 {
                     if (property.QueryIsReferenceProperty())
                     {
                         sb.Append($"Guid");
-                        sb.Append(" ");
+                        sb.Append(' ');
                     }
                     else
                     {
                         sb.Append($"{property.QueryCSharpTypeName()}");
-                        sb.Append(" ");
+                        sb.Append(' ');
                     }
                 }
 
@@ -167,7 +167,7 @@ public static void RegisterPropertyHelper(this IHandlebars handlebars)
                 var propertyName = property.Name.Trim().CapitalizeFirstLetter();
 
                 sb.Append(propertyName);
-                sb.Append(" ");
+                sb.Append(' ');
 
                 if (!isRedefinedByProperty)
                 {
@@ -192,7 +192,7 @@ public static void RegisterPropertyHelper(this IHandlebars handlebars)
                     sb.AppendLine("{");
                     sb.AppendLine($"    get => throw new InvalidOperationException(\"Redefined by property I{owningClass.Name}.{redefiningProperty.Name.CapitalizeFirstLetter()}\");");
                     sb.AppendLine($"    set => throw new InvalidOperationException(\"Redefined by property I{owningClass.Name}.{redefiningProperty.Name.CapitalizeFirstLetter()}\");");
-                    sb.Append("}");
+                    sb.Append('}');
                 }
 
                 writer.WriteSafeString(sb + Environment.NewLine);
diff --git a/SysML2.NET.CodeGenerator/Resources/HtmlDocs/css/starionclassdocs.css b/SysML2.NET.CodeGenerator/Resources/HtmlDocs/css/starionclassdocs.css
@@ -112,13 +112,11 @@ ol ol {
     text-decoration: none;
     transition: all .3s ease-out;
     letter-spacing: 1px;
-	/*text-transform: uppercase;*/
 	font-size: 6pt;
 }
 
 .rectangle-list a{
     position: relative;
-    /*text-transform: uppercase;*/
     padding: .4em .4em .4em .8em;
     *padding: .4em;
     margin: .5em 0 .5em 2.5em;
@@ -178,12 +176,12 @@ ul.rectangle-list a:before{
     left: -1em;
     top: 50%;
     margin-top: -.5em;
-    transition: all .3s ease-out;               
+    transition: all .3s ease-out;
 }
 
 .rectangle-list a:hover:after{
     left: -.5em;
-    border-left-color: #BFD9FF;             
+    border-left-color: #BFD9FF;
 }
 
 h2 {
diff --git a/SysML2.NET.Dal.Tests/AssemblerTestFixture.cs b/SysML2.NET.Dal.Tests/AssemblerTestFixture.cs
@@ -33,7 +33,7 @@ namespace SysML2.NET.Dal.Tests
 	[TestFixture]
 	public class AssemblerTestFixture
 	{
-		private IAssembler assembler;
+		private Assembler assembler;
 
         private Lazy<Core.POCO.IElement> lazyPoco;
 
diff --git a/SysML2.NET.Serializer.Json/PIM/BranchDeserializer.cs b/SysML2.NET.Serializer.Json/PIM/BranchDeserializer.cs
@@ -64,7 +64,7 @@ internal static Branch DeSerialize(JsonElement jsonElement, SerializationModeKin
                 throw new InvalidOperationException($"The BranchDeserializer can only be used to deserialize objects of type Branch, a {@type.GetString()} was provided");
             }
 
-            logger.Log(LogLevel.Trace, "start deserialization: Branch");
+            logger.LogTrace("start deserialization: Branch");
 
             var dtoInstance = new SysML2.NET.PIM.DTO.Branch();
 
@@ -88,7 +88,7 @@ internal static Branch DeSerialize(JsonElement jsonElement, SerializationModeKin
             }
             else 
             {
-                logger.LogDebug($"the alias Json property was not found in the Branch: {dtoInstance.Id}");
+                logger.LogDebug("the alias Json property was not found in the Branch: {Identifier}", dtoInstance.Id);
             }
 
             if (jsonElement.TryGetProperty("created"u8, out JsonElement createdProperty))
@@ -97,7 +97,7 @@ internal static Branch DeSerialize(JsonElement jsonElement, SerializationModeKin
             }
             else
             {
-                logger.LogDebug($"the created Json property was not found in the Branch: {dtoInstance.Id}");
+                logger.LogDebug("the created Json property was not found in the Branch: {Identifier}", dtoInstance.Id);
             }
 
             if (jsonElement.TryGetProperty("description"u8, out JsonElement descriptionProperty))
@@ -110,14 +110,14 @@ internal static Branch DeSerialize(JsonElement jsonElement, SerializationModeKin
             }
             else
             {
-                logger.LogDebug($"the name Json property was not found in the Branch: {dtoInstance.Id}");
+                logger.LogDebug("the name Json property was not found in the Branch: {Identifier}", dtoInstance.Id);
             }
 
             if (jsonElement.TryGetProperty("head"u8, out JsonElement headProperty))
             {
                 if (headProperty.ValueKind == JsonValueKind.Null)
                 {
-                    logger.LogWarning($"the head Json property was null which should not be allowed: Branch {dtoInstance.Id}");
+                    logger.LogWarning("the head Json property was null which should not be allowed: Branch {Identifier}", dtoInstance.Id);
                 }
                 else
                 {
@@ -133,7 +133,7 @@ internal static Branch DeSerialize(JsonElement jsonElement, SerializationModeKin
             }
             else
             {
-                logger.LogDebug($"the head Json property was not found in the Branch: {dtoInstance.Id}");
+                logger.LogDebug("the head Json property was not found in the Branch: {Identifier}", dtoInstance.Id);
             }
 
             if (jsonElement.TryGetProperty("name"u8, out JsonElement nameProperty))
@@ -146,7 +146,7 @@ internal static Branch DeSerialize(JsonElement jsonElement, SerializationModeKin
             }
             else
             {
-                logger.LogDebug($"the name Json property was not found in the Branch: {dtoInstance.Id}");
+                logger.LogDebug("the name Json property was not found in the Branch: {Identifier}", dtoInstance.Id);
             }
 
             if (jsonElement.TryGetProperty("owningProject"u8, out JsonElement owningProjectProperty))
@@ -169,7 +169,7 @@ internal static Branch DeSerialize(JsonElement jsonElement, SerializationModeKin
             }
             else
             {
-                logger.LogDebug($"the owningProject Json property was not found in the Branch: {dtoInstance.Id}");
+                logger.LogDebug("the owningProject Json property was not found in the Branch: {Identifier}", dtoInstance.Id);
             }
 
             if (jsonElement.TryGetProperty("resourceIdentifier"u8, out JsonElement resourceIdentifierProperty))
@@ -178,10 +178,10 @@ internal static Branch DeSerialize(JsonElement jsonElement, SerializationModeKin
             }
             else
             {
-                logger.LogDebug($"the resourceIdentifier Json property was not found in the Branch: {dtoInstance.Id}");
+                logger.LogDebug("the resourceIdentifier Json property was not found in the Branch: {Identifier}", dtoInstance.Id);
             }
 
-            logger.Log(LogLevel.Trace, "finish deserialization: Branch");
+            logger.LogTrace("finish deserialization: Branch");
 
             return dtoInstance;
         }
diff --git a/SysML2.NET.Serializer.Json/PIM/ProjectDeSerializer.cs b/SysML2.NET.Serializer.Json/PIM/ProjectDeSerializer.cs
@@ -64,7 +64,7 @@ internal static Project DeSerialize(JsonElement jsonElement, SerializationModeKi
                 throw new InvalidOperationException($"The ProjectDeSerializer can only be used to deserialize objects of type Project, a {@type.GetString()} was provided");
             }
 
-            logger.Log(LogLevel.Trace, "start deserialization: Project");
+            logger.LogTrace("start deserialization: Project");
 
             var dtoInstance = new SysML2.NET.PIM.DTO.Project();
 
@@ -94,7 +94,7 @@ internal static Project DeSerialize(JsonElement jsonElement, SerializationModeKi
             }
             else
             {
-                logger.LogDebug($"the alias Json property was not found in the Project: {dtoInstance.Id}");
+                logger.LogDebug("the alias Json property was not found in the Project: {Identifier}", dtoInstance.Id);
             }
 
             if (jsonElement.TryGetProperty("created"u8, out JsonElement createdProperty))
@@ -106,12 +106,12 @@ internal static Project DeSerialize(JsonElement jsonElement, SerializationModeKi
                 }
                 else
                 {
-                    logger.LogDebug($"the created Json property was null in the Project: {dtoInstance.Id}");
+                    logger.LogDebug("the created Json property was null in the Project: {Identifier}", dtoInstance.Id);
                 }
             }
             else
             {
-                logger.LogDebug($"the created Json property was not found in the Project: {dtoInstance.Id}");
+                logger.LogDebug("the created Json property was not found in the Project: {Identifier}", dtoInstance.Id);
             }
 
             if (jsonElement.TryGetProperty("defaultBranch"u8, out JsonElement defaultBranchProperty))
@@ -134,7 +134,7 @@ internal static Project DeSerialize(JsonElement jsonElement, SerializationModeKi
             }
             else
             {
-                logger.LogDebug($"the defaultBranch Json property was not found in the Project: {dtoInstance.Id}");
+                logger.LogDebug("the defaultBranch Json property was not found in the Project: {Identifier}", dtoInstance.Id);
             }
             
             if (jsonElement.TryGetProperty("description"u8, out JsonElement descriptionProperty))
@@ -147,7 +147,7 @@ internal static Project DeSerialize(JsonElement jsonElement, SerializationModeKi
             }
             else
             {
-                logger.LogDebug($"the name Json property was not found in the Project: {dtoInstance.Id}");
+                logger.LogDebug("the name Json property was not found in the Project: {Identifier}", dtoInstance.Id);
             }
 
             if (jsonElement.TryGetProperty("name"u8, out JsonElement nameProperty))
@@ -160,7 +160,7 @@ internal static Project DeSerialize(JsonElement jsonElement, SerializationModeKi
             }
             else
             {
-                logger.LogDebug($"the name Json property was not found in the Project: {dtoInstance.Id}");
+                logger.LogDebug("the name Json property was not found in the Project: {Identifier}", dtoInstance.Id);
             }
 
             if (jsonElement.TryGetProperty("resourceIdentifier"u8, out JsonElement resourceIdentifierProperty))
@@ -169,10 +169,10 @@ internal static Project DeSerialize(JsonElement jsonElement, SerializationModeKi
             }
             else
             {
-                logger.LogDebug($"the resourceIdentifier Json property was not found in the Project: {dtoInstance.Id}");
+                logger.LogDebug("the resourceIdentifier Json property was not found in the Project: {Identifier}", dtoInstance.Id);
             }
 
-            logger.Log(LogLevel.Trace, "finish deserialization: Project");
+            logger.LogTrace("finish deserialization: Project");
 
             return dtoInstance;
         }
diff --git a/SysML2.NET/PIM/DTO/ProjectUsage.cs b/SysML2.NET/PIM/DTO/ProjectUsage.cs
@@ -41,7 +41,7 @@ public class ProjectUsage : IData
         public Guid UsedCommit { get; set; }
 
         /// <summary>
-        /// Gets or sets the reference to the <see cref="Projec"/> of the <see cref="Project"/> being used.
+        /// Gets or sets the reference to the <see cref="Project"/> of the <see cref="Project"/> being used.
         /// </summary>
         public Guid UsedProject { get; set; }
     }

Original file line number	Diff line number	Diff line change
`@@ -409,7 +409,7 @@ public static string RemoveUnwantedHtmlTags(this string html, List<string> unwan`
`409`	`409`
`410`	`410`	`HtmlNodeCollection tryGetNodes = document.DocumentNode.SelectNodes("./*\|./text()");`
`411`	`411`
`412`		`- if (tryGetNodes == null \|\| !tryGetNodes.Any())`
	`412`	`+ if (tryGetNodes == null \|\| tryGetNodes.Count == 0)`
`413`	`413`	`{`
`414`	`414`	`return html;`
`415`	`415`	`}`
Original file line number	Diff line number	Diff line change
`@@ -112,6 +112,6 @@ public HandlebarsPayload(IPackage rootPackage, IEnumerable<IPackage> packages, I`
`112`	`112`	`/// <summary>`
`113`	`113`	`/// Gets the version of the reporting library`
`114`	`114`	`/// </summary>`
`115`		`- public string Version => Assembly.GetExecutingAssembly().GetName().Version?.ToString();`
	`115`	`+ public static string Version => Assembly.GetExecutingAssembly().GetName().Version?.ToString();`
`116`	`116`	`}`
`117`	`117`	`}`
Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ public static void RegisterPropertyHelper(this IHandlebars handlebars)`
`54`	`54`
`55`	`55`	`var sb = new StringBuilder();`
`56`	`56`	`sb.Append(property.Visibility.ToString().ToLower());`
`57`		`- sb.Append(" ");`
	`57`	`+ sb.Append(' ');`
`58`	`58`
`59`	`59`	`if (property.RedefinedProperty.Any())`
`60`	`60`	`{`
`@@ -66,32 +66,32 @@ public static void RegisterPropertyHelper(this IHandlebars handlebars)`
`66`	`66`	`if (property.QueryIsReferenceProperty())`
`67`	`67`	`{`
`68`	`68`	`sb.Append($"List<Guid>");`
`69`		`- sb.Append(" ");`
	`69`	`+ sb.Append(' ');`
`70`	`70`	`}`
`71`	`71`	`else`
`72`	`72`	`{`
`73`	`73`	`sb.Append($"List<{property.QueryCSharpTypeName()}>");`
`74`		`- sb.Append(" ");`
	`74`	`+ sb.Append(' ');`
`75`	`75`	`}`
`76`	`76`	`}`
`77`	`77`	`else`
`78`	`78`	`{`
`79`	`79`	`if (property.QueryIsReferenceProperty())`
`80`	`80`	`{`
`81`	`81`	`sb.Append($"Guid");`
`82`		`- sb.Append(" ");`
	`82`	`+ sb.Append(' ');`
`83`	`83`	`}`
`84`	`84`	`else`
`85`	`85`	`{`
`86`	`86`	`sb.Append($"{property.QueryCSharpTypeName()}");`
`87`		`- sb.Append(" ");`
	`87`	`+ sb.Append(' ');`
`88`	`88`	`}`
`89`	`89`	`}`
`90`	`90`
`91`	`91`	`var propertyName = property.Name.Trim().CapitalizeFirstLetter();`
`92`	`92`
`93`	`93`	`sb.Append(propertyName);`
`94`		`- sb.Append(" ");`
	`94`	`+ sb.Append(' ');`
`95`	`95`
`96`	`96`	`if (property.IsDerived \|\| property.IsDerivedUnion)`
`97`	`97`	`{`
`@@ -122,7 +122,7 @@ public static void RegisterPropertyHelper(this IHandlebars handlebars)`
`122`	`122`	`if (!isRedefinedByProperty)`
`123`	`123`	`{`
`124`	`124`	`sb.Append(property.Visibility.ToString().ToLower(CultureInfo.InvariantCulture));`
`125`		`- sb.Append(" ");`
	`125`	`+ sb.Append(' ');`
`126`	`126`	`}`
`127`	`127`
`128`	`128`	`if (property.RedefinedProperty.Any())`
`@@ -135,25 +135,25 @@ public static void RegisterPropertyHelper(this IHandlebars handlebars)`
`135`	`135`	`if (property.QueryIsReferenceProperty())`
`136`	`136`	`{`
`137`	`137`	`sb.Append($"List<Guid>");`
`138`		`- sb.Append(" ");`
	`138`	`+ sb.Append(' ');`
`139`	`139`	`}`
`140`	`140`	`else`
`141`	`141`	`{`
`142`	`142`	`sb.Append($"List<{property.QueryCSharpTypeName()}>");`
`143`		`- sb.Append(" ");`
	`143`	`+ sb.Append(' ');`
`144`	`144`	`}`
`145`	`145`	`}`
`146`	`146`	`else`
`147`	`147`	`{`
`148`	`148`	`if (property.QueryIsReferenceProperty())`
`149`	`149`	`{`
`150`	`150`	`sb.Append($"Guid");`
`151`		`- sb.Append(" ");`
	`151`	`+ sb.Append(' ');`
`152`	`152`	`}`
`153`	`153`	`else`
`154`	`154`	`{`
`155`	`155`	`sb.Append($"{property.QueryCSharpTypeName()}");`
`156`		`- sb.Append(" ");`
	`156`	`+ sb.Append(' ');`
`157`	`157`	`}`
`158`	`158`	`}`
`159`	`159`
`@@ -167,7 +167,7 @@ public static void RegisterPropertyHelper(this IHandlebars handlebars)`
`167`	`167`	`var propertyName = property.Name.Trim().CapitalizeFirstLetter();`
`168`	`168`
`169`	`169`	`sb.Append(propertyName);`
`170`		`- sb.Append(" ");`
	`170`	`+ sb.Append(' ');`
`171`	`171`
`172`	`172`	`if (!isRedefinedByProperty)`
`173`	`173`	`{`
`@@ -192,7 +192,7 @@ public static void RegisterPropertyHelper(this IHandlebars handlebars)`
`192`	`192`	`sb.AppendLine("{");`
`193`	`193`	`sb.AppendLine($" get => throw new InvalidOperationException(\"Redefined by property I{owningClass.Name}.{redefiningProperty.Name.CapitalizeFirstLetter()}\");");`
`194`	`194`	`sb.AppendLine($" set => throw new InvalidOperationException(\"Redefined by property I{owningClass.Name}.{redefiningProperty.Name.CapitalizeFirstLetter()}\");");`
`195`		`- sb.Append("}");`
	`195`	`+ sb.Append('}');`
`196`	`196`	`}`
`197`	`197`
`198`	`198`	`writer.WriteSafeString(sb + Environment.NewLine);`
Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ namespace SysML2.NET.Dal.Tests`
`33`	`33`	`[TestFixture]`
`34`	`34`	`public class AssemblerTestFixture`
`35`	`35`	`{`
`36`		`- private IAssembler assembler;`
	`36`	`+ private Assembler assembler;`
`37`	`37`
`38`	`38`	`private Lazy<Core.POCO.IElement> lazyPoco;`
`39`	`39`
Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ internal static Branch DeSerialize(JsonElement jsonElement, SerializationModeKin`
`64`	`64`	`throw new InvalidOperationException($"The BranchDeserializer can only be used to deserialize objects of type Branch, a {@type.GetString()} was provided");`
`65`	`65`	`}`
`66`	`66`
`67`		`- logger.Log(LogLevel.Trace, "start deserialization: Branch");`
	`67`	`+ logger.LogTrace("start deserialization: Branch");`
`68`	`68`
`69`	`69`	`var dtoInstance = new SysML2.NET.PIM.DTO.Branch();`
`70`	`70`
`@@ -88,7 +88,7 @@ internal static Branch DeSerialize(JsonElement jsonElement, SerializationModeKin`
`88`	`88`	`}`
`89`	`89`	`else`
`90`	`90`	`{`
`91`		`- logger.LogDebug($"the alias Json property was not found in the Branch: {dtoInstance.Id}");`
	`91`	`+ logger.LogDebug("the alias Json property was not found in the Branch: {Identifier}", dtoInstance.Id);`
`92`	`92`	`}`
`93`	`93`
`94`	`94`	`if (jsonElement.TryGetProperty("created"u8, out JsonElement createdProperty))`
`@@ -97,7 +97,7 @@ internal static Branch DeSerialize(JsonElement jsonElement, SerializationModeKin`
`97`	`97`	`}`
`98`	`98`	`else`
`99`	`99`	`{`
`100`		`- logger.LogDebug($"the created Json property was not found in the Branch: {dtoInstance.Id}");`
	`100`	`+ logger.LogDebug("the created Json property was not found in the Branch: {Identifier}", dtoInstance.Id);`
`101`	`101`	`}`
`102`	`102`
`103`	`103`	`if (jsonElement.TryGetProperty("description"u8, out JsonElement descriptionProperty))`
`@@ -110,14 +110,14 @@ internal static Branch DeSerialize(JsonElement jsonElement, SerializationModeKin`
`110`	`110`	`}`
`111`	`111`	`else`
`112`	`112`	`{`
`113`		`- logger.LogDebug($"the name Json property was not found in the Branch: {dtoInstance.Id}");`
	`113`	`+ logger.LogDebug("the name Json property was not found in the Branch: {Identifier}", dtoInstance.Id);`
`114`	`114`	`}`
`115`	`115`
`116`	`116`	`if (jsonElement.TryGetProperty("head"u8, out JsonElement headProperty))`
`117`	`117`	`{`
`118`	`118`	`if (headProperty.ValueKind == JsonValueKind.Null)`
`119`	`119`	`{`
`120`		`- logger.LogWarning($"the head Json property was null which should not be allowed: Branch {dtoInstance.Id}");`
	`120`	`+ logger.LogWarning("the head Json property was null which should not be allowed: Branch {Identifier}", dtoInstance.Id);`
`121`	`121`	`}`
`122`	`122`	`else`
`123`	`123`	`{`
`@@ -133,7 +133,7 @@ internal static Branch DeSerialize(JsonElement jsonElement, SerializationModeKin`
`133`	`133`	`}`
`134`	`134`	`else`
`135`	`135`	`{`
`136`		`- logger.LogDebug($"the head Json property was not found in the Branch: {dtoInstance.Id}");`
	`136`	`+ logger.LogDebug("the head Json property was not found in the Branch: {Identifier}", dtoInstance.Id);`
`137`	`137`	`}`
`138`	`138`
`139`	`139`	`if (jsonElement.TryGetProperty("name"u8, out JsonElement nameProperty))`
`@@ -146,7 +146,7 @@ internal static Branch DeSerialize(JsonElement jsonElement, SerializationModeKin`
`146`	`146`	`}`
`147`	`147`	`else`
`148`	`148`	`{`
`149`		`- logger.LogDebug($"the name Json property was not found in the Branch: {dtoInstance.Id}");`
	`149`	`+ logger.LogDebug("the name Json property was not found in the Branch: {Identifier}", dtoInstance.Id);`
`150`	`150`	`}`
`151`	`151`
`152`	`152`	`if (jsonElement.TryGetProperty("owningProject"u8, out JsonElement owningProjectProperty))`
`@@ -169,7 +169,7 @@ internal static Branch DeSerialize(JsonElement jsonElement, SerializationModeKin`
`169`	`169`	`}`
`170`	`170`	`else`
`171`	`171`	`{`
`172`		`- logger.LogDebug($"the owningProject Json property was not found in the Branch: {dtoInstance.Id}");`
	`172`	`+ logger.LogDebug("the owningProject Json property was not found in the Branch: {Identifier}", dtoInstance.Id);`
`173`	`173`	`}`
`174`	`174`
`175`	`175`	`if (jsonElement.TryGetProperty("resourceIdentifier"u8, out JsonElement resourceIdentifierProperty))`
`@@ -178,10 +178,10 @@ internal static Branch DeSerialize(JsonElement jsonElement, SerializationModeKin`
`178`	`178`	`}`
`179`	`179`	`else`
`180`	`180`	`{`
`181`		`- logger.LogDebug($"the resourceIdentifier Json property was not found in the Branch: {dtoInstance.Id}");`
	`181`	`+ logger.LogDebug("the resourceIdentifier Json property was not found in the Branch: {Identifier}", dtoInstance.Id);`
`182`	`182`	`}`
`183`	`183`
`184`		`- logger.Log(LogLevel.Trace, "finish deserialization: Branch");`
	`184`	`+ logger.LogTrace("finish deserialization: Branch");`
`185`	`185`
`186`	`186`	`return dtoInstance;`
`187`	`187`	`}`
Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ internal static Project DeSerialize(JsonElement jsonElement, SerializationModeKi`
`64`	`64`	`throw new InvalidOperationException($"The ProjectDeSerializer can only be used to deserialize objects of type Project, a {@type.GetString()} was provided");`
`65`	`65`	`}`
`66`	`66`
`67`		`- logger.Log(LogLevel.Trace, "start deserialization: Project");`
	`67`	`+ logger.LogTrace("start deserialization: Project");`
`68`	`68`
`69`	`69`	`var dtoInstance = new SysML2.NET.PIM.DTO.Project();`
`70`	`70`
`@@ -94,7 +94,7 @@ internal static Project DeSerialize(JsonElement jsonElement, SerializationModeKi`
`94`	`94`	`}`
`95`	`95`	`else`
`96`	`96`	`{`
`97`		`- logger.LogDebug($"the alias Json property was not found in the Project: {dtoInstance.Id}");`
	`97`	`+ logger.LogDebug("the alias Json property was not found in the Project: {Identifier}", dtoInstance.Id);`
`98`	`98`	`}`
`99`	`99`
`100`	`100`	`if (jsonElement.TryGetProperty("created"u8, out JsonElement createdProperty))`
`@@ -106,12 +106,12 @@ internal static Project DeSerialize(JsonElement jsonElement, SerializationModeKi`
`106`	`106`	`}`
`107`	`107`	`else`
`108`	`108`	`{`
`109`		`- logger.LogDebug($"the created Json property was null in the Project: {dtoInstance.Id}");`
	`109`	`+ logger.LogDebug("the created Json property was null in the Project: {Identifier}", dtoInstance.Id);`
`110`	`110`	`}`
`111`	`111`	`}`
`112`	`112`	`else`
`113`	`113`	`{`
`114`		`- logger.LogDebug($"the created Json property was not found in the Project: {dtoInstance.Id}");`
	`114`	`+ logger.LogDebug("the created Json property was not found in the Project: {Identifier}", dtoInstance.Id);`
`115`	`115`	`}`
`116`	`116`
`117`	`117`	`if (jsonElement.TryGetProperty("defaultBranch"u8, out JsonElement defaultBranchProperty))`
`@@ -134,7 +134,7 @@ internal static Project DeSerialize(JsonElement jsonElement, SerializationModeKi`
`134`	`134`	`}`
`135`	`135`	`else`
`136`	`136`	`{`
`137`		`- logger.LogDebug($"the defaultBranch Json property was not found in the Project: {dtoInstance.Id}");`
	`137`	`+ logger.LogDebug("the defaultBranch Json property was not found in the Project: {Identifier}", dtoInstance.Id);`
`138`	`138`	`}`
`139`	`139`
`140`	`140`	`if (jsonElement.TryGetProperty("description"u8, out JsonElement descriptionProperty))`
`@@ -147,7 +147,7 @@ internal static Project DeSerialize(JsonElement jsonElement, SerializationModeKi`
`147`	`147`	`}`
`148`	`148`	`else`
`149`	`149`	`{`
`150`		`- logger.LogDebug($"the name Json property was not found in the Project: {dtoInstance.Id}");`
	`150`	`+ logger.LogDebug("the name Json property was not found in the Project: {Identifier}", dtoInstance.Id);`
`151`	`151`	`}`
`152`	`152`
`153`	`153`	`if (jsonElement.TryGetProperty("name"u8, out JsonElement nameProperty))`
`@@ -160,7 +160,7 @@ internal static Project DeSerialize(JsonElement jsonElement, SerializationModeKi`
`160`	`160`	`}`
`161`	`161`	`else`
`162`	`162`	`{`
`163`		`- logger.LogDebug($"the name Json property was not found in the Project: {dtoInstance.Id}");`
	`163`	`+ logger.LogDebug("the name Json property was not found in the Project: {Identifier}", dtoInstance.Id);`
`164`	`164`	`}`
`165`	`165`
`166`	`166`	`if (jsonElement.TryGetProperty("resourceIdentifier"u8, out JsonElement resourceIdentifierProperty))`
`@@ -169,10 +169,10 @@ internal static Project DeSerialize(JsonElement jsonElement, SerializationModeKi`
`169`	`169`	`}`
`170`	`170`	`else`
`171`	`171`	`{`
`172`		`- logger.LogDebug($"the resourceIdentifier Json property was not found in the Project: {dtoInstance.Id}");`
	`172`	`+ logger.LogDebug("the resourceIdentifier Json property was not found in the Project: {Identifier}", dtoInstance.Id);`
`173`	`173`	`}`
`174`	`174`
`175`		`- logger.Log(LogLevel.Trace, "finish deserialization: Project");`
	`175`	`+ logger.LogTrace("finish deserialization: Project");`
`176`	`176`
`177`	`177`	`return dtoInstance;`
`178`	`178`	`}`
Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ public class ProjectUsage : IData`
`41`	`41`	`public Guid UsedCommit { get; set; }`
`42`	`42`
`43`	`43`	`/// <summary>`
`44`		`- /// Gets or sets the reference to the <see cref="Projec"/> of the <see cref="Project"/> being used.`
	`44`	`+ /// Gets or sets the reference to the <see cref="Project"/> of the <see cref="Project"/> being used.`
`45`	`45`	`/// </summary>`
`46`	`46`	`public Guid UsedProject { get; set; }`
`47`	`47`	`}`