From c4ea3a88eb17d54a655a9c6e4bd6d8a0466dfcfc Mon Sep 17 00:00:00 2001 From: kelle Date: Tue, 1 Jul 2025 15:35:56 -0400 Subject: [PATCH 1/3] update scheduled tests --- tests/scheduled_checks.py | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/tests/scheduled_checks.py b/tests/scheduled_checks.py index bbc874956..dc0f28f3b 100644 --- a/tests/scheduled_checks.py +++ b/tests/scheduled_checks.py @@ -93,16 +93,17 @@ def test_source_simbad(db): ) duplicate_count += 1 - assert duplicate_count == 0, "Duplicate sources identified via Simbad queries" - - # with open("not_in_simbad.txt", "w") as f: + # Write not_in_simbad list to file + # with open("tests/not_in_simbad_25Jul1.txt", "w") as f: # f.write("\n".join(not_in_simbad)) + assert duplicate_count == 0, "Duplicate sources identified via Simbad queries" + assert ( - len(not_in_simbad) == 371 + len(not_in_simbad) == 370 ), f"Expecting {len(not_in_simbad)} sources not found in Simbad" - assert len(in_simbad) == 3227, "Sources found in Simbad" + assert len(in_simbad) == 3228, "Sources found in Simbad" print(f"Found {len(in_simbad)} SIMPLE sources in Simbad") assert len(not_in_simbad) + len(in_simbad) == len( From bf60c0c0b03d0b59fabb1352ba01246f76f721fb Mon Sep 17 00:00:00 2001 From: kelle Date: Tue, 1 Jul 2025 15:36:13 -0400 Subject: [PATCH 2/3] make wise1049 names simbadable --- data/source/wise_j104915.57-531906.1.json | 8 ++++---- data/source/wise_j104915.57-531906.1A.json | 13 ++++++++----- data/source/wise_j104915.57-531906.1B.json | 8 ++++---- 3 files changed, 16 insertions(+), 13 deletions(-) diff --git a/data/source/wise_j104915.57-531906.1.json b/data/source/wise_j104915.57-531906.1.json index bc4106970..d61063583 100644 --- a/data/source/wise_j104915.57-531906.1.json +++ b/data/source/wise_j104915.57-531906.1.json @@ -14,16 +14,16 @@ ], "CompanionRelationships": [ { - "companion_name": "WISE J104915.57-531906.1A", + "companion_name": "WISE J1049-5319A", "relationship": "Parent", "reference": "Luhm13", - "other_companion_names": "WISE J104915.57-531906.1A" + "other_companion_names": "Luhman 16A" }, { - "companion_name": "WISE J104915.57-531906.1B", + "companion_name": "WISE J1049-5319B", "relationship": "Parent", "reference": "Luhm13", - "other_companion_names": "WISE J104915.57-531906.1B" + "other_companion_names": "Luhman 16B" } ], "Names": [ diff --git a/data/source/wise_j104915.57-531906.1A.json b/data/source/wise_j104915.57-531906.1A.json index 1ace0d138..3f7a4a9c8 100644 --- a/data/source/wise_j104915.57-531906.1A.json +++ b/data/source/wise_j104915.57-531906.1A.json @@ -1,7 +1,7 @@ { "Sources": [ { - "source": "WISE J104915.57-531906.1A", + "source": "WISE J1049-5319A", "ra": 162.329, "dec": -53.3194, "epoch": 2000.0, @@ -17,13 +17,13 @@ "companion_name": "WISE J104915.57-531906.1", "relationship": "Child", "reference": "Luhm13", - "other_companion_names": "WISE J104915.57-531906.1" + "other_companion_names": null }, { - "companion_name": "WISE J104915.57-531906.1B", + "companion_name": "WISE J1049-5319B", "relationship": "Sibling", "reference": "Luhm13", - "other_companion_names": "WISE J104915.57-531906.1B" + "other_companion_names": "Luhman 16B" } ], "ModeledParameters": [ @@ -68,7 +68,10 @@ "other_name": "NAME Luhman 16A" }, { - "other_name": "WISE J104915.57-531906.1A" + "other_name": "WISE J1049-5319A" + }, + { + "other_name": "Gaia DR2 5353626573555863424" } ], "Spectra": [ diff --git a/data/source/wise_j104915.57-531906.1B.json b/data/source/wise_j104915.57-531906.1B.json index 2800c11e3..fdf743b61 100644 --- a/data/source/wise_j104915.57-531906.1B.json +++ b/data/source/wise_j104915.57-531906.1B.json @@ -1,7 +1,7 @@ { "Sources": [ { - "source": "WISE J104915.57-531906.1B", + "source": "WISE J1049-5319B", "ra": 162.329, "dec": -53.3192, "epoch": 2000.0, @@ -20,10 +20,10 @@ "other_companion_names": "WISE J104915.57-531906.1" }, { - "companion_name": "WISE J104915.57-531906.1A", + "companion_name": "WISE J1049-5319A", "relationship": "Sibling", "reference": "Luhm13", - "other_companion_names": "WISE J104915.57-531906.1A" + "other_companion_names": "Luhman 16A" } ], "ModeledParameters": [ @@ -68,7 +68,7 @@ "other_name": "NAME Luhman 16B" }, { - "other_name": "WISE J104915.57-531906.1B" + "other_name": "WISE J1049-5319B" } ], "Spectra": [ From 1b419605620702d1088d2c2fc029f27574f8522b Mon Sep 17 00:00:00 2001 From: kelle Date: Tue, 1 Jul 2025 15:40:45 -0400 Subject: [PATCH 3/3] updated tests --- tests/test_data.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/test_data.py b/tests/test_data.py index fd927f156..f6c079019 100644 --- a/tests/test_data.py +++ b/tests/test_data.py @@ -19,7 +19,7 @@ def test_sources(db): assert n_sources == 3598, f"found {n_sources} sources" n_names = db.query(db.Names).count() - assert n_names == 9172, f"found {n_names} names" + assert n_names == 9173, f"found {n_names} names" @pytest.mark.parametrize( @@ -98,7 +98,7 @@ def test_missions(db): ) s = db.session.scalars(stm).all() assert ( - len(s) == 10 + len(s) == 11 ), f"found {len(s)} sources with Gaia designation that have no GAIA photometry" # If Gaia photometry, Gaia designation should be in Names