Fix runtime error if an entry in lscpu isn't an integer but - (or something else).

Author: breyerml

include/hws/utility.hpp

@@ -119,6 +119,13 @@ constexpr bool is_vector_v = is_vector<T>::value;
  */
 [[nodiscard]] std::vector<std::string_view> split(std::string_view str, char delim = ' ');
 
+/**
+ * @brief Check whether @p str is an integer
+ * @param[in] str the string to check
+ * @return `true` if @p str is an integer, `false` otherwise
+ */
+[[nodiscard]] bool is_integer(std::string_view str);
+
 /**
  * @brief Convert the @p str to a value of type @p T.
  * @tparam T the type to convert the string to

src/hws/cpu/hardware_sampler.cpp

@@ -78,15 +78,15 @@ void cpu_hardware_sampler::sampling_loop() {
                     general_samples_.architecture_ = detail::convert_to<decltype(general_samples_.architecture_)::value_type>(value);
                 } else if (detail::starts_with(line, "Byte Order")) {
                     general_samples_.byte_order_ = detail::convert_to<decltype(general_samples_.byte_order_)::value_type>(value);
-                } else if (detail::starts_with(line, "CPU(s)")) {
+                } else if (detail::starts_with(line, "CPU(s)") && detail::is_integer(value)) {
                     general_samples_.num_threads_ = detail::convert_to<decltype(general_samples_.num_threads_)::value_type>(value);
-                } else if (detail::starts_with(line, "Thread(s) per core")) {
+                } else if (detail::starts_with(line, "Thread(s) per core") && detail::is_integer(value)) {
                     general_samples_.threads_per_core_ = detail::convert_to<decltype(general_samples_.threads_per_core_)::value_type>(value);
-                } else if (detail::starts_with(line, "Core(s) per socket")) {
+                } else if (detail::starts_with(line, "Core(s) per socket") && detail::is_integer(value)) {
                     general_samples_.cores_per_socket_ = detail::convert_to<decltype(general_samples_.cores_per_socket_)::value_type>(value);
-                } else if (detail::starts_with(line, "Socket(s)")) {
+                } else if (detail::starts_with(line, "Socket(s)") && detail::is_integer(value)) {
                     general_samples_.num_sockets_ = detail::convert_to<decltype(general_samples_.num_sockets_)::value_type>(value);
-                } else if (detail::starts_with(line, "NUMA node(s)")) {
+                } else if (detail::starts_with(line, "NUMA node(s)") && detail::is_integer(value)) {
                     general_samples_.numa_nodes_ = detail::convert_to<decltype(general_samples_.numa_nodes_)::value_type>(value);
                 } else if (detail::starts_with(line, "Vendor ID")) {
                     general_samples_.vendor_id_ = detail::convert_to<decltype(general_samples_.vendor_id_)::value_type>(value);

src/hws/utility.cpp

@@ -7,8 +7,8 @@
 
 #include "hws/utility.hpp"
 
-#include <algorithm>    // std::min, std::transform
-#include <cctype>       // std::tolower
+#include <algorithm>    // std::min, std::transform, std::all_of
+#include <cctype>       // std::tolower, std::isdigit
 #include <string>       // std::string
 #include <string_view>  // std::string_view
 #include <vector>       // std::vector
@@ -57,4 +57,8 @@ std::vector<std::string_view> split(const std::string_view str, const char delim
     return split_str;
 }
 
+bool is_integer(std::string_view str) {
+    return std::all_of(str.cbegin(), str.cend(), [](const char c) { return std::isdigit(static_cast<unsigned char>(c)); });
+}
+
 }  // namespace hws::detail