Fix jcmd file handling #43

Author: parttimenerd

cf_cli_java_plugin.go

@@ -225,11 +225,13 @@ fi`,
 		SshCommand:    FilterJCMDRemoteMessage + `$JCMD_COMMAND $(pidof java) VM.info | filter_jcmd_remote_message`,
 	},
 	{
-		Name:          "jcmd",
-		Description:   "Run a JCMD command on a running Java application via --args, downloads and deletes all files that are created in the current folder, use '--no-download' to prevent this",
-		RequiredTools: []string{"jcmd"},
-		GenerateFiles: false,
-		SshCommand:    `$JCMD_COMMAND $(pidof java) $$ARGS`,
+		Name:                             "jcmd",
+		Description:                      "Run a JCMD command on a running Java application via --args, downloads and deletes all files that are created in the current folder, use '--no-download' to prevent this",
+		RequiredTools:                    []string{"jcmd"},
+		GenerateFiles:                    false,
+		GenerateArbitraryFiles:           true,
+		GenerateArbitraryFilesFolderName: "jcmd",
+		SshCommand:                       `$JCMD_COMMAND $(pidof java) $$ARGS`,
 	},
 	{
 		Name:          "jfr-start",
@@ -687,9 +689,13 @@ func (c *JavaPlugin) execute(commandExecutor cmd.CommandExecutor, uuidGenerator
 		}
 	}
 	if command.GenerateArbitraryFiles && !noDownload {
-		logVerbose("Processing arbitrary files download")
+		logVerbose(fmt.Sprintf("Processing arbitrary files download: %s", fspath))
+		logVerbose(fmt.Sprintf("cfSSHArguments: %v", cfSSHArguments))
 		// download all files in the generic folder
 		files, err := util.ListFiles(cfSSHArguments, fspath)
+		for i, file := range files {
+			logVerbose(fmt.Sprintf("File %d: %s", i+1, file))
+		}
 		if err != nil {
 			logVerbose(fmt.Sprintf("Failed to list files: %v", err))
 			return "", err

utils/cfutils.go

@@ -187,6 +187,8 @@ func (checker CfJavaPluginUtilImpl) GetAvailablePath(data string, userpath strin
 }
 
 func (checker CfJavaPluginUtilImpl) CopyOverCat(args []string, src string, dest string) error {
+	fmt.Println("Copying file from remote to local: ", src, " to ", dest)
+	fmt.Println("Args used: ", args)
 	f, err := os.OpenFile(dest, os.O_CREATE|os.O_WRONLY|os.O_APPEND, 0666)
 	if err != nil {
 		return errors.New("Error creating local file at  " + dest + ". Please check that you are allowed to create files at the given local path.")