Skip to content
This repository was archived by the owner on Sep 12, 2025. It is now read-only.
This repository was archived by the owner on Sep 12, 2025. It is now read-only.

'migrate' sometimes adds a redundant dependency #34

@codeworrior

Description

@codeworrior

While working on UI5/openui5@c782ce9 , I encountered the following issue with the ui5-migration tooling:

Sometimes, the cleanup of global names adds a dependency again although it exists already. This seems only to happen when the existing dependency uses a relative name (./library or ./Tokenizer).

Before:

sap.ui.define([
	...
	'./Tokenizer',
	...
],
function( ...

After:

sap.ui.define([
	...
	'./Tokenizer',
	...
	"sap/m/Tokenizer",
	...
],
function( ...

To reproduce, you can execute the following commands

cd openui5
git checkout 6555a38
ui5-migration migrate src/sap.m/src/sap/m/MultiComboBox.js

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions