Skip to content

Commit 8533bee

Browse files
committed
ci: fix glam version to 0.30.7 where needed
1 parent facdffc commit 8533bee

File tree

1 file changed

+31
-10
lines changed

1 file changed

+31
-10
lines changed

.github/workflows/push.yaml

Lines changed: 31 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,8 @@ jobs:
4040
strategy:
4141
fail-fast: false
4242
matrix:
43-
rust-gpu-version:
43+
glam-version: [latest]
44+
include:
4445
# As well as testing on each OS, we also want to test to make sure we're still supporting
4546
# older versions of `rust-gpu`. However, we can assume that these tests are already okay
4647
# across platforms, so we only need to test on Linux, the chepeast in terms of minutes.
@@ -52,29 +53,49 @@ jobs:
5253
# """
5354
# It's probably easily fixable. But also `0.7.0` was released in April 2023, so there's
5455
# unlikely many users of it?
55-
- 0.8.0
56-
- 0.9.0
56+
- rust-gpu-version: 0.8.0
57+
- rust-gpu-version: 0.9.0
5758

5859
# target spec introduction
5960
# last version before
60-
- cc752312c3de6813a41189e46476d5c1be5e0bbe
61-
# first version
62-
- 02cefd101014f66b79dffb20a2c2b5b7c9038401
61+
# * fails: compiler too old, `serde` using `#[diagnostic]`
62+
# - rust-gpu-version: cc752312c3de6813a41189e46476d5c1be5e0bbe
63+
# glam-version: 0.30.7
64+
# first version requiring target specs
65+
# * fails: target spec mismatch!
66+
# * resolution: Since this is just a few commits, I'd be fine ignoring it.
67+
# - rust-gpu-version: 02cefd101014f66b79dffb20a2c2b5b7c9038401
68+
# glam-version: 0.30.7
6369
# target specs change again just a few commits later
64-
- bbb61f58b3d24f3f64745050eb214b90bf6dcce9
70+
# * fails: compiler too old, `proc-macro2` using `Literal::byte_character`.
71+
# * resolution: want to support, can't be bothered to hack in old proc-macro2 versions
72+
# - rust-gpu-version: bbb61f58b3d24f3f64745050eb214b90bf6dcce9
73+
# glam-version: 0.30.7
74+
75+
# testing rustc 1.5 months later
76+
- rust-gpu-version: eea8998df9dc2fd8e7a65c5b5b7ae20c238a665a
77+
glam-version: 0.30.7
6578

6679
# just after target specs v2 refactor
6780
# before
68-
- a547c6e45266d613d9fec673e869d7a96181e47b
81+
- rust-gpu-version: a547c6e45266d613d9fec673e869d7a96181e47b
82+
glam-version: 0.30.7
6983
# after
70-
- 2326b87fe1542eeb898065e36ac949307b55386d
84+
- rust-gpu-version: 2326b87fe1542eeb898065e36ac949307b55386d
85+
glam-version: 0.30.7
86+
87+
# glam semver breakage due to vector type refactor
88+
# before, glam fixed to 0.30.7 in this commit
89+
- rust-gpu-version: f79c4181a5dc2d37303947b113f190930c6c1ce6
90+
# after, glam >0.30.8
91+
- rust-gpu-version: e767f24f2565baf1a71bbaf84d453d181cab2417
7192
runs-on: ubuntu-latest
7293
env:
7394
RUST_LOG: debug
7495
steps:
7596
- uses: actions/checkout@v4
7697
- name: Run a full build
77-
run: cargo xtask test-build --rust-gpu-version ${{ matrix.rust-gpu-version }}
98+
run: cargo xtask test-build --rust-gpu-version ${{ matrix.rust-gpu-version }} --glam-version ${{ matrix.glam-version }}
7899

79100
lint:
80101
runs-on: ubuntu-latest

0 commit comments

Comments
 (0)