Intelligent Context Condensation v2 (#10873)

Author: hannesrudolph

src/__tests__/command-mentions.spec.ts

@@ -27,7 +27,7 @@ describe("Command Mentions", () => {
 
 	// Helper function to call parseMentions with required parameters
 	const callParseMentions = async (text: string) => {
-		const result = await parseMentions(
+		return parseMentions(
 			text,
 			"/test/cwd", // cwd
 			mockUrlContentFetcher, // urlContentFetcher
@@ -38,8 +38,6 @@ describe("Command Mentions", () => {
 			50, // maxDiagnosticMessages
 			undefined, // maxReadFileLine
 		)
-		// Return just the text for backward compatibility with existing tests
-		return result.text
 	}
 
 	describe("parseMentions with command support", () => {
@@ -56,10 +54,10 @@ describe("Command Mentions", () => {
 			const result = await callParseMentions(input)
 
 			expect(mockGetCommand).toHaveBeenCalledWith("/test/cwd", "setup")
-			expect(result).toContain('<command name="setup">')
-			expect(result).toContain(commandContent)
-			expect(result).toContain("</command>")
-			expect(result).toContain("Please help me set up the project")
+			expect(result.slashCommandHelp).toContain('<command name="setup">')
+			expect(result.slashCommandHelp).toContain(commandContent)
+			expect(result.slashCommandHelp).toContain("</command>")
+			expect(result.text).toContain("Please help me set up the project")
 		})
 
 		it("should handle multiple commands in message", async () => {
@@ -99,10 +97,10 @@ describe("Command Mentions", () => {
 			expect(mockGetCommand).toHaveBeenCalledWith("/test/cwd", "setup")
 			expect(mockGetCommand).toHaveBeenCalledWith("/test/cwd", "deploy")
 			expect(mockGetCommand).toHaveBeenCalledTimes(2) // Each unique command called once (optimized)
-			expect(result).toContain('<command name="setup">')
-			expect(result).toContain("# Setup Environment")
-			expect(result).toContain('<command name="deploy">')
-			expect(result).toContain("# Deploy Environment")
+			expect(result.slashCommandHelp).toContain('<command name="setup">')
+			expect(result.slashCommandHelp).toContain("# Setup Environment")
+			expect(result.slashCommandHelp).toContain('<command name="deploy">')
+			expect(result.slashCommandHelp).toContain("# Deploy Environment")
 		})
 
 		it("should leave non-existent commands unchanged", async () => {
@@ -114,10 +112,10 @@ describe("Command Mentions", () => {
 
 			expect(mockGetCommand).toHaveBeenCalledWith("/test/cwd", "nonexistent")
 			// The command should remain unchanged in the text
-			expect(result).toBe("/nonexistent command")
+			expect(result.text).toBe("/nonexistent command")
 			// Should not contain any command tags
-			expect(result).not.toContain('<command name="nonexistent">')
-			expect(result).not.toContain("Command 'nonexistent' not found")
+			expect(result.slashCommandHelp).toBeUndefined()
+			expect(result.text).not.toContain("Command 'nonexistent' not found")
 		})
 
 		it("should handle command loading errors during existence check", async () => {
@@ -129,8 +127,8 @@ describe("Command Mentions", () => {
 
 			// When getCommand throws an error during existence check,
 			// the command is treated as non-existent and left unchanged
-			expect(result).toBe("/error-command test")
-			expect(result).not.toContain('<command name="error-command">')
+			expect(result.text).toBe("/error-command test")
+			expect(result.slashCommandHelp).toBeUndefined()
 		})
 
 		it("should handle command loading errors during processing", async () => {
@@ -145,9 +143,9 @@ describe("Command Mentions", () => {
 			const input = "/error-command test"
 			const result = await callParseMentions(input)
 
-			expect(result).toContain('<command name="error-command">')
-			expect(result).toContain("# Error command")
-			expect(result).toContain("</command>")
+			expect(result.slashCommandHelp).toContain('<command name="error-command">')
+			expect(result.slashCommandHelp).toContain("# Error command")
+			expect(result.slashCommandHelp).toContain("</command>")
 		})
 
 		it("should handle command names with hyphens and underscores at start", async () => {
@@ -162,8 +160,8 @@ describe("Command Mentions", () => {
 			const result = await callParseMentions(input)
 
 			expect(mockGetCommand).toHaveBeenCalledWith("/test/cwd", "setup-dev")
-			expect(result).toContain('<command name="setup-dev">')
-			expect(result).toContain("# Dev setup")
+			expect(result.slashCommandHelp).toContain('<command name="setup-dev">')
+			expect(result.slashCommandHelp).toContain("# Dev setup")
 		})
 
 		it("should preserve command content formatting", async () => {
@@ -192,13 +190,13 @@ npm install
 			const input = "/complex command"
 			const result = await callParseMentions(input)
 
-			expect(result).toContain('<command name="complex">')
-			expect(result).toContain("# Complex Command")
-			expect(result).toContain("```bash")
-			expect(result).toContain("npm install")
-			expect(result).toContain("- Check file1.js")
-			expect(result).toContain("> **Note**: This is important!")
-			expect(result).toContain("</command>")
+			expect(result.slashCommandHelp).toContain('<command name="complex">')
+			expect(result.slashCommandHelp).toContain("# Complex Command")
+			expect(result.slashCommandHelp).toContain("```bash")
+			expect(result.slashCommandHelp).toContain("npm install")
+			expect(result.slashCommandHelp).toContain("- Check file1.js")
+			expect(result.slashCommandHelp).toContain("> **Note**: This is important!")
+			expect(result.slashCommandHelp).toContain("</command>")
 		})
 
 		it("should handle empty command content", async () => {
@@ -212,8 +210,8 @@ npm install
 			const input = "/empty command"
 			const result = await callParseMentions(input)
 
-			expect(result).toContain('<command name="empty">')
-			expect(result).toContain("</command>")
+			expect(result.slashCommandHelp).toContain('<command name="empty">')
+			expect(result.slashCommandHelp).toContain("</command>")
 			// Should still include the command tags even with empty content
 		})
 	})
@@ -295,7 +293,7 @@ npm install
 			const input = "/setup the project"
 			const result = await callParseMentions(input)
 
-			expect(result).toContain("Command 'setup' (see below for command content)")
+			expect(result.text).toContain("Command 'setup' (see below for command content)")
 		})
 
 		it("should leave non-existent command mentions unchanged", async () => {
@@ -304,7 +302,7 @@ npm install
 			const input = "/nonexistent the project"
 			const result = await callParseMentions(input)
 
-			expect(result).toBe("/nonexistent the project")
+			expect(result.text).toBe("/nonexistent the project")
 		})
 
 		it("should process multiple commands in message", async () => {
@@ -325,8 +323,8 @@ npm install
 			const input = "/setup the project\nThen /deploy later"
 			const result = await callParseMentions(input)
 
-			expect(result).toContain("Command 'setup' (see below for command content)")
-			expect(result).toContain("Command 'deploy' (see below for command content)")
+			expect(result.text).toContain("Command 'setup' (see below for command content)")
+			expect(result.text).toContain("Command 'deploy' (see below for command content)")
 		})
 
 		it("should match commands anywhere with proper word boundaries", async () => {
@@ -340,22 +338,22 @@ npm install
 			// At the beginning - should match
 			let input = "/build the project"
 			let result = await callParseMentions(input)
-			expect(result).toContain("Command 'build'")
+			expect(result.text).toContain("Command 'build'")
 
 			// After space - should match
 			input = "Please /build and test"
 			result = await callParseMentions(input)
-			expect(result).toContain("Command 'build'")
+			expect(result.text).toContain("Command 'build'")
 
 			// At the end - should match
 			input = "Run the /build"
 			result = await callParseMentions(input)
-			expect(result).toContain("Command 'build'")
+			expect(result.text).toContain("Command 'build'")
 
 			// At start of new line - should match
 			input = "Some text\n/build the project"
 			result = await callParseMentions(input)
-			expect(result).toContain("Command 'build'")
+			expect(result.text).toContain("Command 'build'")
 		})
 	})
 })