MNT: address second round of PR review comments

- Add HTTP 413 to /upload route OpenAPI responses schema
- Move grain_fields construction inside SOLID|HYBRID match branch
  to avoid AttributeError on LIQUID/GENERIC motors
- Add test for oversized .rpy upload returning HTTP 413

Made-with: Cursor

Author: GabrielBarberini

src/routes/flight.py

@@ -190,6 +190,7 @@ async def get_rocketpy_flight_rpy(
     status_code=201,
     responses={
         201: {"description": "Flight imported from .rpy file"},
+        413: {"description": "Uploaded .rpy file exceeds size limit"},
         422: {"description": "Invalid .rpy file"},
     },
 )

src/services/flight.py

@@ -176,25 +176,24 @@ def _extract_motor(motor) -> MotorModel:
             ),
         }
 
-        grain_fields = {
-            "grain_number": motor.grain_number,
-            "grain_density": motor.grain_density,
-            "grain_outer_radius": motor.grain_outer_radius,
-            "grain_initial_inner_radius": (motor.grain_initial_inner_radius),
-            "grain_initial_height": motor.grain_initial_height,
-            "grain_separation": motor.grain_separation,
-            "grains_center_of_mass_position": (
-                motor.grains_center_of_mass_position
-            ),
-            "throat_radius": motor.throat_radius,
-        }
-
         match kind:
-            case MotorKinds.SOLID:
-                data |= grain_fields
-            case MotorKinds.HYBRID:
-                data |= grain_fields
-                data["tanks"] = FlightService._extract_tanks(motor)
+            case MotorKinds.SOLID | MotorKinds.HYBRID:
+                data |= {
+                    "grain_number": motor.grain_number,
+                    "grain_density": motor.grain_density,
+                    "grain_outer_radius": motor.grain_outer_radius,
+                    "grain_initial_inner_radius": (
+                        motor.grain_initial_inner_radius
+                    ),
+                    "grain_initial_height": (motor.grain_initial_height),
+                    "grain_separation": motor.grain_separation,
+                    "grains_center_of_mass_position": (
+                        motor.grains_center_of_mass_position
+                    ),
+                    "throat_radius": motor.throat_radius,
+                }
+                if kind is MotorKinds.HYBRID:
+                    data["tanks"] = FlightService._extract_tanks(motor)
             case MotorKinds.LIQUID:
                 data["tanks"] = FlightService._extract_tanks(motor)
             case MotorKinds.GENERIC:

tests/unit/test_routes/test_flights_route.py

@@ -601,6 +601,21 @@ def test_import_flight_from_rpy_server_error(
     assert response.status_code == 500
 
 
+def test_import_flight_from_rpy_payload_too_large(
+    mock_controller_instance,
+):
+    oversized = b"a" * (10 * 1024 * 1024 + 1)
+    response = client.post(
+        '/flights/upload',
+        files={'file': ('large.rpy', oversized, 'application/json')},
+    )
+    assert response.status_code == 413
+    assert response.json() == {
+        'detail': 'Uploaded .rpy file exceeds 10 MB limit.'
+    }
+    mock_controller_instance.import_flight_from_rpy.assert_not_called()
+
+
 # --- Issue #57: Export flight as notebook ---