Skip to content

Commit 9ff985a

Browse files
committed
Comment out debug console output. Uncomment for tests.
Renamed query return object fields using camelCase and more closely matching TransactionResult properties.
1 parent cb7b290 commit 9ff985a

File tree

2 files changed

+17
-17
lines changed

2 files changed

+17
-17
lines changed

client/src/sdk/LocalConnection.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,7 @@ class LocalConnection extends Connection {
224224
* @param {string} [params.path=''] -
225225
* @param {string[]} [params.inputs=[]] -
226226
* @param {string[]} [params.persist=[]] - Name(s) of relation(s) to persist.
227-
* @return {Object} - {txn_output, query_output, problems}
227+
* @return {Object} - {txnOutput, resultOutput, problems}
228228
*/
229229
query(params) {
230230
return new Promise((resolve, reject) => {
@@ -256,14 +256,14 @@ class LocalConnection extends Connection {
256256
// TransactionResult to look at the top-level output. The expected
257257
// values appear correct in the response, but we run into AnyType
258258
// types in the TransactionResult top-level output.
259-
console.dir(JSON.parse(res.response.text));
260-
console.dir(res.transactionResult);
259+
//console.dir(JSON.parse(res.response.text));
260+
//console.dir(res.transactionResult);
261261

262262
const tr = res.transactionResult;
263-
const txn_output = tr.output;
264-
const query_output = tr.actions[0].result.output;
263+
const txnOutput = tr.output;
264+
const resultOutput = tr.actions[0].result.output;
265265
const problems = tr.problems;
266-
resolve({txn_output, query_output, problems});
266+
resolve({txnOutput, resultOutput, problems});
267267
})
268268
.catch(error => reject(error))
269269
})

client/test/sdk/LocalConnection.test.js

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -158,31 +158,31 @@ describe('LocalConnection', () => {
158158
out: 'bar',
159159
query: 'def bar = 2',
160160
}).then(res => {
161-
assert(res.query_output[0].columns[0][0] === 2);
161+
assert(res.resultOutput[0].columns[0][0] === 2);
162162
});
163163
})
164164
it(`def p = {(1,); (2,); (3,)}`, () => {
165165
return defaultConnection.query({
166166
out: 'p',
167167
query: 'def p = {(1,); (2,); (3,)}',
168168
}).then(res => {
169-
assert(setsEqual(new Set(res.query_output[0].columns[0]), new Set([1,2,3])));
169+
assert(setsEqual(new Set(res.resultOutput[0].columns[0]), new Set([1,2,3])));
170170
});
171171
})
172172
it(`def p = {(1.1,); (2.2,); (3.4,)}`, () => {
173173
return defaultConnection.query({
174174
out: 'p',
175175
query: 'def p = {(1.1,); (2.2,); (3.4,)}',
176176
}).then(res => {
177-
assert(setsEqual(new Set(res.query_output[0].columns[0]), new Set([1.1,2.2,3.4])));
177+
assert(setsEqual(new Set(res.resultOutput[0].columns[0]), new Set([1.1,2.2,3.4])));
178178
});
179179
})
180180
it(`def p = {(parse_decimal[64, 2, \"1.1\"],); (parse_decimal[64, 2, \"2.2\"],); (parse_decimal[64, 2, \"3.4\"],)}`, () => {
181181
return defaultConnection.query({
182182
out: 'p',
183183
query: 'def p = {(parse_decimal[64, 2, \"1.1\"],); (parse_decimal[64, 2, \"2.2\"],); (parse_decimal[64, 2, \"3.4\"],)}',
184184
}).then(res => {
185-
assert(setsEqual(new Set(res.query_output[0].columns[0]), new Set([1.1,2.2,3.4])));
185+
assert(setsEqual(new Set(res.resultOutput[0].columns[0]), new Set([1.1,2.2,3.4])));
186186
});
187187
})
188188
it(`def p = {(1, 5); (2, 7); (3, 9)}`, () => {
@@ -192,7 +192,7 @@ describe('LocalConnection', () => {
192192
}).then(res => {
193193
let success = [];
194194
success = [[1,2,3],[5,7,9]].map((X,i) => {
195-
return setsEqual(new Set(X), new Set(res.query_output[0].columns[i]));
195+
return setsEqual(new Set(X), new Set(res.resultOutput[0].columns[i]));
196196
});
197197
assert.deepStrictEqual(success, [true, true]);
198198
});
@@ -204,28 +204,28 @@ describe('LocalConnection', () => {
204204
return defaultConnection.query({
205205
query: 'def output = 2',
206206
}).then(res => {
207-
assert(res.txn_output[0].columns[0][0] === 2);
207+
assert(res.txnOutput[0].columns[0][0] === 2);
208208
});
209209
})
210210
it(`def output = {(1,); (2,); (3,)}`, () => {
211211
return defaultConnection.query({
212212
query: 'def output = {(1,); (2,); (3,)}',
213213
}).then(res => {
214-
assert(setsEqual(new Set(res.txn_output[0].columns[0]), new Set([1,2,3])));
214+
assert(setsEqual(new Set(res.txnOutput[0].columns[0]), new Set([1,2,3])));
215215
});
216216
})
217217
it(`def output = {(1.1,); (2.2,); (3.4,)}`, () => {
218218
return defaultConnection.query({
219219
query: 'def output = {(1.1,); (2.2,); (3.4,)}',
220220
}).then(res => {
221-
assert(setsEqual(new Set(res.txn_output[0].columns[0]), new Set([1.1,2.2,3.4])));
221+
assert(setsEqual(new Set(res.txnOutput[0].columns[0]), new Set([1.1,2.2,3.4])));
222222
});
223223
})
224224
it(`def output = {(parse_decimal[64, 2, \"1.1\"],); (parse_decimal[64, 2, \"2.2\"],); (parse_decimal[64, 2, \"3.4\"],)}`, () => {
225225
return defaultConnection.query({
226226
query: 'def output = {(parse_decimal[64, 2, \"1.1\"],); (parse_decimal[64, 2, \"2.2\"],); (parse_decimal[64, 2, \"3.4\"],)}',
227227
}).then(res => {
228-
assert(setsEqual(new Set(res.txn_output[0].columns[0]), new Set([1.1,2.2,3.4])));
228+
assert(setsEqual(new Set(res.txnOutput[0].columns[0]), new Set([1.1,2.2,3.4])));
229229
});
230230
})
231231
it(`def output = {(1, 5); (2, 7); (3, 9)}`, () => {
@@ -234,7 +234,7 @@ describe('LocalConnection', () => {
234234
}).then(res => {
235235
let success = [];
236236
success = [[1,2,3],[5,7,9]].map((X,i) => {
237-
return setsEqual(new Set(X), new Set(res.txn_output[0].columns[i]));
237+
return setsEqual(new Set(X), new Set(res.txnOutput[0].columns[i]));
238238
});
239239
assert.deepStrictEqual(success, [true, true]);
240240
});
@@ -269,7 +269,7 @@ describe('LocalConnection', () => {
269269
persist: ['p'],
270270
query: 'def p = {(1,); (2,); (3,)}'
271271
}).then(res => {
272-
assert(setsEqual(new Set(res.query_output[0].columns[0]), new Set([1,2,3])));
272+
assert(setsEqual(new Set(res.resultOutput[0].columns[0]), new Set([1,2,3])));
273273
});
274274
})
275275
it(`cardinality of relation p is equal to 3`, () => {

0 commit comments

Comments
 (0)