From 27f2c5755db1db7ea0d05918b333874776450df2 Mon Sep 17 00:00:00 2001 From: Felix Kleinschmidt Date: Tue, 4 Mar 2025 10:19:50 -0200 Subject: [PATCH 1/2] add port support back --- lib/quickpay/api/client.rb | 1 + test/client.rb | 16 ++++------------ 2 files changed, 5 insertions(+), 12 deletions(-) diff --git a/lib/quickpay/api/client.rb b/lib/quickpay/api/client.rb index 5495309..ae95ddc 100644 --- a/lib/quickpay/api/client.rb +++ b/lib/quickpay/api/client.rb @@ -67,6 +67,7 @@ def initialize(username: nil, password: nil, base_uri: "https://api.quickpay.net net_req.body = req.body res = Net::HTTP.start( uri.hostname, + uri.port, use_ssl: uri.scheme == HTTPS, open_timeout: @connect_timeout, read_timeout: @read_timeout, diff --git a/test/client.rb b/test/client.rb index a932fd8..4decd7f 100644 --- a/test/client.rb +++ b/test/client.rb @@ -18,22 +18,14 @@ stub_request(:any, //).to_return(body: "Unknown Stub", status: 500) end - it "set default headers" do - stub_request(:get, %r{/ping}).to_return { |request| { headers: request.headers, status: 200 } } + it "does not smoke" do + stub_request(:get, "http://localhost:4242/ping").to_return { |request| { headers: request.headers, status: 200 } } - client = QuickPay::API::Client.new + client = QuickPay::API::Client.new(password: "secret", base_uri: "http://localhost:4242") _, _, headers = *client.get("/ping") _(headers["accept-version"]).must_equal "v10" _(headers["user-agent"]).must_equal "quickpay-ruby-client, v#{QuickPay::API::VERSION}" - end - - it "handles authentication" do - stub_request(:get, %r{/ping}).to_return { |request| { headers: request.headers, status: 200 } } - - client = QuickPay::API::Client.new(password: "secret") - _, _, headers = *client.get("/ping") - _(headers["authorization"]).must_equal "Basic OnNlY3JldA==" end @@ -184,7 +176,7 @@ _(e.request.body).must_equal "foo=bar&baz=qux" _(e.request.headers["Accept-Version"]).must_equal "v10" _(e.request.headers["User-Agent"]).must_equal "quickpay-ruby-client, v#{QuickPay::API::VERSION}" - _(e.request.query).must_equal(nil) + _(e.request.query).must_be_nil e = assert_raises QuickPay::API::Error do stub_request(:post, %r{/upload}).to_return(status: 409, body: "Conflict", headers: { "Foo" => "bar" }) From 8a12a21d56a0de8512e572f7d284b21476763136 Mon Sep 17 00:00:00 2001 From: Felix Kleinschmidt Date: Tue, 4 Mar 2025 10:20:37 -0200 Subject: [PATCH 2/2] bump version to 4.0.1 --- lib/quickpay/api/version.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/quickpay/api/version.rb b/lib/quickpay/api/version.rb index 465a761..b970388 100644 --- a/lib/quickpay/api/version.rb +++ b/lib/quickpay/api/version.rb @@ -1,5 +1,5 @@ module QuickPay module API - VERSION = "4.0.0".freeze + VERSION = "4.0.1".freeze end end