Only use the scalar method for AMDGPU

Author: Katharine Hyatt

ext/MatrixAlgebraKitAMDGPUExt/MatrixAlgebraKitAMDGPUExt.jl

@@ -154,4 +154,15 @@ function MatrixAlgebraKit._avgdiff!(A::StridedROCMatrix, B::StridedROCMatrix)
     return A, B
 end
 
+function MatrixAlgebraKit.truncate(::typeof(MatrixAlgebraKit.left_null!), US::Tuple{TU, TS}, strategy::MatrixAlgebraKit.TruncationStrategy) where {TU <: ROCArray, TS}
+    # TODO: avoid allocation?
+    U, S = US
+    extended_S = vcat(diagview(S), zeros(eltype(S), max(0, size(S, 1) - size(S, 2))))
+    ind = MatrixAlgebraKit.findtruncated(extended_S, strategy)
+    trunc_cols = collect(1:size(U, 2))[ind]
+    Utrunc = similar(U, (size(U, 1), length(trunc_cols)))
+    Utrunc .= U[:, trunc_cols]
+    return Utrunc, ind
+end
+
 end

src/implementations/truncation.jl

@@ -17,10 +17,7 @@ function truncate(::typeof(left_null!), (U, S), strategy::TruncationStrategy)
     # TODO: avoid allocation?
     extended_S = vcat(diagview(S), zeros(eltype(S), max(0, size(S, 1) - size(S, 2))))
     ind = findtruncated(extended_S, strategy)
-    trunc_cols = collect(1:size(U, 2))[ind]
-    Utrunc = similar(U, (size(U, 1), length(trunc_cols)))
-    Utrunc .= U[:, trunc_cols]
-    return Utrunc, ind
+    return U[:, ind], ind
 end
 function truncate(::typeof(right_null!), (S, Vᴴ), strategy::TruncationStrategy)
     # TODO: avoid allocation?