Skip to content

Commit 284b8cc

Browse files
Juthokshyatt
authored andcommitted
fix and enable tests
1 parent 8587bed commit 284b8cc

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

ext/MatrixAlgebraKitGenericLinearAlgebraExt.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
module MatrixAlgebraKitGenericLinearAlgebraExt
22

33
using MatrixAlgebraKit
4-
using MatrixAlgebraKit: sign_safe, check_input, diagview, gaugefix!, default_fixgauge
4+
using MatrixAlgebraKit: sign_safe, check_input, diagview, gaugefix!, one!, default_fixgauge
55
using GenericLinearAlgebra: svd!, svdvals!, eigen!, eigvals!, Hermitian, qr!
66
using LinearAlgebra: I, Diagonal, lmul!
77

test/lq.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,9 +51,9 @@ for T in (BLASFloats..., GenericFloats...), n in (37, m, 63)
5151
)
5252
TestSuite.test_lq_algs(T, (m, n), LAPACK_LQ_ALGS)
5353
elseif T GenericFloats
54-
TestSuite.test_lq(T, (m, n); test_null = false, test_pivoted = false, test_blocksize = false)
54+
TestSuite.test_lq(T, (m, n); test_null = true, test_pivoted = false, test_blocksize = false)
5555
GLA_LQ_ALGS = (LQViaTransposedQR(GLA_HouseholderQR()),)
56-
TestSuite.test_lq_algs(T, (m, n), GLA_LQ_ALGS; test_null = false)
56+
TestSuite.test_lq_algs(T, (m, n), GLA_LQ_ALGS; test_null = true)
5757
end
5858
if m == n
5959
AT = Diagonal{T, Vector{T}}

test/qr.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ for T in (BLASFloats..., GenericFloats...), n in (37, m, 63)
5050
)
5151
TestSuite.test_qr_algs(T, (m, n), LAPACK_QR_ALGS)
5252
elseif T GenericFloats
53-
TestSuite.test_qr(T, (m, n); test_null = false, test_pivoted = false, test_blocksize = false)
53+
TestSuite.test_qr(T, (m, n); test_null = true, test_pivoted = false, test_blocksize = false)
5454
GLA_QR_ALGS = (GLA_HouseholderQR(),)
5555
TestSuite.test_qr_algs(T, (m, n), GLA_QR_ALGS; test_null = false)
5656
end

0 commit comments

Comments
 (0)