Skip to content

Commit 42667ac

Browse files
committed
Some additional Counter tests now work on Py2.6
1 parent ec43278 commit 42667ac

File tree

3 files changed

+12
-5
lines changed

3 files changed

+12
-5
lines changed

src/future/tests/base.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
import functools
1010
from textwrap import dedent
1111

12-
from future.utils import bind_method, PY26, PY3, PY2
12+
from future.utils import bind_method, PY26, PY3, PY2, PY27
1313
from future.moves.subprocess import check_output, STDOUT, CalledProcessError
1414

1515
if PY26:
@@ -382,6 +382,12 @@ def expectedFailurePY26(func):
382382
return unittest.expectedFailure(func)
383383

384384

385+
def expectedFailurePY27(func):
386+
if not PY27:
387+
return func
388+
return unittest.expectedFailure(func)
389+
390+
385391
def expectedFailurePY2(func):
386392
if not PY2:
387393
return func

src/future/utils/__init__.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@
8080
PY3 = sys.version_info[0] == 3
8181
PY2 = sys.version_info[0] == 2
8282
PY26 = sys.version_info[0:2] == (2, 6)
83+
PY27 = sys.version_info[0:2] == (2, 7)
8384
PYPY = hasattr(sys, 'pypy_translation_info')
8485

8586

tests/test_future/test_backports.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
ChainMap,
2020
_count_elements)
2121
from future.utils import PY26
22-
from future.tests.base import unittest, skip26, expectedFailurePY2
22+
from future.tests.base import unittest, skip26, expectedFailurePY27
2323

2424

2525
class CountTest(unittest.TestCase):
@@ -333,7 +333,7 @@ def test_multiset_operations(self):
333333
set_result = setop(set(p.elements()), set(q.elements()))
334334
self.assertEqual(counter_result, dict.fromkeys(set_result, 1))
335335

336-
@expectedFailurePY2
336+
@expectedFailurePY27
337337
def test_inplace_operations(self):
338338
elements = 'abcd'
339339
for i in range(1000):
@@ -366,7 +366,7 @@ def test_subtract(self):
366366
c.subtract('aaaabbcce')
367367
self.assertEqual(c, Counter(a=-1, b=0, c=-1, d=1, e=-1))
368368

369-
@expectedFailurePY2
369+
@expectedFailurePY27
370370
def test_unary(self):
371371
c = Counter(a=-5, b=0, c=5, d=10, e=15,g=40)
372372
self.assertEqual(dict(+c), dict(c=5, d=10, e=15, g=40))
@@ -630,7 +630,7 @@ def test_reinsert(self):
630630
od['a'] = 1
631631
self.assertEqual(list(od.items()), [('b', 2), ('a', 1)])
632632

633-
@expectedFailurePY2
633+
@expectedFailurePY27
634634
def test_move_to_end(self):
635635
od = OrderedDict.fromkeys('abcde')
636636
self.assertEqual(list(od), list('abcde'))

0 commit comments

Comments
 (0)