Feature/pandas coords#719
Closed
RobbieKiwi wants to merge 5 commits into
Closed
Conversation
added 3 commits
May 21, 2026 19:13
Collaborator
|
@RobbieKiwi many ci fails. We might only fix this in #717 |
added 2 commits
May 21, 2026 20:28
Collaborator
|
@RobbieKiwi Thanks for the PR. I would like to rewrite some of it to be more efficient: def _sanitize_pandas(arr: pd.Series | pd.DataFrame) -> DataArray | None:
names = list(arr.index.names)
if isinstance(arr, pd.DataFrame):
names += list(arr.columns.names)
if any(n is None for n in names):
return None
if isinstance(arr, pd.DataFrame):
arr = arr.stack(list(range(arr.columns.nlevels)), future_stack=True)
return arr.to_xarray()Also, we need to take care that the dim order stays deterministic (see #719). |
4 tasks
Collaborator
|
@RobbieKiwi Due to the close coupling with #710 i decided thats its easiest to combine both into a single PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #709
Changes proposed in this Pull Request
Fix the bug with pandas coords not being broadcast
Checklist
doc.doc/release_notes.rstof the upcoming release is included.