Use correct Mocha TDD functions

The `before` and `after` etc. are for BDD (e.g. `describe` and `it`),
but we're using TDD (e.g. `suite` and `test`). I think they're just
aliases of each other, but let's be correct.

Author: andyleejordan

test/core/paths.test.ts

@@ -5,11 +5,11 @@ import * as assert from "assert";
 import * as fs from "fs";
 import * as path from "path";
 import * as vscode from "vscode";
-import { before } from "mocha";
+import { suiteSetup } from "mocha";
 import utils = require("../utils");
 
 suite("Path assumptions", () => {
-    before(async () => { await utils.ensureExtensionIsActivated(); });
+    suiteSetup(utils.ensureExtensionIsActivated);
 
     test("The examples folder can be opened (and exists)", async () => {
         assert(await vscode.commands.executeCommand("PowerShell.OpenExamplesFolder"));

test/features/ExternalApi.test.ts

@@ -2,13 +2,13 @@
 // Licensed under the MIT License.
 
 import * as assert from "assert";
-import { before, beforeEach, afterEach } from "mocha";
+import { suiteSetup, setup, teardown } from "mocha";
 import utils = require("../utils");
 import { IExternalPowerShellDetails, IPowerShellExtensionClient } from "../../src/features/ExternalApi";
 
 suite("ExternalApi feature - Registration API", () => {
     let powerShellExtensionClient: IPowerShellExtensionClient;
-    before(async () => {
+    suiteSetup(async () => {
         const powershellExtension = await utils.ensureExtensionIsActivated();
         powerShellExtensionClient = powershellExtension!.exports as IPowerShellExtensionClient;
     });
@@ -65,16 +65,16 @@ suite("ExternalApi feature - Other APIs", () => {
     let sessionId: string;
     let powerShellExtensionClient: IPowerShellExtensionClient;
 
-    before(async () => {
+    suiteSetup(async () => {
         const powershellExtension = await utils.ensureExtensionIsActivated();
         powerShellExtensionClient = powershellExtension!.exports as IPowerShellExtensionClient;
     });
 
-    beforeEach(() => {
+    setup(() => {
         sessionId = powerShellExtensionClient.registerExternalExtension(utils.extensionId);
     });
 
-    afterEach(() => {
+    teardown(() => {
         powerShellExtensionClient.unregisterExternalExtension(sessionId);
     });
 

test/features/ISECompatibility.test.ts

@@ -3,12 +3,12 @@
 
 import * as assert from "assert";
 import * as vscode from "vscode";
-import { before } from "mocha";
+import { suiteSetup } from "mocha";
 import { ISECompatibilityFeature } from "../../src/features/ISECompatibility";
 import utils = require("../utils");
 
 suite("ISECompatibility feature", () => {
-    before(async () => { await utils.ensureExtensionIsActivated(); } );
+    suiteSetup(utils.ensureExtensionIsActivated);
 
     test("It sets ISE Settings", async () => {
         await vscode.commands.executeCommand("PowerShell.EnableISEMode");

test/features/RunCode.test.ts

@@ -4,7 +4,7 @@
 import * as assert from "assert";
 import * as fs from "fs";
 import * as path from "path";
-import { before } from "mocha";
+import { suiteSetup } from "mocha";
 import rewire = require("rewire");
 import vscode = require("vscode");
 import utils = require("../utils");
@@ -19,7 +19,7 @@ enum LaunchType {
 }
 
 suite("RunCode tests", () => {
-    before(async () => { await utils.ensureExtensionIsActivated(); } );
+    suiteSetup(utils.ensureExtensionIsActivated);
 
     test("Can create the launch config", () => {
         const commandToRun: string = "Invoke-Build";