Make CheckboxQuickPick.show a static method

Author: Kapil Borle

src/checkboxQuickPick.ts

@@ -11,83 +11,76 @@ export class CheckboxQuickPickItem {
 }
 
 export class CheckboxQuickPick {
-    private options: CheckboxQuickPickItem[];
-    private readonly confirm: string;
-    private readonly checkboxOn: string;
-    private readonly checkboxOff: string;
-    private readonly confirmPlaceHolder: string;
+    private static readonly confirm: string = "$(check)";
+    private static readonly checkboxOn: string = "[ x ]";
+    private static readonly checkboxOff: string = "[   ]";
+    private static readonly confirmPlaceHolder: string = "Select 'Confirm' to confirm change; Press 'esc' key to cancel changes";
 
-    constructor(options: CheckboxQuickPickItem[]) {
-        this.options = options;
-        this.confirm = "$(check)";
-        this.checkboxOn = "[ x ]";
-        this.checkboxOff = "[   ]";
-        this.confirmPlaceHolder = "Select 'Confirm' to confirm change; Press 'esc' key to cancel changes";
+    public static show(
+        checkboxQuickPickItems: CheckboxQuickPickItem[],
+        callback: (items: CheckboxQuickPickItem[]) => void): void {
+        CheckboxQuickPick.showInner(checkboxQuickPickItems.slice(), callback);
     }
 
-    public show(callback: (options: CheckboxQuickPickItem[]) => void): void {
-        let tempOptions: CheckboxQuickPickItem[] = this.options.slice();
-        this.showInner(tempOptions, callback);
-    }
-
-    private showInner(
+    private static showInner(
         tempOptions: CheckboxQuickPickItem[],
         callback: (options: CheckboxQuickPickItem[]) => void): void {
             vscode.window.showQuickPick(
-                this.getQuickPickItems(tempOptions),
-                { ignoreFocusOut: true, placeHolder: this.confirmPlaceHolder }).then((selection) => {
+                CheckboxQuickPick.getQuickPickItems(tempOptions),
+                { ignoreFocusOut: true, placeHolder: CheckboxQuickPick.confirmPlaceHolder }).then((selection) => {
                     if (!selection) {
                         return;
                     }
 
-                    if (selection.label == this.confirm) {
+                    if (selection.label === CheckboxQuickPick.confirm) {
                         callback(tempOptions);
-                        this.options = tempOptions;
                         return;
                     }
 
-                    let index: number = this.getRuleIndex(tempOptions, selection.description);
-                    this.toggleOption(tempOptions[index]);
-                    this.showInner(tempOptions, callback);
+                    let index: number = CheckboxQuickPick.getRuleIndex(tempOptions, selection.description);
+                    CheckboxQuickPick.toggleOption(tempOptions[index]);
+                    CheckboxQuickPick.showInner(tempOptions, callback);
                 });
     }
 
-    private getRuleIndex(options: CheckboxQuickPickItem[], optionLabel: string): number {
+    private static getRuleIndex(options: CheckboxQuickPickItem[], optionLabel: string): number {
         return options.findIndex(opt => opt.name == optionLabel);
     }
 
-    private getQuickPickItems(tempOptions: CheckboxQuickPickItem[]): QuickPickItem[] {
+    private static getQuickPickItems(tempOptions: CheckboxQuickPickItem[]): QuickPickItem[] {
         let quickPickItems: QuickPickItem[] = [];
-        quickPickItems.push({ label: this.confirm, description: "Confirm" });
+        quickPickItems.push({ label: CheckboxQuickPick.confirm, description: "Confirm" });
         tempOptions.forEach(option =>
             quickPickItems.push({
-                label: this.convertToCheckBox(option.isSelected), description: option.name
+                label: CheckboxQuickPick.convertToCheckBox(option.isSelected), description: option.name
             }));
         return quickPickItems;
     }
 
-    private convertToState(checkBox: string): boolean {
-        return checkBox == this.checkboxOn;
+    private static convertToState(checkBox: string): boolean {
+        return checkBox === CheckboxQuickPick.checkboxOn;
     }
 
-    private toggleState(state: boolean): boolean {
+    private static toggleState(state: boolean): boolean {
         return !state;
     }
 
-    private toggleOption(option: CheckboxQuickPickItem): void {
-        option.isSelected = this.toggleState(option.isSelected);
+    private static toggleOption(option: CheckboxQuickPickItem): void {
+        option.isSelected = CheckboxQuickPick.toggleState(option.isSelected);
     }
 
-    private toggleCheckBox(checkBox: string): string {
-        return this.convertToCheckBox(this.toggleState(this.convertToState(checkBox)));
+    private static toggleCheckBox(checkBox: string): string {
+        return CheckboxQuickPick.convertToCheckBox(
+            CheckboxQuickPick.toggleState(
+                CheckboxQuickPick.convertToState(checkBox)));
     }
 
-    private convertToCheckBox(state: boolean): string {
+    private static convertToCheckBox(state: boolean): string {
         if (state) {
-            return this.checkboxOn;
+            return CheckboxQuickPick.checkboxOn;
         }
         else {
-            return this.checkboxOff;
+            return CheckboxQuickPick.checkboxOff;
         }
     }
 }

src/features/SelectPSSARules.ts

@@ -41,7 +41,7 @@ export class SelectPSSARulesFeature implements IFeature {
                 let options: CheckboxQuickPickItem[] = returnedRules.map(function (rule: IRuleInfo): CheckboxQuickPickItem {
                     return { name: rule.name, isSelected: rule.isEnabled };
                 });
-                (new CheckboxQuickPick(options)).show((updatedOptions) => {
+                CheckboxQuickPick.show(options, (updatedOptions) => {
                     this.languageClient.sendRequest(
                         SetPSSARulesRequest.type,
                         updatedOptions.map(function (option: CheckboxQuickPickItem): IRuleInfo {