review notes

Author: charlesvien

apps/code/src/renderer/features/onboarding/hooks/useProjectsWithIntegrations.ts

@@ -13,7 +13,7 @@ export interface ProjectWithIntegrations {
 }
 
 export function useProjectsWithIntegrations() {
-  const { projects, isLoading: projectsLoading } = useProjects();
+  const { projects } = useProjects();
   const client = useAuthStore((s) => s.client);
 
   // Fetch integrations for each project in parallel
@@ -29,8 +29,7 @@ export function useProjectsWithIntegrations() {
     })),
   });
 
-  const isLoading =
-    projectsLoading || integrationQueries.some((q) => q.isLoading);
+  const isLoading = integrationQueries.some((q) => q.isLoading);
   const isFetching = integrationQueries.some((q) => q.isFetching);
 
   const projectsWithIntegrations: ProjectWithIntegrations[] = useMemo(() => {

apps/code/src/renderer/features/projects/hooks/useProjects.tsx

@@ -68,6 +68,5 @@ export function useProjects() {
     groupedProjects,
     currentProject,
     currentProjectId,
-    isLoading: false,
   };
 }

apps/code/src/renderer/features/sidebar/components/ProjectSwitcher.tsx

@@ -56,8 +56,7 @@ export function ProjectSwitcher() {
   const cloudRegion = useAuthStore((s) => s.cloudRegion);
   const selectProject = useAuthStore((s) => s.selectProject);
   const logout = useAuthStore((s) => s.logout);
-  const { groupedProjects, currentProject, currentProjectId, isLoading } =
-    useProjects();
+  const { groupedProjects, currentProject, currentProjectId } = useProjects();
   const { data: currentUser } = useMeQuery();
 
   const handleProjectSelect = (projectId: number) => {
@@ -132,7 +131,7 @@ export function ProjectSwitcher() {
               gap="1"
               style={{ minWidth: 0, flex: 1, maxWidth: "calc(100% - 24px)" }}
             >
-              {isLoading ? (
+              {!currentProject && !currentUser ? (
                 <>
                   <Box className="h-4 w-24 animate-pulse rounded bg-gray-6" />
                   <Box className="h-3.5 w-32 animate-pulse rounded bg-gray-5" />