Commit bc1ab8e
authored
feat(code): disable editing in diff viewer (#1395)
## Problem
files can be "edited" in the diff viewer (b side or unified view). the changes are not persisted, but users shouldn't be able to manually edit these in the first place
<!-- Who is this for and what problem does it solve? -->
<!-- Closes #ISSUE_ID -->
## [phc-editing-bug.mp4 <span class="graphite__hidden">(uploaded via Graphite)</span> <img class="graphite__hidden" src="https://app.graphite.com/user-attachments/thumbnails/2eb83dcd-d847-4fb6-bbb2-c576e84f2847.mp4" />](https://app.graphite.com/user-attachments/video/2eb83dcd-d847-4fb6-bbb2-c576e84f2847.mp4)
## Changes
updates diff viewer to disable editing, keeps 'revert' functionality working but removes ability to click/type
## notes
i think we probably _should_ allow editing, but since nothing persists right now, it's just confusing so i'm disabling it for now
<!-- What did you change and why? -->
<!-- If there are frontend changes, include screenshots. -->
## How did you test this?
manually
<!-- Describe what you tested -- manual steps, automated tests, or both. -->
<!-- If you're an agent, only list tests you actually ran. -->1 parent 67e4f9f commit bc1ab8e
File tree
2 files changed
+2
-2
lines changed- apps/code/src/renderer/features/code-editor
- components
- hooks
2 files changed
+2
-2
lines changedLines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
41 | | - | |
| 41 | + | |
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
42 | | - | |
| 42 | + | |
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
| |||
0 commit comments