Preserve dataset build failure details across Modal#1112
Merged
Conversation
anth-volk
force-pushed
the
fix/dataset-command-error-serialization
branch
from
e8646a2 to
e2a5340
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1111
Summary
DatasetCommandErrorpickle-safe so Modal can serialize Stage 1 command failures back to the orchestrator without masking the original error.latest_error.jsonis malformed or unreadable.Root Cause
DatasetCommandErrorstored a structuredDatasetCommandResult, but itsRuntimeErrorargs contained only the rendered message string. During Modal exception transport, Python pickle reconstructed the exception with that string, which madeDatasetCommandError.__init__try to read.returncodefrom a string.Validation
uv run --no-sync pytest tests/unit/test_build_dataset_commands.py tests/unit/test_pipeline_status.py tests/unit/test_pipeline.py -qruff format --check policyengine_us_data/build_datasets/commands.py policyengine_us_data/build_datasets/status.py modal_app/pipeline.py modal_app/step_manifests/status.py tests/unit/test_build_dataset_commands.py tests/unit/test_pipeline.py tests/unit/test_pipeline_status.pyruff check policyengine_us_data/build_datasets/commands.py policyengine_us_data/build_datasets/status.py modal_app/pipeline.py modal_app/step_manifests/status.py tests/unit/test_build_dataset_commands.py tests/unit/test_pipeline.py tests/unit/test_pipeline_status.pymake lint