Remove URL Error Status

Author: maxachis

tests/automated/integration/api/batch/summaries/test_happy_path.py

@@ -29,10 +29,6 @@ async def test_get_batch_summaries(api_test_helper):
                     count=4,
                     status=URLCreationEnum.NOT_RELEVANT
                 ),
-                TestURLCreationParameters(
-                    count=3,
-                    status=URLCreationEnum.ERROR
-                )
             ]
         ),
         TestBatchCreationParameters(
@@ -78,10 +74,10 @@ async def test_get_batch_summaries(api_test_helper):
     result_2 = results[1]
     assert result_2.id == batch_2_id
     counts_2 = result_2.url_counts
-    assert counts_2.total == 7
+    assert counts_2.total == 4
     assert counts_2.not_relevant == 4
-    assert counts_2.errored == 3
-    assert counts_2.pending == 3
+    assert counts_2.errored == 0
+    assert counts_2.pending == 0
     assert counts_2.submitted == 0
     assert counts_2.duplicate == 0
 

tests/automated/integration/api/metrics/batches/test_breakdown.py

@@ -49,12 +49,6 @@ async def test_get_batches_breakdown_metrics(api_test_helper):
         strategy=CollectorType.AUTO_GOOGLER,
         date_generated=today - timedelta(days=14)
     )
-    error_url_mappings: list[SimpleURLMapping] = await create_urls(
-        adb_client=adb_client,
-        status=URLStatus.ERROR,
-        count=4,
-    )
-    error_url_ids: list[int] = [url_mapping.url_id for url_mapping in error_url_mappings]
     validated_url_mappings: list[SimpleURLMapping] = await create_urls(
         adb_client=adb_client,
         count=8,
@@ -73,7 +67,7 @@ async def test_get_batches_breakdown_metrics(api_test_helper):
     await create_batch_url_links(
         adb_client=adb_client,
         batch_id=batch_id_3,
-        url_ids=error_url_ids + validated_url_ids,
+        url_ids=validated_url_ids,
     )
 
 
@@ -107,11 +101,11 @@ async def test_get_batches_breakdown_metrics(api_test_helper):
     assert dto_batch_3.batch_id == batch_id_3
     assert dto_batch_3.status == BatchStatus.READY_TO_LABEL
     assert dto_batch_3.strategy == CollectorType.AUTO_GOOGLER
-    assert dto_batch_3.count_url_total == 12
-    assert dto_batch_3.count_url_pending == 5
+    assert dto_batch_3.count_url_total == 8
+    assert dto_batch_3.count_url_pending == 1
     assert dto_batch_3.count_url_submitted == 0
     assert dto_batch_3.count_url_rejected == 3
-    assert dto_batch_3.count_url_error == 4
+    assert dto_batch_3.count_url_error == 0
     assert dto_batch_3.count_url_validated == 7
 
     dto_2 = await ath.request_validator.get_batches_breakdown_metrics(

tests/automated/integration/api/metrics/test_backlog.py

@@ -46,12 +46,6 @@ async def test_get_backlog_metrics(api_test_helper):
         url_ids=not_relevant_url_ids_2[:4],
         validation_type=URLType.NOT_RELEVANT
     )
-    error_url_mappings_2: list[SimpleURLMapping] = await ddc.create_urls(
-        status=URLStatus.ERROR,
-        count=2
-    )
-    error_url_ids_2: list[int] = [url_mapping.url_id for url_mapping in error_url_mappings_2]
-    await ddc.create_batch_url_links(url_ids=error_url_ids_2, batch_id=batch_2_id)
 
     await adb_client.populate_backlog_snapshot(
         dt=today.subtract(months=2).naive()

tests/automated/integration/api/metrics/urls/aggregated/test_core.py

@@ -47,7 +47,6 @@ async def test_get_urls_aggregated_metrics(api_test_helper):
         strategy=CollectorType.AUTO_GOOGLER,
     )
     url_mappings_2_ok: list[SimpleURLMapping] = await ddc.create_urls(batch_id=batch_2, count=4, status=URLStatus.OK)
-    url_mappings_2_error: list[SimpleURLMapping] = await ddc.create_urls(batch_id=batch_2, count=2, status=URLStatus.ERROR)
     url_mappings_2_validated: list[SimpleURLMapping] = await ddc.create_validated_urls(count=1, validation_type=URLType.DATA_SOURCE)
     url_mappings_2_not_relevant: list[SimpleURLMapping] = await ddc.create_validated_urls(count=5, validation_type=URLType.NOT_RELEVANT)
     url_ids_2_validated: list[int] = [url_mapping.url_id for url_mapping in url_mappings_2_validated]

tests/automated/integration/api/metrics/urls/breakdown/test_pending.py

@@ -64,10 +64,6 @@ async def test_get_urls_breakdown_pending_metrics(api_test_helper):
                 count=3,
                 status=URLCreationEnum.SUBMITTED
             ),
-            TestURLCreationParameters(
-                count=4,
-                status=URLCreationEnum.ERROR
-            ),
             TestURLCreationParameters(
                 count=5,
                 status=URLCreationEnum.OK,

tests/automated/integration/api/metrics/urls/breakdown/test_submitted.py

@@ -47,10 +47,6 @@ async def test_get_urls_breakdown_submitted_metrics(api_test_helper):
                 count=3,
                 status=URLCreationEnum.SUBMITTED
             ),
-            TestURLCreationParameters(
-                count=4,
-                status=URLCreationEnum.ERROR
-            ),
             TestURLCreationParameters(
                 count=5,
                 status=URLCreationEnum.VALIDATED

tests/manual/agency_identifier/test_nlp_processor.py

@@ -1,7 +1,6 @@
 import pytest
 
-from src.core.tasks.url.operators.agency_identification.subtasks.impl.nlp_location_match_.processor import \
-    NLPProcessor
+from src.core.tasks.url.operators.location_id.subtasks.impl.nlp_location_freq.processor.nlp.core import NLPProcessor
 
 SAMPLE_HTML: str = """
 <html>

tests/manual/core/lifecycle/test_auto_googler_lifecycle.py

@@ -3,9 +3,8 @@
 import dotenv
 
 from src.db.models.impl.batch.pydantic.info import BatchInfo
-from src.collectors import CollectorType
+from src.collectors.enums import CollectorType
 from src.core.enums import BatchStatus
-from test_automated.integration.core.helpers.common_test_procedures import run_collector_and_wait_for_completion
 
 
 def test_auto_googler_collector_lifecycle(test_core):