Skip to content

possible typo, checking v_max(0) > v_min(0) twice #6378

@mberntsen

Description

@mberntsen

Describe the bug

surface > src > on_nurbs > fitting_surface_pdm.cpp > InitNurbsPCABoundingBox(...) (line 501)
checks:
if (v_max (0) > v_min (0) && v_max (0) > v_min (0))
makes more sense to check both (0) and (1):
if (v_max (0) > v_min (0) && v_max (1) > v_min (1))

  • PCL Version [e.g. 1.15.1, HEAD]

(stumbled upon this while trying to understand the function.)

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions