From 371e9c0860eacb3d75c1f91625924240fdc6847f Mon Sep 17 00:00:00 2001 From: Nathan Brooks Date: Sun, 14 Dec 2025 10:51:52 -0700 Subject: [PATCH 1/5] Rolling has targeted 24.04 for some time now --- .github/workflows/ci-coverage-build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci-coverage-build.yml b/.github/workflows/ci-coverage-build.yml index 1e66466..491e1d8 100644 --- a/.github/workflows/ci-coverage-build.yml +++ b/.github/workflows/ci-coverage-build.yml @@ -10,7 +10,7 @@ on: jobs: coverage: name: coverage build - runs-on: ubuntu-22.04 + runs-on: ubuntu-24.04 strategy: fail-fast: false env: From 5d4afca0b13ff0044684f384ebcdd86fedbb57f8 Mon Sep 17 00:00:00 2001 From: Nathan Brooks Date: Sun, 14 Dec 2025 11:17:48 -0700 Subject: [PATCH 2/5] Do not use github.sha for retrieving raw github content for PR based workflows --- .github/workflows/ci-coverage-build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci-coverage-build.yml b/.github/workflows/ci-coverage-build.yml index 491e1d8..5f49283 100644 --- a/.github/workflows/ci-coverage-build.yml +++ b/.github/workflows/ci-coverage-build.yml @@ -29,7 +29,7 @@ jobs: picknik_reset_fault_controller vcs-repo-file-url: | - https://raw.githubusercontent.com/${{ github.repository }}/${{ github.sha }}/picknik_controllers-not-released.${{ env.ROS_DISTRO }}.repos?token=${{ secrets.GITHUB_TOKEN }} + https://raw.githubusercontent.com/${{ github.repository }}/${{ github.event.pull_request.head.sha }}/picknik_controllers-not-released.${{ env.ROS_DISTRO }}.repos?token=${{ secrets.GITHUB_TOKEN }} colcon-defaults: | { "build": { From 1de3aa454fdc61f12e130b4f2b474f6cc942f5c4 Mon Sep 17 00:00:00 2001 From: Nathan Brooks Date: Sun, 14 Dec 2025 11:22:25 -0700 Subject: [PATCH 3/5] Support manual workflow trigger for main --- .github/workflows/ci-coverage-build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci-coverage-build.yml b/.github/workflows/ci-coverage-build.yml index 5f49283..ae0ccf4 100644 --- a/.github/workflows/ci-coverage-build.yml +++ b/.github/workflows/ci-coverage-build.yml @@ -29,7 +29,7 @@ jobs: picknik_reset_fault_controller vcs-repo-file-url: | - https://raw.githubusercontent.com/${{ github.repository }}/${{ github.event.pull_request.head.sha }}/picknik_controllers-not-released.${{ env.ROS_DISTRO }}.repos?token=${{ secrets.GITHUB_TOKEN }} + https://raw.githubusercontent.com/${{ github.repository }}/${{ github.event.pull_request.head.sha || github.sha }}/picknik_controllers-not-released.${{ env.ROS_DISTRO }}.repos?token=${{ secrets.GITHUB_TOKEN }} colcon-defaults: | { "build": { From a3f1c1356b64157a84ac1ed19b9134d9ca32d39b Mon Sep 17 00:00:00 2001 From: Nathan Brooks Date: Sun, 14 Dec 2025 14:02:11 -0700 Subject: [PATCH 4/5] Remove no longer supported github authentication via URL appended token. I doubt we are going to get rate limited in their repository's CI. --- .github/workflows/ci-coverage-build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci-coverage-build.yml b/.github/workflows/ci-coverage-build.yml index ae0ccf4..de2999b 100644 --- a/.github/workflows/ci-coverage-build.yml +++ b/.github/workflows/ci-coverage-build.yml @@ -29,7 +29,7 @@ jobs: picknik_reset_fault_controller vcs-repo-file-url: | - https://raw.githubusercontent.com/${{ github.repository }}/${{ github.event.pull_request.head.sha || github.sha }}/picknik_controllers-not-released.${{ env.ROS_DISTRO }}.repos?token=${{ secrets.GITHUB_TOKEN }} + https://raw.githubusercontent.com/${{ github.repository }}/${{ github.event.pull_request.head.sha || github.sha }}/picknik_controllers-not-released.${{ env.ROS_DISTRO }}.repos colcon-defaults: | { "build": { From e0f6e4b654d84bb98ea4343ec9cddda804273521 Mon Sep 17 00:00:00 2001 From: Nathan Brooks Date: Sun, 14 Dec 2025 14:12:03 -0700 Subject: [PATCH 5/5] Re-reading the github.sha coverage, I think that was fine and the actual 404 issue was the deprecated appended token syntax --- .github/workflows/ci-coverage-build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci-coverage-build.yml b/.github/workflows/ci-coverage-build.yml index de2999b..24b30ba 100644 --- a/.github/workflows/ci-coverage-build.yml +++ b/.github/workflows/ci-coverage-build.yml @@ -29,7 +29,7 @@ jobs: picknik_reset_fault_controller vcs-repo-file-url: | - https://raw.githubusercontent.com/${{ github.repository }}/${{ github.event.pull_request.head.sha || github.sha }}/picknik_controllers-not-released.${{ env.ROS_DISTRO }}.repos + https://raw.githubusercontent.com/${{ github.repository }}/${{ github.sha }}/picknik_controllers-not-released.${{ env.ROS_DISTRO }}.repos colcon-defaults: | { "build": {