Completely stub all classes in god-classes (#203)

* Fully stub ForgeHooksClient

* Fully stub ClientHooks

* Reorder BasicEventHooks methods to match Forge.

This class is actually fully implemented!

* FIXUP! Fix ClientHooks checkstyle.

* Fully stub ForgeEventFactory

* Fully stub ForgeHooks

* Revamp documentation discouraging use of god-classes in other modules.

Author: kitlith

patchwork-api-base/src/main/java/net/patchworkmc/annotations/Stubbed.java

@@ -0,0 +1,33 @@
+/*
+ * Minecraft Forge, Patchwork Project
+ * Copyright (c) 2016-2020, 2019-2020
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation version 2.1
+ * of the License.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
+ */
+
+package net.patchworkmc.annotations;
+
+import java.lang.annotation.ElementType;
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+import java.lang.annotation.Target;
+
+/**
+ * Marks an element as having been manually stubbed.
+ */
+@Target({ ElementType.METHOD, ElementType.TYPE })
+@Retention(RetentionPolicy.CLASS)
+public @interface Stubbed {
+}

patchwork-god-classes/README.md

@@ -1,12 +1,15 @@
 # patchwork-god-classes
 
-Implementation of ForgeHooks, ForgeHooksClient, ForgeEventFactory, and BasicEventHooks that dispatches to different patchwork modules.
+Implementation of ForgeHooks, ForgeHooksClient, ForgeEventFactory, ClientHooks, and BasicEventHooks that dispatches to different patchwork modules.
 
 ## Reasoning
 
 Forge uses these classes from inside their patches in order to keep the size of their patches down.
 Patchwork keeps its hooks seperated between modules, however, some mods also use these classes.
 Therefore, this module exists to dispatch calls to these classes to the disperate modules that actually implement the relevant methods.
 
+Don't depend on this module from other modules. If you feel the need to do so, something has gone wrong
+and implementation details should be moved into its proper module.
+
 ## TODO
  * Implement the methods on these classes that are actually already implemented in Patchwork.