Skip to content

Commit 72aadb2

Browse files
committed
chore: Remove unnecessary comments from E2E test workflow
1 parent f278d3b commit 72aadb2

1 file changed

Lines changed: 0 additions & 9 deletions

File tree

.github/workflows/e2e-tests.yml

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -123,10 +123,8 @@ jobs:
123123
shell: bash
124124
run: |
125125
if [[ "${{ runner.os }}" == "Windows" ]]; then
126-
# Windows: Use PowerShell to start process in background
127126
powershell -Command "Start-Process -FilePath '.\dist\${{ matrix.output }}' -ArgumentList '--no-printers' -WindowStyle Hidden"
128127
else
129-
# Linux/macOS: Start with full log redirection
130128
chmod +x dist/${{ matrix.output }}
131129
./dist/${{ matrix.output }} --no-printers > startup.log 2>&1 &
132130
echo $! > binary.pid
@@ -142,7 +140,6 @@ jobs:
142140
shell: bash
143141
run: |
144142
if [[ "${{ runner.os }}" != "Windows" ]]; then
145-
# Linux/macOS: Validate log file contents (skip Windows - API tests are sufficient)
146143
if grep -iE "\[Error\]|\[Fatal\]|exception" startup.log; then
147144
echo "::error::Errors detected during startup"
148145
cat startup.log
@@ -161,20 +158,17 @@ jobs:
161158
if: matrix.can_execute == true
162159
shell: bash
163160
run: |
164-
# Test 1: Auth status (public endpoint) - should return valid JSON
165161
response=$(curl -s http://localhost:3000/api/auth/status)
166162
if ! echo "$response" | jq '.' > /dev/null 2>&1; then
167163
echo "::error::Auth status API returned invalid JSON: $response"
168164
exit 1
169165
fi
170166
171-
# Test 2: Serve index.html
172167
if ! curl -s http://localhost:3000/ | grep -q "FlashForge Web UI"; then
173168
echo "::error::Failed to serve index.html"
174169
exit 1
175170
fi
176171
177-
# Test 3: Login endpoint
178172
login_response=$(curl -s -X POST http://localhost:3000/api/auth/login \
179173
-H "Content-Type: application/json" \
180174
-d '{"password":"changeme"}')
@@ -191,10 +185,8 @@ jobs:
191185
shell: bash
192186
run: |
193187
if [[ "${{ runner.os }}" == "Windows" ]]; then
194-
# Windows: Kill process by executable name using taskkill
195188
taskkill /F /IM "${{ matrix.output }}" 2>/dev/null || true
196189
else
197-
# Linux/macOS: Use PID file
198190
if [ -f binary.pid ]; then
199191
kill -TERM $(cat binary.pid) || true
200192
rm binary.pid
@@ -208,7 +200,6 @@ jobs:
208200
shell: bash
209201
run: |
210202
if [[ "${{ runner.os }}" != "Windows" ]]; then
211-
# Linux/macOS: Check for zombie processes (skip Windows - taskkill is sufficient)
212203
if pgrep -f "${{ matrix.output }}"; then
213204
echo "::error::Binary left zombie processes"
214205
exit 1

0 commit comments

Comments
 (0)