🩹 [Patch]: Update logging in PSScriptAnalyzer tests to include full settings file path

MariusStorhaug · MariusStorhaug · commit dd08ad8d6edb · 2025-02-23T18:39:18.000+01:00
diff --git a/scripts/tests/PSScriptAnalyzer/PSScriptAnalyzer.Tests.ps1 b/scripts/tests/PSScriptAnalyzer/PSScriptAnalyzer.Tests.ps1
@@ -60,14 +60,13 @@ BeforeDiscovery {
                 }
             )
         }
-        Write-Warning "Discovered [$($rules.Count)] rules"
-        $relativeSettingsFilePath = $SettingsFilePath.Replace($PSScriptRoot, '').Trim('\').Trim('/')
     }
 }
 
 Describe "PSScriptAnalyzer" {
     BeforeAll {
-        LogGroup "Invoke-ScriptAnalyzer -Path [$Path] -Settings [$relativeSettingsFilePath]" {
+        $relativeSettingsFilePath = $SettingsFilePath.Replace($PSScriptRoot, '').Trim('\').Trim('/')
+        LogGroup "Invoke-ScriptAnalyzer -Path [$Path] -Settings [$SettingsFilePath]" {
             $testResults = Invoke-ScriptAnalyzer -Path $Path -Settings $SettingsFilePath -Recurse -Verbose
             Write-Warning "Found [$($testResults.Count)] issues"
         }

Original file line number	Diff line number	Diff line change
`@@ -60,14 +60,13 @@ BeforeDiscovery {`
`60`	`60`	`}`
`61`	`61`	`)`
`62`	`62`	`}`
`63`		`- Write-Warning "Discovered [$($rules.Count)] rules"`
`64`		`- $relativeSettingsFilePath = $SettingsFilePath.Replace($PSScriptRoot, '').Trim('\').Trim('/')`
`65`	`63`	`}`
`66`	`64`	`}`
`67`	`65`
`68`	`66`	`Describe "PSScriptAnalyzer" {`
`69`	`67`	`BeforeAll {`
`70`		`- LogGroup "Invoke-ScriptAnalyzer -Path [$Path] -Settings [$relativeSettingsFilePath]" {`
	`68`	`+ $relativeSettingsFilePath = $SettingsFilePath.Replace($PSScriptRoot, '').Trim('\').Trim('/')`
	`69`	`+ LogGroup "Invoke-ScriptAnalyzer -Path [$Path] -Settings [$SettingsFilePath]" {`
`71`	`70`	`$testResults = Invoke-ScriptAnalyzer -Path $Path -Settings $SettingsFilePath -Recurse -Verbose`
`72`	`71`	`Write-Warning "Found [$($testResults.Count)] issues"`
`73`	`72`	`}`