🩹 [Patch]: Simplify PSScriptAnalyzer test description and remove unnecessary suppression attribute

MariusStorhaug · MariusStorhaug · commit b11037f1bb29 · 2025-02-23T18:24:16.000+01:00
diff --git a/scripts/tests/PSScriptAnalyzer/PSScriptAnalyzer.Tests.ps1 b/scripts/tests/PSScriptAnalyzer/PSScriptAnalyzer.Tests.ps1
@@ -65,7 +65,7 @@ BeforeDiscovery {
     }
 }
 
-Describe "PSScriptAnalyzer tests using settings file [$relativeSettingsFilePath]" {
+Describe "PSScriptAnalyzer" {
     BeforeAll {
         $testResults = Invoke-ScriptAnalyzer -Path $Path -Settings $SettingsFilePath -Recurse -Verbose:$false
         Write-Warning "Found [$($testResults.Count)] issues"
diff --git a/tests/srcWithManifestTestRepo/src/functions/public/SomethingElse/Set-PSModuleTest.ps1 b/tests/srcWithManifestTestRepo/src/functions/public/SomethingElse/Set-PSModuleTest.ps1
@@ -8,10 +8,6 @@
 
         "Hello, World!"
     #>
-    [Diagnostics.CodeAnalysis.SuppressMessageAttribute(
-        'PSUseShouldProcessForStateChangingFunctions', '', Scope = 'Function',
-        Justification = 'Reason for suppressing'
-    )]
     [CmdletBinding()]
     param (
         # Name of the person to greet.

Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,7 @@ BeforeDiscovery {`
`65`	`65`	`}`
`66`	`66`	`}`
`67`	`67`
`68`		`-Describe "PSScriptAnalyzer tests using settings file [$relativeSettingsFilePath]" {`
	`68`	`+Describe "PSScriptAnalyzer" {`
`69`	`69`	`BeforeAll {`
`70`	`70`	`$testResults = Invoke-ScriptAnalyzer -Path $Path -Settings $SettingsFilePath -Recurse -Verbose:$false`
`71`	`71`	`Write-Warning "Found [$($testResults.Count)] issues"`