🩹 [Patch]: Refactor PSScriptAnalyzer test structure for improved readability and organization

Author: MariusStorhaug

scripts/tests/PSScriptAnalyzer/PSScriptAnalyzer.Tests.ps1

@@ -61,39 +61,36 @@ BeforeDiscovery {
             )
         }
     }
-}
-
-Describe 'PSScriptAnalyzer' {
-    BeforeAll {
-        $relativeSettingsFilePath = if ($SettingsFilePath.StartsWith($PSScriptRoot)) {
-            $SettingsFilePath.Replace($PSScriptRoot, 'Action:').Trim('\').Trim('/')
-        } elseif ($SettingsFilePath.StartsWith($env:GITHUB_WORKSPACE)) {
-            $SettingsFilePath.Replace($env:GITHUB_WORKSPACE, 'Workspace:').Trim('\').Trim('/')
-        } else {
-            $SettingsFilePath
-        }
-        [pscustomobject]@{
-            relativeSettingsFilePath = $relativeSettingsFilePath
-            SettingsFilePath         = $SettingsFilePath
-            PSScriptRoot             = $PSScriptRoot
-            GITHUB_WORKSPACE         = $env:GITHUB_WORKSPACE
-        }
-        LogGroup "Invoke-ScriptAnalyzer -Path [$Path] -Settings [$relativeSettingsFilePath]" {
-            $testResults = Invoke-ScriptAnalyzer -Path $Path -Settings $SettingsFilePath -Recurse -Verbose
-        }
-        LogGroup "TestResults [$($testResults.Count)]" {
-            $testResults | ForEach-Object {
-                $_ | Format-List | Out-String -Stream | ForEach-Object {
-                    Write-Verbose $_ -Verbose
-                }
+    $relativeSettingsFilePath = if ($SettingsFilePath.StartsWith($PSScriptRoot)) {
+        $SettingsFilePath.Replace($PSScriptRoot, 'Action:').Trim('\').Trim('/')
+    } elseif ($SettingsFilePath.StartsWith($env:GITHUB_WORKSPACE)) {
+        $SettingsFilePath.Replace($env:GITHUB_WORKSPACE, 'Workspace:').Trim('\').Trim('/')
+    } else {
+        $SettingsFilePath
+    }
+    [pscustomobject]@{
+        relativeSettingsFilePath = $relativeSettingsFilePath
+        SettingsFilePath         = $SettingsFilePath
+        PSScriptRoot             = $PSScriptRoot
+        GITHUB_WORKSPACE         = $env:GITHUB_WORKSPACE
+    }
+    LogGroup "Invoke-ScriptAnalyzer -Path [$Path] -Settings [$relativeSettingsFilePath]" {
+        $testResults = Invoke-ScriptAnalyzer -Path $Path -Settings $SettingsFilePath -Recurse -Verbose
+    }
+    LogGroup "TestResults [$($testResults.Count)]" {
+        $testResults | ForEach-Object {
+            $_ | Format-List | Out-String -Stream | ForEach-Object {
+                Write-Verbose $_ -Verbose
             }
         }
     }
+}
 
+Describe 'PSScriptAnalyzer' {
     foreach ($Severety in $Severeties) {
         Context "Severity: $Severety" {
             foreach ($rule in $rules | Where-Object -Property Severity -EQ $Severety) {
-                It "$($rule.CommonName) ($($rule.RuleName))" -Skip:$rule.Skip -ForEach $rule {
+                It "$($rule.CommonName) ($($rule.RuleName))" -Skip:$rule.Skip {
                     $issues = [Collections.Generic.List[string]]::new()
                     $testResults | Where-Object -Property RuleName -EQ $rule.RuleName | ForEach-Object {
                         $relativePath = $_.ScriptPath.Replace($Path, '').Trim('\').Trim('/')