estimate -> bool

Author: dweindl

petab/v2/core.py

@@ -890,19 +890,21 @@ def _validate_estimate_before(cls, v):
         if isinstance(v, bool):
             return v
 
-        if isinstance(v, int) or isinstance(v, float) and v.is_integer():
-            if v == 0:
-                return False
-            if v == 1:
-                return True
+        # FIXME: grace period for 0/1 values until the test suite was updated
+        if v in [0, 1, "0", "1"]:
+            return bool(int(v))
 
+        # TODO: clarify whether extra whitespace is allowed
         if isinstance(v, str):
-            if v == "0":
-                return False
-            if v == "1":
+            v = v.strip().lower()
+            if v == "true":
                 return True
+            if v == "false":
+                return False
 
-        raise ValueError(f"Invalid value for estimate: {v}. Must be 0 or 1.")
+        raise ValueError(
+            f"Invalid value for estimate: {v}. Must be `true` or `false`."
+        )
 
     @field_validator("lb", "ub", "nominal_value")
     @classmethod

petab/v2/problem.py

@@ -970,7 +970,7 @@ def add_parameter(
             PARAMETER_ID: id_,
         }
         if estimate is not None:
-            record[ESTIMATE] = int(estimate)
+            record[ESTIMATE] = estimate
         if nominal_value is not None:
             record[NOMINAL_VALUE] = nominal_value
         if scale is not None: