[Deprecation] `source_permissions` File Parameter

[silug]

Summary

source_permissions emits a deprecation warning when used and should be removed in favor of explicit owner, group, and mode.

Evidence

• lib/puppet/type/file/source.rb:374 emits: The source_permissions parameter is deprecated. Explicitly set owner, group, and mode.

Proposed OpenVox 9 Change

• Remove source_permissions parameter from the file type.
• Remove associated validation/defaulting and docs.

Compatibility / Risk

• Medium risk for manifests that depend on implicit permission propagation.
• Requires migration guidance to explicit permissions.

Implementation Notes

• Audit sync/apply logic to ensure no hidden dependency on this parameter.
• Update file type docs and examples.

Acceptance Criteria

• source_permissions is rejected as unsupported parameter.
• No warning path for this deprecated parameter remains.
• Explicit permissions behavior (owner/group/mode) remains unchanged.

Suggested Tests

• Type validation tests: removed parameter should fail fast.
• Existing permission management integration tests remain green.

[binford2k]

deprecated in be91caa

[binford2k]

https://puppet.atlassian.net/browse/PUP-10253 asks for the functionality to be un-deprecated because it's still in use.

[silug]

https://puppet.atlassian.net/browse/PUP-10253 asks for the functionality to be un-deprecated because it's still in use.

I'm not opposed to removing the deprecation warning, but it does look like we should fix the feature on Windows if we're going to keep it around.

openvox/lib/puppet/file_serving/metadata.rb

Line 76 in 49104f7

raise(ArgumentError, _("Unsupported Windows source permissions option %{source_permissions}") % { source_permissions: source_permissions }) unless @source_permissions_ignore

[yakatz]

I have seen this used in many modules. If there is a way to keep it, that would be better.