Skip to content

remove under construction banner and note#313

Merged
corporate-gadfly merged 1 commit into
OpenVoxProject:masterfrom
corporate-gadfly:remove-under-construction
Jun 8, 2026
Merged

remove under construction banner and note#313
corporate-gadfly merged 1 commit into
OpenVoxProject:masterfrom
corporate-gadfly:remove-under-construction

Conversation

@corporate-gadfly

Copy link
Copy Markdown
Contributor

Checklist

I have:

@corporate-gadfly corporate-gadfly requested a review from a team as a code owner June 8, 2026 14:48
@miharp

miharp commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Please don't delete layout_end.html entirely — it also contains the syncSidebarNavGroups logic from f888334, which keeps the persistent sidebar in sync with the current collection during Turbo navigation.

Signed-off-by: Corporate Gadfly <haroon.rafique@gmail.com>
@corporate-gadfly corporate-gadfly force-pushed the remove-under-construction branch from f0cc9b5 to b541182 Compare June 8, 2026 17:38
@corporate-gadfly

Copy link
Copy Markdown
Contributor Author

Please don't delete layout_end.html entirely — it also contains the syncSidebarNavGroups logic from f888334, which keeps the persistent sidebar in sync with the current collection during Turbo navigation.

@miharp Oops... Thanks for pointing that out. Could you take another look please?

@miharp miharp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, +1

@corporate-gadfly corporate-gadfly merged commit 82a30da into OpenVoxProject:master Jun 8, 2026
5 checks passed
@corporate-gadfly

Copy link
Copy Markdown
Contributor Author

Banner was initially introduced in #49 but since then other changes were made to layout_end.html in #109 (which we are keeping).

@corporate-gadfly corporate-gadfly deleted the remove-under-construction branch June 8, 2026 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants