Fix open_simulation_interface-config.cmake.in#852
Merged
pmai merged 1 commit intoOpenSimulationInterface:masterfrom Apr 10, 2025
Merged
Fix open_simulation_interface-config.cmake.in#852pmai merged 1 commit intoOpenSimulationInterface:masterfrom
pmai merged 1 commit intoOpenSimulationInterface:masterfrom
Conversation
This filename must be the same with [this filename](https://github.com/OpenSimulationInterface/open-simulation-interface/blob/e78dff7443bb71e563431175fbd09bafba27da2c/CMakeLists.txt#L230) Signed-off-by: Doğan Ulus <dogan.ulus@bogazici.edu.tr>
jdsika
added
BreaksCompatibility
pmai
added
the
ReadyForCCBReview
pmai
approved these changes
Apr 10, 2025
Contributor
pmai
left a comment
pmai
left a comment
There was a problem hiding this comment.
Good catch, should be applied.
Member
|
ASAM OSI CCB 2025-04-10: Approved and assigned to v3.7.1 and ready to be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The corresponding filename in the patch must be the same as this filename
When using CMake's
find_packageto use the library in another project, the mismatch between filenames results in an error.