Small optimizations

Author: hhvrc

Common/OpenShockServiceHelper.cs

@@ -34,17 +34,8 @@ static bool HandleRankCheck(AuthorizationHandlerContext context, RankType requir
     {
         var ranks = context.User.Identities.SelectMany(ident => ident.Claims.Where(claim => claim.Type == ident.RoleClaimType)).Select(claim => Enum.Parse<RankType>(claim.Value)).ToList();
 
-        if (!ranks.Any())
-        {
-            return false;
-        }
-
-        if (ranks.Max() < requiredRank)
-        {
-            return false;
-        }
-
-        return true;
+        // Has any rank that is higher than required rank
+        return ranks.Count != 0 && ranks.Max() >= requiredRank;
     }
 
     /// <summary>

Common/Swagger/SwaggerGenExtensions.cs

@@ -105,7 +105,7 @@ public static IServiceCollection AddSwaggerExt<TProgram>(this IServiceCollection
     public static IApplicationBuilder UseSwaggerExt(this WebApplication app)
     {
         var provider = app.Services.GetRequiredService<IApiVersionDescriptionProvider>();
-        var groupNames = provider.ApiVersionDescriptions.Select(d => d.GroupName).ToList();
+        var groupNames = provider.ApiVersionDescriptions.Select(d => d.GroupName);
 
         return app
             .UseSwagger()

LiveControlGateway/LifetimeManager/HubLifetime.cs

@@ -152,13 +152,13 @@ public async Task UpdateDevice()
     private async Task UpdateShockers(OpenShockContext db)
     {
         _logger.LogDebug("Updating shockers for device [{DeviceId}]", HubController.Id);
-        var ownShockers = await db.Shockers.Where(x => x.Device == HubController.Id).Select(x => new ShockerState()
+        
+        _shockerStates = await db.Shockers.Where(x => x.Device == HubController.Id).Select(x => new ShockerState()
         {
             Id = x.Id,
             Model = x.Model,
             RfId = x.RfId
-        }).ToListAsync(cancellationToken: _cancellationToken);
-        _shockerStates = ownShockers.ToDictionary(x => x.Id, x => x);
+        }).ToDictionaryAsync(x => x.Id, x => x, cancellationToken: _cancellationToken);
     }
 
     /// <summary>