Don't follow symlinks when cleaning out the temporary directory (Issue #1448)

Author: michaelrsweet

CHANGES.md

@@ -2,6 +2,13 @@ CHANGES - OpenPrinting CUPS
 ===========================
 
 
+Changes in CUPS v2.4.17 (YYYY-MM-DD)
+------------------------------------
+
+- The scheduler followed symbolic links when cleaning out its temporary
+  directory (Issue #1448)
+
+
 Changes in CUPS v2.4.16 (2025-12-04)
 ------------------------------------
 

scheduler/file.c

@@ -35,6 +35,7 @@ cupsdCleanFiles(const char *path,	/* I - Directory to clean */
   cups_dir_t	*dir;			/* Directory */
   cups_dentry_t	*dent;			/* Directory entry */
   char		filename[1024];		/* Filename */
+  struct stat	fileinfo;		/* File link information */
   int		status;			/* Status from unlink/rmdir */
 
 
@@ -57,15 +58,19 @@ cupsdCleanFiles(const char *path,	/* I - Directory to clean */
       continue;
 
     snprintf(filename, sizeof(filename), "%s/%s", path, dent->filename);
+    if (lstat(filename, &fileinfo))
+      continue;
 
-    if (S_ISDIR(dent->fileinfo.st_mode))
+    if (S_ISDIR(fileinfo.st_mode))
     {
       cupsdCleanFiles(filename, pattern);
 
       status = rmdir(filename);
     }
     else
+    {
       status = cupsdUnlinkOrRemoveFile(filename);
+    }
 
     if (status)
       cupsdLogMessage(CUPSD_LOG_ERROR, "Unable to remove \"%s\" - %s", filename,