org.apache.wink missing dependency for using HTTPClient

[paulswithers]

org.apache.wink includes the jar file httpclient-4.0.1.jar. However, the one of the private variables of AbstractHttpClient is "log", an instance of org.apache.commons.logging.Log. However, although org.apache.commons.logging-2.0.1 is included on the Domino server, the org.apache.wink plugin doesn't include that dependency in the MANIFEST.MF https://github.com/OpenNTF/XPagesExtensionLibrary/blob/master/extlib/lwp/product/runtime/eclipse/plugins/org.apache.wink/META-INF/MANIFEST.MF

As a result, any attempt to use it throws a NoClassDefFoundError with org.apache.commons.logging.LogFactory, as below.

The resolution is to add org.apache.commons.logging on the Dependencies tab of the plugin.xml (so adding "org.apache.commons.logging" to the Require-Bundle definition in the MANIFEST.MF)

01/07/2016 13:42:51 HTTP JVM: 2016/07/01 13:42:51.185 SEVERE Uncaught service() exception thrown by servlet KYCRApp: javax.servlet.ServletException: java.lang.NoClassDefFoundError: org.apache.commons.logging.LogFactory
01/07/2016 13:42:51 HTTP JVM: at org.apache.wink.server.internal.RequestProcessor.handleRequest(RequestProcessor.java:195)
01/07/2016 13:42:51 HTTP JVM: at org.apache.wink.server.internal.servlet.RestServlet.service(RestServlet.java:119)
01/07/2016 13:42:51 HTTP JVM: at com.ibm.domino.services.AbstractRestServlet.doService(AbstractRestServlet.java:75)
01/07/2016 13:42:51 HTTP JVM: at uk.police.gmp.kycrservlet.ODADataServlet.doService(ODADataServlet.java:52)
01/07/2016 13:42:51 HTTP JVM: at com.ibm.domino.services.AbstractRestServlet.service(AbstractRestServlet.java:62)
01/07/2016 13:42:51 HTTP JVM: at javax.servlet.http.HttpServlet.service(HttpServlet.java:806)
01/07/2016 13:42:51 HTTP JVM: at com.ibm.ws.webcontainer.servlet.ServletWrapper.service(ServletWrapper.java:1661)
01/07/2016 13:42:51 HTTP JVM: at com.ibm.ws.webcontainer.servlet.ServletWrapper.handleRequest(ServletWrapper.java:937)
01/07/2016 13:42:51 HTTP JVM: at com.ibm.pvc.internal.webcontainer.servlet.ServletWrapper.handleRequest(ServletWrapper.java:85)
01/07/2016 13:42:51 HTTP JVM: at com.ibm.ws.webcontainer.servlet.ServletWrapper.handleRequest(ServletWrapper.java:500)
01/07/2016 13:42:51 HTTP JVM: at com.ibm.ws.webcontainer.webapp.WebApp.handleRequest(WebApp.java:3810)
01/07/2016 13:42:51 HTTP JVM: at com.ibm.ws.webcontainer.webapp.WebGroup.handleRequest(WebGroup.java:276)
01/07/2016 13:42:51 HTTP JVM: at com.ibm.pvc.internal.webcontainer.VirtualHost.handleRequest(VirtualHost.java:143)
01/07/2016 13:42:51 HTTP JVM: at com.ibm.ws.webcontainer.WebContainer.handleRequest(WebContainer.java:931)
01/07/2016 13:42:51 HTTP JVM: at com.ibm.pvc.internal.webcontainer.WebContainerBridge.handleRequest(WebContainerBridge.java:25)
01/07/2016 13:42:51 HTTP JVM: at com.ibm.domino.osgi.core.webContainer.WebApplicationsTracker.doService(WebApplicationsTracker.java:141)
01/07/2016 13:42:51 HTTP JVM: at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
01/07/2016 13:42:51 HTTP JVM: at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:60)
01/07/2016 13:42:51 HTTP JVM: at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:37)
01/07/2016 13:42:51 HTTP JVM: at java.lang.reflect.Method.invoke(Method.java:611)
01/07/2016 13:42:51 HTTP JVM: at com.ibm.domino.xsp.adapter.osgi.webContainer.OSGIWebContainerModule.invokeWebAppContainerService(OSGIWebContainerModule.java:207)
01/07/2016 13:42:51 HTTP JVM: at com.ibm.domino.xsp.adapter.osgi.webContainer.OSGIWebContainerModule.doService(OSGIWebContainerModule.java:178)
01/07/2016 13:42:51 HTTP JVM: at com.ibm.domino.xsp.adapter.osgi.OSGIService.doService(OSGIService.java:417)
01/07/2016 13:42:51 HTTP JVM: at com.ibm.designer.runtime.domino.adapter.LCDEnvironment.doService(LCDEnvironment.java:357)
01/07/2016 13:42:51 HTTP JVM: at com.ibm.designer.runtime.domino.adapter.LCDEnvironment.service(LCDEnvironment.java:313)
01/07/2016 13:42:51 HTTP JVM: at com.ibm.domino.xsp.bridge.http.engine.XspCmdManager.service(XspCmdManager.java:272)
01/07/2016 13:42:51 HTTP JVM: Caused by: java.lang.NoClassDefFoundError: org.apache.commons.logging.LogFactory
01/07/2016 13:42:51 HTTP JVM: at org.apache.http.impl.client.AbstractHttpClient.(AbstractHttpClient.java:159)
01/07/2016 13:42:51 HTTP JVM: at org.apache.http.impl.client.DefaultHttpClient.(DefaultHttpClient.java:178)
01/07/2016 13:42:51 HTTP JVM: at uk.police.gmp.kycrservlet.Tests.output(Tests.java:114)
01/07/2016 13:42:51 HTTP JVM: at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
01/07/2016 13:42:51 HTTP JVM: at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:60)
01/07/2016 13:42:51 HTTP JVM: at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:37)
01/07/2016 13:42:51 HTTP JVM: at java.lang.reflect.Method.invoke(Method.java:611)
01/07/2016 13:42:51 HTTP JVM: at org.apache.wink.server.internal.handlers.InvokeMethodHandler.handleRequest(InvokeMethodHandler.java:63)
01/07/2016 13:42:51 HTTP JVM: at org.apache.wink.server.handlers.AbstractHandler.handleRequest(AbstractHandler.java:33)
01/07/2016 13:42:51 HTTP JVM: at org.apache.wink.server.handlers.RequestHandlersChain.handle(RequestHandlersChain.java:26)
01/07/2016 13:42:51 HTTP JVM: at org.apache.wink.server.handlers.RequestHandlersChain.handle(RequestHandlersChain.java:22)
01/07/2016 13:42:51 HTTP JVM: at org.apache.wink.server.handlers.AbstractHandlersChain.doChain(AbstractHandlersChain.java:63)
01/07/2016 13:42:51 HTTP JVM: at org.apache.wink.server.internal.handlers.CreateInvocationParametersHandler.handleRequest(CreateInvocationParametersHandler.java:54)
01/07/2016 13:42:51 HTTP JVM: at org.apache.wink.server.handlers.RequestHandlersChain.handle(RequestHandlersChain.java:26)
01/07/2016 13:42:51 HTTP JVM: at org.apache.wink.server.handlers.RequestHandlersChain.handle(RequestHandlersChain.java:22)
01/07/2016 13:42:51 HTTP JVM: at org.apache.wink.server.handlers.AbstractHandlersChain.doChain(AbstractHandlersChain.java:63)
01/07/2016 13:42:51 HTTP JVM: at org.apache.wink.server.internal.handlers.FindResourceMethodHandler.handleSubResourceMethod(FindResourceMethodHandler.java:183)
01/07/2016 13:42:51 HTTP JVM: at org.apache.wink.server.internal.handlers.FindResourceMethodHandler.handleRequest(FindResourceMethodHandler.java:110)
01/07/2016 13:42:51 HTTP JVM: at org.apache.wink.server.handlers.RequestHandlersChain.handle(RequestHandlersChain.java:26)
01/07/2016 13:42:51 HTTP JVM: at org.apache.wink.server.handlers.RequestHandlersChain.handle(RequestHandlersChain.java:22)
01/07/2016 13:42:51 HTTP JVM: at org.apache.wink.server.handlers.AbstractHandlersChain.doChain(AbstractHandlersChain.java:63)
01/07/2016 13:42:51 HTTP JVM: at org.apache.wink.server.internal.handlers.FindRootResourceHandler.handleRequest(FindRootResourceHandler.java:95)
01/07/2016 13:42:51 HTTP JVM: at org.apache.wink.server.handlers.RequestHandlersChain.handle(RequestHandlersChain.java:26)
01/07/2016 13:42:51 HTTP JVM: at org.apache.wink.server.handlers.RequestHandlersChain.handle(RequestHandlersChain.java:22)
01/07/2016 13:42:51 HTTP JVM: at org.apache.wink.server.handlers.AbstractHandlersChain.doChain(AbstractHandlersChain.java:63)
01/07/2016 13:42:51 HTTP JVM: at org.apache.wink.server.internal.handlers.HeadMethodHandler.handleRequest(HeadMethodHandler.java:53)
01/07/2016 13:42:51 HTTP JVM: at org.apache.wink.server.handlers.RequestHandlersChain.handle(RequestHandlersChain.java:26)
01/07/2016 13:42:51 HTTP JVM: at org.apache.wink.server.handlers.RequestHandlersChain.handle(RequestHandlersChain.java:22)
01/07/2016 13:42:51 HTTP JVM: at org.apache.wink.server.handlers.AbstractHandlersChain.doChain(AbstractHandlersChain.java:63)
01/07/2016 13:42:51 HTTP JVM: at org.apache.wink.server.internal.handlers.OptionsMethodHandler.handleRequest(OptionsMethodHandler.java:46)
01/07/2016 13:42:51 HTTP JVM: at org.apache.wink.server.handlers.RequestHandlersChain.handle(RequestHandlersChain.java:26)
01/07/2016 13:42:51 HTTP JVM: at org.apache.wink.server.handlers.RequestHandlersChain.handle(RequestHandlersChain.java:22)
01/07/2016 13:42:51 HTTP JVM: at org.apache.wink.server.handlers.AbstractHandlersChain.doChain(AbstractHandlersChain.java:63)
01/07/2016 13:42:51 HTTP JVM: at org.apache.wink.server.internal.handlers.SearchResultHandler.handleRequest(SearchResultHandler.java:33)
01/07/2016 13:42:51 HTTP JVM: at org.apache.wink.server.handlers.RequestHandlersChain.handle(RequestHandlersChain.java:26)
01/07/2016 13:42:51 HTTP JVM: at org.apache.wink.server.handlers.RequestHandlersChain.handle(RequestHandlersChain.java:22)
01/07/2016 13:42:51 HTTP JVM: at org.apache.wink.server.handlers.AbstractHandlersChain.doChain(AbstractHandlersChain.java:63)
01/07/2016 13:42:51 HTTP JVM: at org.apache.wink.server.internal.log.ResourceInvocation.handleRequest(ResourceInvocation.java:92)
01/07/2016 13:42:51 HTTP JVM: at org.apache.wink.server.handlers.RequestHandlersChain.handle(RequestHandlersChain.java:26)
01/07/2016 13:42:51 HTTP JVM: at org.apache.wink.server.handlers.RequestHandlersChain.handle(RequestHandlersChain.java:22)
01/07/2016 13:42:51 HTTP JVM: at org.apache.wink.server.handlers.AbstractHandlersChain.doChain(AbstractHandlersChain.java:63)
01/07/2016 13:42:51 HTTP JVM: at org.apache.wink.server.internal.log.Requests.handleRequest(Requests.java:76)
01/07/2016 13:42:51 HTTP JVM: at org.apache.wink.server.handlers.RequestHandlersChain.handle(RequestHandlersChain.java:26)
01/07/2016 13:42:51 HTTP JVM: at org.apache.wink.server.handlers.RequestHandlersChain.handle(RequestHandlersChain.java:22)
01/07/2016 13:42:51 HTTP JVM: at org.apache.wink.server.handlers.AbstractHandlersChain.doChain(AbstractHandlersChain.java:63)
01/07/2016 13:42:51 HTTP JVM: at org.apache.wink.server.handlers.AbstractHandlersChain.run(AbstractHandlersChain.java:48)
01/07/2016 13:42:51 HTTP JVM: at org.apache.wink.server.internal.RequestProcessor.handleRequestWithoutFaultBarrier(RequestProcessor.java:207)
01/07/2016 13:42:51 HTTP JVM: at org.apache.wink.server.internal.RequestProcessor.handleRequest(RequestProcessor.java:154)
01/07/2016 13:42:51 HTTP JVM: ... 25 more
01/07/2016 13:42:51 HTTP JVM: Caused by: java.lang.ClassNotFoundException: org.apache.commons.logging.LogFactory
01/07/2016 13:42:51 HTTP JVM: at org.eclipse.osgi.framework.internal.core.BundleLoader.findClassInternal(BundleLoader.java:483)
01/07/2016 13:42:51 HTTP JVM: at org.eclipse.osgi.framework.internal.core.BundleLoader.findClass(BundleLoader.java:399)
01/07/2016 13:42:51 HTTP JVM: at org.eclipse.osgi.framework.internal.core.BundleLoader.findClass(BundleLoader.java:387)
01/07/2016 13:42:51 HTTP JVM: at org.eclipse.osgi.internal.baseadaptor.DefaultClassLoader.loadClass(DefaultClassLoader.java:87)
01/07/2016 13:42:51 HTTP JVM: at java.lang.ClassLoader.loadClass(ClassLoader.java:642)
01/07/2016 13:42:51 HTTP JVM: ... 73 more
01/07/2016 13:42:51 HTTP JVM: ::class.method=com.ibm.ws.webcontainer.servlet.ServletWrapper.service() ::thread=Thread-6 ::loggername=com.ibm.ws.webcontainer.servlet