From f16fbb693a4a4a8d2a54f8b485de54ce4c021445 Mon Sep 17 00:00:00 2001
From: Soubhagya Mohapatra <ssm.allrounder@gmail.com>
Date: Mon, 17 Mar 2025 14:05:29 +0530
Subject: [PATCH 01/25] temp changes

---
 .../workflows/build-windows-executable-app.yaml  | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/.github/workflows/build-windows-executable-app.yaml b/.github/workflows/build-windows-executable-app.yaml
index 3284c10e5..a10f2c49e 100644
--- a/.github/workflows/build-windows-executable-app.yaml
+++ b/.github/workflows/build-windows-executable-app.yaml
@@ -403,6 +403,22 @@ jobs:
             <UI>
                   <UIRef Id="WixUI_InstallDir" />
                   <UIRef Id="WixUI_ErrorProgressText" />
+
+                  <!-- Skip license dialog -->
+                  <Publish Dialog="WelcomeDlg"
+                    Control="Next"
+                    Event="NewDialog"
+                    Value="InstallDirDlg"
+                    Order="2">
+                    1
+                  </Publish>
+                  <Publish Dialog="InstallDirDlg"
+                    Control="Back"
+                    Event="NewDialog"
+                    Value="WelcomeDlg"
+                    Order="2">
+                    1
+                  </Publish>
             </UI> 
         
             <!-- Provide license; it should exist in the SourceDir folder -->

From a01b15e23f8fbfe3f7205f49e1702f4886872b9d Mon Sep 17 00:00:00 2001
From: Soubhagya Mohapatra <ssm.allrounder@gmail.com>
Date: Mon, 17 Mar 2025 14:56:12 +0530
Subject: [PATCH 02/25] add custom message dialog

---
 .../build-windows-executable-app.yaml         | 35 +++++++++++++++++--
 1 file changed, 32 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/build-windows-executable-app.yaml b/.github/workflows/build-windows-executable-app.yaml
index a10f2c49e..e5dfaafca 100644
--- a/.github/workflows/build-windows-executable-app.yaml
+++ b/.github/workflows/build-windows-executable-app.yaml
@@ -404,23 +404,52 @@ jobs:
                   <UIRef Id="WixUI_InstallDir" />
                   <UIRef Id="WixUI_ErrorProgressText" />
 
+                  <!-- New Message Dialog -->
+                  <Dialog Id="CustomMessageDlg" Width="370" Height="270" Title="Important Information">
+                    <Control Id="MessageText" Type="Text" X="15" Y="10" Width="340" Height="100" 
+                            Text="Please review this message before continuing installation." />
+                    
+                    <Control Id="Next" Type="PushButton" X="200" Y="200" Width="80" Height="30" Default="yes" Text="Next">
+                      <Publish Event="NewDialog" Value="VerifyReadyDlg">1</Publish>
+                    </Control>
+                    
+                    <Control Id="Back" Type="PushButton" X="290" Y="200" Width="80" Height="30" Cancel="yes" Text="Back">
+                      <Publish Event="NewDialog" Value="WelcomeDlg">1</Publish>
+                    </Control>
+                  </Dialog>
+
                   <!-- Skip license dialog -->
                   <Publish Dialog="WelcomeDlg"
                     Control="Next"
                     Event="NewDialog"
-                    Value="InstallDirDlg"
+                    Value="CustomMessageDlg"
                     Order="2">
                     1
                   </Publish>
                   <Publish Dialog="InstallDirDlg"
                     Control="Back"
                     Event="NewDialog"
-                    Value="WelcomeDlg"
+                    Value="CustomMessageDlg"
+                    Order="2">
+                    1
+                  </Publish>
+                  <Publish 
+                    Dialog="CustomMessageDlg" 
+                    Control="Next" 
+                    Event="NewDialog" 
+                    Value="InstallDirDlg" 
+                    Order="2">
+                    1
+                  </Publish>
+                  <Publish 
+                    Dialog="CustomMessageDlg" 
+                    Control="Back" 
+                    Event="NewDialog" 
+                    Value="WelcomeDlg" 
                     Order="2">
                     1
                   </Publish>
             </UI> 
-        
             <!-- Provide license; it should exist in the SourceDir folder -->
             <WixVariable Id="WixUILicenseRtf" Value="SourceDir/openms_license.rtf" />
           </Product>

From 377a3fdc5223afd61b144403ba80dbef486d33e7 Mon Sep 17 00:00:00 2001
From: Soubhagya Mohapatra <ssm.allrounder@gmail.com>
Date: Mon, 17 Mar 2025 15:29:17 +0530
Subject: [PATCH 03/25] remove duplicacy

---
 .github/workflows/build-windows-executable-app.yaml | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/.github/workflows/build-windows-executable-app.yaml b/.github/workflows/build-windows-executable-app.yaml
index e5dfaafca..54d3da6c9 100644
--- a/.github/workflows/build-windows-executable-app.yaml
+++ b/.github/workflows/build-windows-executable-app.yaml
@@ -409,13 +409,8 @@ jobs:
                     <Control Id="MessageText" Type="Text" X="15" Y="10" Width="340" Height="100" 
                             Text="Please review this message before continuing installation." />
                     
-                    <Control Id="Next" Type="PushButton" X="200" Y="200" Width="80" Height="30" Default="yes" Text="Next">
-                      <Publish Event="NewDialog" Value="VerifyReadyDlg">1</Publish>
-                    </Control>
-                    
-                    <Control Id="Back" Type="PushButton" X="290" Y="200" Width="80" Height="30" Cancel="yes" Text="Back">
-                      <Publish Event="NewDialog" Value="WelcomeDlg">1</Publish>
-                    </Control>
+                    <Control Id="Next" Type="PushButton" X="200" Y="200" Width="80" Height="30" Default="yes" Text="Next" />
+                    <Control Id="Back" Type="PushButton" X="290" Y="200" Width="80" Height="30" Cancel="yes" Text="Back" />
                   </Dialog>
 
                   <!-- Skip license dialog -->

From e132c1aac6b4210afa487ed9fbce46dd87550246 Mon Sep 17 00:00:00 2001
From: Soubhagya Mohapatra <ssm.allrounder@gmail.com>
Date: Mon, 17 Mar 2025 19:04:30 +0530
Subject: [PATCH 04/25] now converting message box to browse box

---
 .../build-windows-executable-app.yaml         | 22 ++++++++++++++-----
 1 file changed, 16 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/build-windows-executable-app.yaml b/.github/workflows/build-windows-executable-app.yaml
index 54d3da6c9..50907ed0a 100644
--- a/.github/workflows/build-windows-executable-app.yaml
+++ b/.github/workflows/build-windows-executable-app.yaml
@@ -346,6 +346,7 @@ jobs:
         
             <!-- Folder structure -->
             <Property Id="WIXUI_INSTALLDIR" Value="INSTALLFOLDER" />
+            <Property Id="WORKSPACES_FOLDER" Value="INSTALLFOLDER" />
             <Directory Id="TARGETDIR" Name="SourceDir">
               <Directory Id="ProgramFilesFolder"> 
                 <Directory Id="INSTALLFOLDER" Name="${{ env.APP_NAME }}">
@@ -405,12 +406,21 @@ jobs:
                   <UIRef Id="WixUI_ErrorProgressText" />
 
                   <!-- New Message Dialog -->
-                  <Dialog Id="CustomMessageDlg" Width="370" Height="270" Title="Important Information">
-                    <Control Id="MessageText" Type="Text" X="15" Y="10" Width="340" Height="100" 
-                            Text="Please review this message before continuing installation." />
-                    
-                    <Control Id="Next" Type="PushButton" X="200" Y="200" Width="80" Height="30" Default="yes" Text="Next" />
-                    <Control Id="Back" Type="PushButton" X="290" Y="200" Width="80" Height="30" Cancel="yes" Text="Back" />
+                  <Dialog Id="CustomMessageDlg" Width="370" Height="300" Title="Important Information">
+                    <Control Id="MessageText" Type="Text" X="15" Y="10" Width="340" Height="40"
+                            Text="Please select a workspace location before continuing installation." />
+
+                    <!-- Textbox to Display Selected Path -->
+                    <Control Id="WorkspacePath" Type="Edit" X="15" Y="60" Width="240" Height="17" Property="WORKSPACES_FOLDER" Text="{80}" />
+
+                    <!-- Browse Button -->
+                    <Control Id="BrowseButton" Type="PushButton" X="260" Y="60" Width="80" Height="17" Text="Browse">
+                      <Publish Event="SpawnDialog" Value="BrowseDlg">1</Publish>
+                    </Control>
+
+                    <!-- Navigation Buttons -->
+                    <Control Id="Back" Type="PushButton" X="180" Y="243" Width="56" Height="30" Cancel="yes" Text="Back" />
+                    <Control Id="Next" Type="PushButton" X="236" Y="243" Width="56" Height="17" Default="yes" Text="Next" />
                   </Dialog>
 
                   <!-- Skip license dialog -->

From 860bf42461f2e64bc7d6454102f1544e7cfca57d Mon Sep 17 00:00:00 2001
From: Soubhagya Mohapatra <ssm.allrounder@gmail.com>
Date: Mon, 17 Mar 2025 20:17:02 +0530
Subject: [PATCH 05/25] UI modifications

---
 .../build-windows-executable-app.yaml         | 54 ++++++-------------
 1 file changed, 15 insertions(+), 39 deletions(-)

diff --git a/.github/workflows/build-windows-executable-app.yaml b/.github/workflows/build-windows-executable-app.yaml
index 50907ed0a..52a0ddef4 100644
--- a/.github/workflows/build-windows-executable-app.yaml
+++ b/.github/workflows/build-windows-executable-app.yaml
@@ -405,55 +405,31 @@ jobs:
                   <UIRef Id="WixUI_InstallDir" />
                   <UIRef Id="WixUI_ErrorProgressText" />
 
-                  <!-- New Message Dialog -->
-                  <Dialog Id="CustomMessageDlg" Width="370" Height="300" Title="Important Information">
-                    <Control Id="MessageText" Type="Text" X="15" Y="10" Width="340" Height="40"
-                            Text="Please select a workspace location before continuing installation." />
+                  <!-- New Dialog to select workspaces -->
+                  <Dialog Id="ChooseWorkspacesDlg" Width="370" Height="300" Title="!(loc.InstallDirDlg_Title)">
+                    <Control Id="MessageText" Type="Text" X="15" Y="10" Width="340" Height="40" Text="Please select a workspace location before continuing installation." />
 
-                    <!-- Textbox to Display Selected Path -->
+                    <!-- Browse for location -->
                     <Control Id="WorkspacePath" Type="Edit" X="15" Y="60" Width="240" Height="17" Property="WORKSPACES_FOLDER" Text="{80}" />
-
-                    <!-- Browse Button -->
-                    <Control Id="BrowseButton" Type="PushButton" X="260" Y="60" Width="80" Height="17" Text="Browse">
+                    <Control Id="BrowseButton" Type="PushButton" X="260" Y="60" Width="80" Height="17" Text="Change">
                       <Publish Event="SpawnDialog" Value="BrowseDlg">1</Publish>
                     </Control>
 
+                    <Control Id="Description" Type="Text" X="25" Y="23" Width="280" Height="15" Transparent="yes" NoPrefix="yes" Text="Click Next to choose default workspaces location or click Change to choose another folder" />
+                    <Control Id="Title" Type="Text" X="15" Y="6" Width="200" Height="15" Transparent="yes" NoPrefix="yes" Text="Workspaces Folder" />
+                    <Control Id="BannerBitmap" Type="Bitmap" X="0" Y="0" Width="370" Height="44" TabSkip="no" Text="!(loc.InstallDirDlgBannerBitmap)" />
+                    <Control Id="BannerLine" Type="Line" X="0" Y="44" Width="370" Height="0" />
+                    <Control Id="BottomLine" Type="Line" X="0" Y="234" Width="370" Height="0" />
+
                     <!-- Navigation Buttons -->
                     <Control Id="Back" Type="PushButton" X="180" Y="243" Width="56" Height="30" Cancel="yes" Text="Back" />
                     <Control Id="Next" Type="PushButton" X="236" Y="243" Width="56" Height="17" Default="yes" Text="Next" />
                   </Dialog>
 
-                  <!-- Skip license dialog -->
-                  <Publish Dialog="WelcomeDlg"
-                    Control="Next"
-                    Event="NewDialog"
-                    Value="CustomMessageDlg"
-                    Order="2">
-                    1
-                  </Publish>
-                  <Publish Dialog="InstallDirDlg"
-                    Control="Back"
-                    Event="NewDialog"
-                    Value="CustomMessageDlg"
-                    Order="2">
-                    1
-                  </Publish>
-                  <Publish 
-                    Dialog="CustomMessageDlg" 
-                    Control="Next" 
-                    Event="NewDialog" 
-                    Value="InstallDirDlg" 
-                    Order="2">
-                    1
-                  </Publish>
-                  <Publish 
-                    Dialog="CustomMessageDlg" 
-                    Control="Back" 
-                    Event="NewDialog" 
-                    Value="WelcomeDlg" 
-                    Order="2">
-                    1
-                  </Publish>
+                  <Publish Dialog="LicenseAgreementDlg" Control="Next" Event="NewDialog" Value="ChooseWorkspacesDlg" Order="2">LicenseAccepted = "1"</Publish>
+                  <Publish Dialog="InstallDirDlg" Control="Back" Event="NewDialog" Value="ChooseWorkspacesDlg" Order="2">1</Publish>
+                  <Publish Dialog="ChooseWorkspacesDlg" Control="Next" Event="NewDialog" Value="InstallDirDlg" Order="2">1</Publish>
+                  <Publish Dialog="ChooseWorkspacesDlg" Control="Back" Event="NewDialog" Value="LicenseAgreementDlg" Order="2">1</Publish>
             </UI> 
             <!-- Provide license; it should exist in the SourceDir folder -->
             <WixVariable Id="WixUILicenseRtf" Value="SourceDir/openms_license.rtf" />

From 324246a7aa104654ba6db05e3daec1fd4b47b7ef Mon Sep 17 00:00:00 2001
From: Soubhagya Mohapatra <ssm.allrounder@gmail.com>
Date: Mon, 17 Mar 2025 20:59:07 +0530
Subject: [PATCH 06/25] more changes to look and feel

---
 .../build-windows-executable-app.yaml         | 22 +++++++++----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/.github/workflows/build-windows-executable-app.yaml b/.github/workflows/build-windows-executable-app.yaml
index 52a0ddef4..f9df38603 100644
--- a/.github/workflows/build-windows-executable-app.yaml
+++ b/.github/workflows/build-windows-executable-app.yaml
@@ -406,24 +406,24 @@ jobs:
                   <UIRef Id="WixUI_ErrorProgressText" />
 
                   <!-- New Dialog to select workspaces -->
-                  <Dialog Id="ChooseWorkspacesDlg" Width="370" Height="300" Title="!(loc.InstallDirDlg_Title)">
-                    <Control Id="MessageText" Type="Text" X="15" Y="10" Width="340" Height="40" Text="Please select a workspace location before continuing installation." />
-
-                    <!-- Browse for location -->
-                    <Control Id="WorkspacePath" Type="Edit" X="15" Y="60" Width="240" Height="17" Property="WORKSPACES_FOLDER" Text="{80}" />
-                    <Control Id="BrowseButton" Type="PushButton" X="260" Y="60" Width="80" Height="17" Text="Change">
-                      <Publish Event="SpawnDialog" Value="BrowseDlg">1</Publish>
-                    </Control>
-
+                  <Dialog Id="ChooseWorkspacesDlg" Width="370" Height="270" Title="!(loc.InstallDirDlg_Title)">
                     <Control Id="Description" Type="Text" X="25" Y="23" Width="280" Height="15" Transparent="yes" NoPrefix="yes" Text="Click Next to choose default workspaces location or click Change to choose another folder" />
                     <Control Id="Title" Type="Text" X="15" Y="6" Width="200" Height="15" Transparent="yes" NoPrefix="yes" Text="Workspaces Folder" />
                     <Control Id="BannerBitmap" Type="Bitmap" X="0" Y="0" Width="370" Height="44" TabSkip="no" Text="!(loc.InstallDirDlgBannerBitmap)" />
                     <Control Id="BannerLine" Type="Line" X="0" Y="44" Width="370" Height="0" />
                     <Control Id="BottomLine" Type="Line" X="0" Y="234" Width="370" Height="0" />
 
+                    <!-- Browse for workspaces folder location -->
+                    <Control Id="FolderLabel" Type="Text" X="20" Y="60" Width="290" Height="30" NoPrefix="yes" Text="Please select a workspace location before continuing installation." />
+                    <Control Id="Folder" Type="PathEdit" X="20" Y="100" Width="320" Height="18" Property="WORKSPACES_FOLDER" Indirect="yes" />
+                    <Control Id="ChangeFolder" Type="PushButton" X="20" Y="120" Width="56" Height="17" Text="Change" />
+
                     <!-- Navigation Buttons -->
-                    <Control Id="Back" Type="PushButton" X="180" Y="243" Width="56" Height="30" Cancel="yes" Text="Back" />
-                    <Control Id="Next" Type="PushButton" X="236" Y="243" Width="56" Height="17" Default="yes" Text="Next" />
+                    <Control Id="Back" Type="PushButton" X="180" Y="243" Width="56" Height="17" Cancel="yes" Text="!(loc.WixUIBack)" />
+                    <Control Id="Next" Type="PushButton" X="236" Y="243" Width="56" Height="17" Default="yes" Text="!(loc.WixUINext)" />
+                    <Control Id="Cancel" Type="PushButton" X="304" Y="243" Width="56" Height="17" Cancel="yes" Text="!(loc.WixUICancel)">
+                      <Publish Event="SpawnDialog" Value="CancelDlg">1</Publish>
+                    </Control>
                   </Dialog>
 
                   <Publish Dialog="LicenseAgreementDlg" Control="Next" Event="NewDialog" Value="ChooseWorkspacesDlg" Order="2">LicenseAccepted = "1"</Publish>

From ce64d19bffacb0a04240588d4fb996758037af73 Mon Sep 17 00:00:00 2001
From: Soubhagya Mohapatra <ssm.allrounder@gmail.com>
Date: Mon, 17 Mar 2025 21:49:28 +0530
Subject: [PATCH 07/25] complete the control action

---
 .github/workflows/build-windows-executable-app.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/.github/workflows/build-windows-executable-app.yaml b/.github/workflows/build-windows-executable-app.yaml
index f9df38603..22ec114bf 100644
--- a/.github/workflows/build-windows-executable-app.yaml
+++ b/.github/workflows/build-windows-executable-app.yaml
@@ -430,6 +430,8 @@ jobs:
                   <Publish Dialog="InstallDirDlg" Control="Back" Event="NewDialog" Value="ChooseWorkspacesDlg" Order="2">1</Publish>
                   <Publish Dialog="ChooseWorkspacesDlg" Control="Next" Event="NewDialog" Value="InstallDirDlg" Order="2">1</Publish>
                   <Publish Dialog="ChooseWorkspacesDlg" Control="Back" Event="NewDialog" Value="LicenseAgreementDlg" Order="2">1</Publish>
+                  <Publish Dialog="ChooseWorkspacesDlg" Control="ChangeFolder" Property="_BrowseProperty" Value="[WORKSPACES_FOLDER]" Order="2">1</Publish>
+                  <Publish Dialog="ChooseWorkspacesDlg" Control="ChangeFolder" Event="SpawnDialog" Value="BrowseDlg" Order="2">1</Publish>
             </UI> 
             <!-- Provide license; it should exist in the SourceDir folder -->
             <WixVariable Id="WixUILicenseRtf" Value="SourceDir/openms_license.rtf" />

From d23905195994e8b06e7e031c33d9cb282f8e0d27 Mon Sep 17 00:00:00 2001
From: Soubhagya Mohapatra <ssm.allrounder@gmail.com>
Date: Tue, 18 Mar 2025 10:26:07 +0530
Subject: [PATCH 08/25] select workspaces folder and write it into the txt file

---
 .../build-windows-executable-app.yaml         | 21 ++++++-------------
 1 file changed, 6 insertions(+), 15 deletions(-)

diff --git a/.github/workflows/build-windows-executable-app.yaml b/.github/workflows/build-windows-executable-app.yaml
index 22ec114bf..fa1d11d0f 100644
--- a/.github/workflows/build-windows-executable-app.yaml
+++ b/.github/workflows/build-windows-executable-app.yaml
@@ -384,22 +384,13 @@ jobs:
             <!-- Provide icon here; it should exist in the SourceDir folder -->
             <Icon Id="AppIcon" SourceFile="SourceDir/openms.ico" />
         
-            <!-- Run app directly after installation -->
-            <!-- <CustomAction Id="RunApp" Directory="AppSubFolder" Execute="deferred" Return="asyncNoWait" Impersonate="no"
-                          ExeCommand="cmd.exe /c &quot;[AppSubFolder]${{ env.APP_NAME }}.bat&quot;" /> -->
-            
-            <!-- Custom Action to Show Success Message -->
-            <Binary Id="ShowMessageScript" SourceFile="SourceDir/ShowSuccessMessage.vbs" />
-            <CustomAction Id="ShowSuccessMessage" BinaryKey="ShowMessageScript" VBScriptCall="" Execute="immediate" Return="check" />
-        
-            <!-- Add all Custom Actions -->
+            <!-- Custom Action: Write WORKSPACES_FOLDER to a text file -->
+            <CustomAction Id="WriteWorkspacePath" Directory="INSTALLFOLDER" Execute="deferred" Impersonate="no" ExeCommand="cmd.exe /c echo [WORKSPACES_FOLDER] > [INSTALLFOLDER]\workspace_path.txt" Return="ignore" />
+
             <InstallExecuteSequence>
-              <!-- Custom action display success message -->
-              <Custom Action="ShowSuccessMessage" After="InstallFinalize">NOT Installed</Custom>
-              <!-- Run app directly after installation -->
-              <!-- <Custom Action="RunApp" Before="InstallFinalize">NOT REMOVE</Custom> -->
+              <Custom Action="WriteWorkspacePath" After="InstallFinalize">NOT Installed</Custom>
             </InstallExecuteSequence>
-        
+
             <!-- Interface options -->
             <UI>
                   <UIRef Id="WixUI_InstallDir" />
@@ -408,7 +399,7 @@ jobs:
                   <!-- New Dialog to select workspaces -->
                   <Dialog Id="ChooseWorkspacesDlg" Width="370" Height="270" Title="!(loc.InstallDirDlg_Title)">
                     <Control Id="Description" Type="Text" X="25" Y="23" Width="280" Height="15" Transparent="yes" NoPrefix="yes" Text="Click Next to choose default workspaces location or click Change to choose another folder" />
-                    <Control Id="Title" Type="Text" X="15" Y="6" Width="200" Height="15" Transparent="yes" NoPrefix="yes" Text="Workspaces Folder" />
+                    <Control Id="Title" Type="Text" X="15" Y="6" Width="200" Height="15" Transparent="yes" NoPrefix="yes" Text="{\WixUI_Font_Title}Workspaces Folder" />
                     <Control Id="BannerBitmap" Type="Bitmap" X="0" Y="0" Width="370" Height="44" TabSkip="no" Text="!(loc.InstallDirDlgBannerBitmap)" />
                     <Control Id="BannerLine" Type="Line" X="0" Y="44" Width="370" Height="0" />
                     <Control Id="BottomLine" Type="Line" X="0" Y="234" Width="370" Height="0" />

From 525698919acb96e871c2b80c8d1dd2ee7ca46e9a Mon Sep 17 00:00:00 2001
From: Soubhagya Mohapatra <ssm.allrounder@gmail.com>
Date: Tue, 18 Mar 2025 11:09:00 +0530
Subject: [PATCH 09/25] make it before

---
 .github/workflows/build-windows-executable-app.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/build-windows-executable-app.yaml b/.github/workflows/build-windows-executable-app.yaml
index fa1d11d0f..9bbf42887 100644
--- a/.github/workflows/build-windows-executable-app.yaml
+++ b/.github/workflows/build-windows-executable-app.yaml
@@ -388,7 +388,7 @@ jobs:
             <CustomAction Id="WriteWorkspacePath" Directory="INSTALLFOLDER" Execute="deferred" Impersonate="no" ExeCommand="cmd.exe /c echo [WORKSPACES_FOLDER] > [INSTALLFOLDER]\workspace_path.txt" Return="ignore" />
 
             <InstallExecuteSequence>
-              <Custom Action="WriteWorkspacePath" After="InstallFinalize">NOT Installed</Custom>
+              <Custom Action="WriteWorkspacePath" Before="InstallFinalize">NOT Installed</Custom>
             </InstallExecuteSequence>
 
             <!-- Interface options -->

From f3c8a1632d21a71cbece1e90b2eb678d9fc83448 Mon Sep 17 00:00:00 2001
From: Soubhagya Mohapatra <ssm.allrounder@gmail.com>
Date: Tue, 18 Mar 2025 12:31:31 +0530
Subject: [PATCH 10/25] write properly to txt file

---
 .github/workflows/build-windows-executable-app.yaml | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/build-windows-executable-app.yaml b/.github/workflows/build-windows-executable-app.yaml
index 9bbf42887..c19f4fae9 100644
--- a/.github/workflows/build-windows-executable-app.yaml
+++ b/.github/workflows/build-windows-executable-app.yaml
@@ -385,7 +385,7 @@ jobs:
             <Icon Id="AppIcon" SourceFile="SourceDir/openms.ico" />
         
             <!-- Custom Action: Write WORKSPACES_FOLDER to a text file -->
-            <CustomAction Id="WriteWorkspacePath" Directory="INSTALLFOLDER" Execute="deferred" Impersonate="no" ExeCommand="cmd.exe /c echo [WORKSPACES_FOLDER] > [INSTALLFOLDER]\workspace_path.txt" Return="ignore" />
+            <CustomAction Id="WriteWorkspacePath" Directory="INSTALLFOLDER" Execute="deferred" Impersonate="no" ExeCommand="cmd.exe /c echo [WORKSPACES_FOLDER] > [INSTALLFOLDER]workspace_path.txt" Return="ignore" />
 
             <InstallExecuteSequence>
               <Custom Action="WriteWorkspacePath" Before="InstallFinalize">NOT Installed</Custom>
@@ -405,9 +405,9 @@ jobs:
                     <Control Id="BottomLine" Type="Line" X="0" Y="234" Width="370" Height="0" />
 
                     <!-- Browse for workspaces folder location -->
-                    <Control Id="FolderLabel" Type="Text" X="20" Y="60" Width="290" Height="30" NoPrefix="yes" Text="Please select a workspace location before continuing installation." />
-                    <Control Id="Folder" Type="PathEdit" X="20" Y="100" Width="320" Height="18" Property="WORKSPACES_FOLDER" Indirect="yes" />
-                    <Control Id="ChangeFolder" Type="PushButton" X="20" Y="120" Width="56" Height="17" Text="Change" />
+                    <Control Id="WorkspacesFolderLabel" Type="Text" X="20" Y="60" Width="290" Height="30" NoPrefix="yes" Text="Please select a workspace location before continuing installation." />
+                    <Control Id="WorkspacesFolder" Type="PathEdit" X="20" Y="100" Width="320" Height="18" Property="WORKSPACES_FOLDER" Indirect="yes" />
+                    <Control Id="ChangeWorkspacesFolder" Type="PushButton" X="20" Y="120" Width="56" Height="17" Text="Change" />
 
                     <!-- Navigation Buttons -->
                     <Control Id="Back" Type="PushButton" X="180" Y="243" Width="56" Height="17" Cancel="yes" Text="!(loc.WixUIBack)" />
@@ -421,8 +421,8 @@ jobs:
                   <Publish Dialog="InstallDirDlg" Control="Back" Event="NewDialog" Value="ChooseWorkspacesDlg" Order="2">1</Publish>
                   <Publish Dialog="ChooseWorkspacesDlg" Control="Next" Event="NewDialog" Value="InstallDirDlg" Order="2">1</Publish>
                   <Publish Dialog="ChooseWorkspacesDlg" Control="Back" Event="NewDialog" Value="LicenseAgreementDlg" Order="2">1</Publish>
-                  <Publish Dialog="ChooseWorkspacesDlg" Control="ChangeFolder" Property="_BrowseProperty" Value="[WORKSPACES_FOLDER]" Order="2">1</Publish>
-                  <Publish Dialog="ChooseWorkspacesDlg" Control="ChangeFolder" Event="SpawnDialog" Value="BrowseDlg" Order="2">1</Publish>
+                  <Publish Dialog="ChooseWorkspacesDlg" Control="ChangeWorkspacesFolder" Property="_BrowseProperty" Value="[WORKSPACES_FOLDER]" Order="2">1</Publish>
+                  <Publish Dialog="ChooseWorkspacesDlg" Control="ChangeWorkspacesFolder" Event="SpawnDialog" Value="BrowseDlg" Order="2">1</Publish>
             </UI> 
             <!-- Provide license; it should exist in the SourceDir folder -->
             <WixVariable Id="WixUILicenseRtf" Value="SourceDir/openms_license.rtf" />

From e94fae94fbd0003c6f0bbf49a1b1c7faa3e5dc00 Mon Sep 17 00:00:00 2001
From: Soubhagya Mohapatra <ssm.allrounder@gmail.com>
Date: Tue, 18 Mar 2025 15:37:41 +0530
Subject: [PATCH 11/25] fix same variable reference

---
 .github/workflows/build-windows-executable-app.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/build-windows-executable-app.yaml b/.github/workflows/build-windows-executable-app.yaml
index c19f4fae9..1d6527d8a 100644
--- a/.github/workflows/build-windows-executable-app.yaml
+++ b/.github/workflows/build-windows-executable-app.yaml
@@ -346,7 +346,6 @@ jobs:
         
             <!-- Folder structure -->
             <Property Id="WIXUI_INSTALLDIR" Value="INSTALLFOLDER" />
-            <Property Id="WORKSPACES_FOLDER" Value="INSTALLFOLDER" />
             <Directory Id="TARGETDIR" Name="SourceDir">
               <Directory Id="ProgramFilesFolder"> 
                 <Directory Id="INSTALLFOLDER" Name="${{ env.APP_NAME }}">
@@ -360,6 +359,7 @@ jobs:
               </Directory>
               <Directory Id="DesktopFolder" />
             </Directory>
+            <Property Id="WORKSPACES_FOLDER" Value="[INSTALLFOLDER][AppSubFolder]" />
         
             <!-- Add components -->
             <Feature Id="MainFeature" Title="Main Application" Level="1">

From f0bc0470d62e8e888c65a9d17e61edc67e9d7c7b Mon Sep 17 00:00:00 2001
From: Soubhagya Mohapatra <ssm.allrounder@gmail.com>
Date: Tue, 18 Mar 2025 16:21:15 +0530
Subject: [PATCH 12/25] concat

---
 .github/workflows/build-windows-executable-app.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/build-windows-executable-app.yaml b/.github/workflows/build-windows-executable-app.yaml
index 1d6527d8a..4af0c4f35 100644
--- a/.github/workflows/build-windows-executable-app.yaml
+++ b/.github/workflows/build-windows-executable-app.yaml
@@ -359,7 +359,7 @@ jobs:
               </Directory>
               <Directory Id="DesktopFolder" />
             </Directory>
-            <Property Id="WORKSPACES_FOLDER" Value="[INSTALLFOLDER][AppSubFolder]" />
+            <Property Id="WORKSPACES_FOLDER" Value="[INSTALLFOLDER]\[AppSubFolder]" />
         
             <!-- Add components -->
             <Feature Id="MainFeature" Title="Main Application" Level="1">

From 9941e565e0c641bb08669b15103f4600c2298fcd Mon Sep 17 00:00:00 2001
From: Soubhagya Mohapatra <ssm.allrounder@gmail.com>
Date: Tue, 18 Mar 2025 17:44:22 +0530
Subject: [PATCH 13/25] use app subfolder

---
 .../workflows/build-windows-executable-app.yaml | 17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/build-windows-executable-app.yaml b/.github/workflows/build-windows-executable-app.yaml
index 4af0c4f35..69b164d44 100644
--- a/.github/workflows/build-windows-executable-app.yaml
+++ b/.github/workflows/build-windows-executable-app.yaml
@@ -359,7 +359,7 @@ jobs:
               </Directory>
               <Directory Id="DesktopFolder" />
             </Directory>
-            <Property Id="WORKSPACES_FOLDER" Value="[INSTALLFOLDER]\[AppSubFolder]" />
+            <Property Id="WORKSPACES_FOLDER" Value="[AppSubFolder]" />
         
             <!-- Add components -->
             <Feature Id="MainFeature" Title="Main Application" Level="1">
@@ -384,10 +384,23 @@ jobs:
             <!-- Provide icon here; it should exist in the SourceDir folder -->
             <Icon Id="AppIcon" SourceFile="SourceDir/openms.ico" />
         
+            <!-- Run app directly after installation -->
+            <!-- <CustomAction Id="RunApp" Directory="AppSubFolder" Execute="deferred" Return="asyncNoWait" Impersonate="no"
+                          ExeCommand="cmd.exe /c &quot;[AppSubFolder]${{ env.APP_NAME }}.bat&quot;" /> -->
+            
+            <!-- Custom Action to Show Success Message -->
+            <Binary Id="ShowMessageScript" SourceFile="SourceDir/ShowSuccessMessage.vbs" />
+            <CustomAction Id="ShowSuccessMessage" BinaryKey="ShowMessageScript" VBScriptCall="" Execute="immediate" Return="check" />
+        
             <!-- Custom Action: Write WORKSPACES_FOLDER to a text file -->
-            <CustomAction Id="WriteWorkspacePath" Directory="INSTALLFOLDER" Execute="deferred" Impersonate="no" ExeCommand="cmd.exe /c echo [WORKSPACES_FOLDER] > [INSTALLFOLDER]workspace_path.txt" Return="ignore" />
+            <CustomAction Id="WriteWorkspacePath" Directory="INSTALLFOLDER" Execute="deferred" Impersonate="no" ExeCommand="cmd.exe /c echo [WORKSPACES_FOLDER] > [AppSubFolder]workspace_path.txt" Return="ignore" />
 
+            <!-- Add all Custom Actions -->
             <InstallExecuteSequence>
+              <!-- Custom action display success message -->
+              <Custom Action="ShowSuccessMessage" After="InstallFinalize">NOT Installed</Custom>
+              <!-- Run app directly after installation -->
+              <!-- <Custom Action="RunApp" Before="InstallFinalize">NOT REMOVE</Custom> -->
               <Custom Action="WriteWorkspacePath" Before="InstallFinalize">NOT Installed</Custom>
             </InstallExecuteSequence>
 

From b3837d9f8a2bee29bb2c0f1f037b813fff81dcc1 Mon Sep 17 00:00:00 2001
From: Soubhagya Mohapatra <ssm.allrounder@gmail.com>
Date: Tue, 18 Mar 2025 18:53:46 +0530
Subject: [PATCH 14/25] one more try

---
 .github/workflows/build-windows-executable-app.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/build-windows-executable-app.yaml b/.github/workflows/build-windows-executable-app.yaml
index 69b164d44..fca27bd4b 100644
--- a/.github/workflows/build-windows-executable-app.yaml
+++ b/.github/workflows/build-windows-executable-app.yaml
@@ -359,7 +359,7 @@ jobs:
               </Directory>
               <Directory Id="DesktopFolder" />
             </Directory>
-            <Property Id="WORKSPACES_FOLDER" Value="[AppSubFolder]" />
+            <Property Id="WORKSPACES_FOLDER" Value="[INSTALLFOLDER]" />
         
             <!-- Add components -->
             <Feature Id="MainFeature" Title="Main Application" Level="1">

From 32f0ae47f43746a404a65769f1cb68c4e29670f4 Mon Sep 17 00:00:00 2001
From: Soubhagya Mohapatra <ssm.allrounder@gmail.com>
Date: Tue, 18 Mar 2025 22:42:13 +0530
Subject: [PATCH 15/25] use app sub folder

---
 .github/workflows/build-windows-executable-app.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/build-windows-executable-app.yaml b/.github/workflows/build-windows-executable-app.yaml
index fca27bd4b..7d4e25cdb 100644
--- a/.github/workflows/build-windows-executable-app.yaml
+++ b/.github/workflows/build-windows-executable-app.yaml
@@ -359,7 +359,7 @@ jobs:
               </Directory>
               <Directory Id="DesktopFolder" />
             </Directory>
-            <Property Id="WORKSPACES_FOLDER" Value="[INSTALLFOLDER]" />
+            <Property Id="WORKSPACES_FOLDER" Value="AppSubFolder" />
         
             <!-- Add components -->
             <Feature Id="MainFeature" Title="Main Application" Level="1">

From 69ce2efc767d97fc35607b0a72f3594800fffb0b Mon Sep 17 00:00:00 2001
From: Soubhagya Mohapatra <ssm.allrounder@gmail.com>
Date: Wed, 19 Mar 2025 00:11:47 +0530
Subject: [PATCH 16/25] one more change to write to the right file

---
 .github/workflows/build-windows-executable-app.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/build-windows-executable-app.yaml b/.github/workflows/build-windows-executable-app.yaml
index 7d4e25cdb..4aaec8401 100644
--- a/.github/workflows/build-windows-executable-app.yaml
+++ b/.github/workflows/build-windows-executable-app.yaml
@@ -393,7 +393,7 @@ jobs:
             <CustomAction Id="ShowSuccessMessage" BinaryKey="ShowMessageScript" VBScriptCall="" Execute="immediate" Return="check" />
         
             <!-- Custom Action: Write WORKSPACES_FOLDER to a text file -->
-            <CustomAction Id="WriteWorkspacePath" Directory="INSTALLFOLDER" Execute="deferred" Impersonate="no" ExeCommand="cmd.exe /c echo [WORKSPACES_FOLDER] > [AppSubFolder]workspace_path.txt" Return="ignore" />
+            <CustomAction Id="WriteWorkspacePath" Directory="INSTALLFOLDER" Execute="deferred" Impersonate="no" ExeCommand="cmd.exe /c echo [WORKSPACES_FOLDER] > &quot;[AppSubFolder]workspace_path.txt&quot;" Return="ignore" />
 
             <!-- Add all Custom Actions -->
             <InstallExecuteSequence>

From be26f7d073497906a9ef85b57d0549c60455dc2b Mon Sep 17 00:00:00 2001
From: Soubhagya Mohapatra <ssm.allrounder@gmail.com>
Date: Wed, 19 Mar 2025 08:23:45 +0530
Subject: [PATCH 17/25] add quotes for value to be written

---
 .github/workflows/build-windows-executable-app.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/build-windows-executable-app.yaml b/.github/workflows/build-windows-executable-app.yaml
index 4aaec8401..a3c4894ac 100644
--- a/.github/workflows/build-windows-executable-app.yaml
+++ b/.github/workflows/build-windows-executable-app.yaml
@@ -393,7 +393,7 @@ jobs:
             <CustomAction Id="ShowSuccessMessage" BinaryKey="ShowMessageScript" VBScriptCall="" Execute="immediate" Return="check" />
         
             <!-- Custom Action: Write WORKSPACES_FOLDER to a text file -->
-            <CustomAction Id="WriteWorkspacePath" Directory="INSTALLFOLDER" Execute="deferred" Impersonate="no" ExeCommand="cmd.exe /c echo [WORKSPACES_FOLDER] > &quot;[AppSubFolder]workspace_path.txt&quot;" Return="ignore" />
+            <CustomAction Id="WriteWorkspacePath" Directory="INSTALLFOLDER" Execute="deferred" Impersonate="no" ExeCommand="cmd.exe /c echo &quot;[WORKSPACES_FOLDER]&quot; > &quot;[AppSubFolder]workspace_path.txt&quot;" Return="ignore" />
 
             <!-- Add all Custom Actions -->
             <InstallExecuteSequence>

From c841978e983f5f02003eaf812a82a6717a637e21 Mon Sep 17 00:00:00 2001
From: Soubhagya Mohapatra <ssm.allrounder@gmail.com>
Date: Wed, 19 Mar 2025 09:56:36 +0530
Subject: [PATCH 18/25] use code rabbit suggestion

---
 .github/workflows/build-windows-executable-app.yaml | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/build-windows-executable-app.yaml b/.github/workflows/build-windows-executable-app.yaml
index a3c4894ac..1659df40a 100644
--- a/.github/workflows/build-windows-executable-app.yaml
+++ b/.github/workflows/build-windows-executable-app.yaml
@@ -393,8 +393,9 @@ jobs:
             <CustomAction Id="ShowSuccessMessage" BinaryKey="ShowMessageScript" VBScriptCall="" Execute="immediate" Return="check" />
         
             <!-- Custom Action: Write WORKSPACES_FOLDER to a text file -->
-            <CustomAction Id="WriteWorkspacePath" Directory="INSTALLFOLDER" Execute="deferred" Impersonate="no" ExeCommand="cmd.exe /c echo &quot;[WORKSPACES_FOLDER]&quot; > &quot;[AppSubFolder]workspace_path.txt&quot;" Return="ignore" />
-
+            <CustomAction Id="WriteWorkspacePath" Directory="INSTALLFOLDER" Execute="deferred" Impersonate="no" 
+              ExeCommand="powershell.exe -NoProfile -ExecutionPolicy Bypass -Command &quot;$settingsPath='[AppSubFolder]settings.json'; $settings = Get-Content -Raw $settingsPath | ConvertFrom-Json; $settings.workspaces_dir = '[WORKSPACES_FOLDER]'; $settings | ConvertTo-Json -Depth 100 | Set-Content $settingsPath&quot;" 
+              Return="check" />
             <!-- Add all Custom Actions -->
             <InstallExecuteSequence>
               <!-- Custom action display success message -->

From 47e83d809450bb59a12d2e8c69a3d1504a2e304d Mon Sep 17 00:00:00 2001
From: Soubhagya Mohapatra <ssm.allrounder@gmail.com>
Date: Wed, 19 Mar 2025 11:27:07 +0530
Subject: [PATCH 19/25] more changes

---
 .github/workflows/build-windows-executable-app.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/build-windows-executable-app.yaml b/.github/workflows/build-windows-executable-app.yaml
index 1659df40a..6c63b93c8 100644
--- a/.github/workflows/build-windows-executable-app.yaml
+++ b/.github/workflows/build-windows-executable-app.yaml
@@ -393,8 +393,8 @@ jobs:
             <CustomAction Id="ShowSuccessMessage" BinaryKey="ShowMessageScript" VBScriptCall="" Execute="immediate" Return="check" />
         
             <!-- Custom Action: Write WORKSPACES_FOLDER to a text file -->
-            <CustomAction Id="WriteWorkspacePath" Directory="INSTALLFOLDER" Execute="deferred" Impersonate="no" 
-              ExeCommand="powershell.exe -NoProfile -ExecutionPolicy Bypass -Command &quot;$settingsPath='[AppSubFolder]settings.json'; $settings = Get-Content -Raw $settingsPath | ConvertFrom-Json; $settings.workspaces_dir = '[WORKSPACES_FOLDER]'; $settings | ConvertTo-Json -Depth 100 | Set-Content $settingsPath&quot;" 
+           <CustomAction Id="WriteWorkspacePath" Directory="INSTALLFOLDER" Execute="deferred" Impersonate="no" 
+              ExeCommand="powershell.exe -NoProfile -ExecutionPolicy Bypass -Command &quot;&amp;{$settingsPath='[AppSubFolder]settings.json'; $settings = Get-Content -Raw $settingsPath | ConvertFrom-Json; $settings.workspaces_dir = '[WORKSPACES_FOLDER]'; $settings | ConvertTo-Json -Depth 100 | Set-Content $settingsPath}&quot;" 
               Return="check" />
             <!-- Add all Custom Actions -->
             <InstallExecuteSequence>

From 5c9e766c2d322d807ab27b64f1a024843ac3c74f Mon Sep 17 00:00:00 2001
From: Soubhagya Mohapatra <ssm.allrounder@gmail.com>
Date: Wed, 19 Mar 2025 12:53:33 +0530
Subject: [PATCH 20/25] more changes

---
 .github/workflows/build-windows-executable-app.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/build-windows-executable-app.yaml b/.github/workflows/build-windows-executable-app.yaml
index 6c63b93c8..6644b260c 100644
--- a/.github/workflows/build-windows-executable-app.yaml
+++ b/.github/workflows/build-windows-executable-app.yaml
@@ -393,8 +393,8 @@ jobs:
             <CustomAction Id="ShowSuccessMessage" BinaryKey="ShowMessageScript" VBScriptCall="" Execute="immediate" Return="check" />
         
             <!-- Custom Action: Write WORKSPACES_FOLDER to a text file -->
-           <CustomAction Id="WriteWorkspacePath" Directory="INSTALLFOLDER" Execute="deferred" Impersonate="no" 
-              ExeCommand="powershell.exe -NoProfile -ExecutionPolicy Bypass -Command &quot;&amp;{$settingsPath='[AppSubFolder]settings.json'; $settings = Get-Content -Raw $settingsPath | ConvertFrom-Json; $settings.workspaces_dir = '[WORKSPACES_FOLDER]'; $settings | ConvertTo-Json -Depth 100 | Set-Content $settingsPath}&quot;" 
+            <CustomAction Id="WriteWorkspacePath" Directory="INSTALLFOLDER" Execute="deferred" Impersonate="no" 
+              ExeCommand="powershell.exe -NoProfile -ExecutionPolicy Bypass -Command &quot;&amp;{&dollar;settingsPath='[AppSubFolder]settings.json'; &dollar;settings = Get-Content -Raw &dollar;settingsPath | ConvertFrom-Json; &dollar;settings.workspaces_dir = '[WORKSPACES_FOLDER]'; &dollar;settings | ConvertTo-Json -Depth 100 | Set-Content &dollar;settingsPath}&quot;" 
               Return="check" />
             <!-- Add all Custom Actions -->
             <InstallExecuteSequence>

From 7930c5911082a4ef4b822dd8648364b973929b09 Mon Sep 17 00:00:00 2001
From: Soubhagya Mohapatra <ssm.allrounder@gmail.com>
Date: Wed, 19 Mar 2025 14:31:09 +0530
Subject: [PATCH 21/25] re-run build

---
 .github/workflows/build-windows-executable-app.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/build-windows-executable-app.yaml b/.github/workflows/build-windows-executable-app.yaml
index 6644b260c..0cccb08ec 100644
--- a/.github/workflows/build-windows-executable-app.yaml
+++ b/.github/workflows/build-windows-executable-app.yaml
@@ -392,7 +392,7 @@ jobs:
             <Binary Id="ShowMessageScript" SourceFile="SourceDir/ShowSuccessMessage.vbs" />
             <CustomAction Id="ShowSuccessMessage" BinaryKey="ShowMessageScript" VBScriptCall="" Execute="immediate" Return="check" />
         
-            <!-- Custom Action: Write WORKSPACES_FOLDER to a text file -->
+            <!-- Custom Action: Write WORKSPACES_FOLDER to settings file -->
             <CustomAction Id="WriteWorkspacePath" Directory="INSTALLFOLDER" Execute="deferred" Impersonate="no" 
               ExeCommand="powershell.exe -NoProfile -ExecutionPolicy Bypass -Command &quot;&amp;{&dollar;settingsPath='[AppSubFolder]settings.json'; &dollar;settings = Get-Content -Raw &dollar;settingsPath | ConvertFrom-Json; &dollar;settings.workspaces_dir = '[WORKSPACES_FOLDER]'; &dollar;settings | ConvertTo-Json -Depth 100 | Set-Content &dollar;settingsPath}&quot;" 
               Return="check" />

From b1ab02a0a54f8a14b8fe5fa1a8e9206dc8b9e038 Mon Sep 17 00:00:00 2001
From: Soubhagya Mohapatra <ssm.allrounder@gmail.com>
Date: Wed, 19 Mar 2025 20:21:05 +0530
Subject: [PATCH 22/25] use backticks

---
 .github/workflows/build-windows-executable-app.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/build-windows-executable-app.yaml b/.github/workflows/build-windows-executable-app.yaml
index 0cccb08ec..c9b0ab1e6 100644
--- a/.github/workflows/build-windows-executable-app.yaml
+++ b/.github/workflows/build-windows-executable-app.yaml
@@ -394,7 +394,7 @@ jobs:
         
             <!-- Custom Action: Write WORKSPACES_FOLDER to settings file -->
             <CustomAction Id="WriteWorkspacePath" Directory="INSTALLFOLDER" Execute="deferred" Impersonate="no" 
-              ExeCommand="powershell.exe -NoProfile -ExecutionPolicy Bypass -Command &quot;&amp;{&dollar;settingsPath='[AppSubFolder]settings.json'; &dollar;settings = Get-Content -Raw &dollar;settingsPath | ConvertFrom-Json; &dollar;settings.workspaces_dir = '[WORKSPACES_FOLDER]'; &dollar;settings | ConvertTo-Json -Depth 100 | Set-Content &dollar;settingsPath}&quot;" 
+              ExeCommand="powershell.exe -NoProfile -ExecutionPolicy Bypass -Command &quot;`$settingsPath='[AppSubFolder]settings.json'; `$settings = Get-Content -Raw `$settingsPath | ConvertFrom-Json; `$settings.workspaces_dir = '[WORKSPACES_FOLDER]'; `$settings | ConvertTo-Json -Depth 100 | Set-Content `$settingsPath&quot;" 
               Return="check" />
             <!-- Add all Custom Actions -->
             <InstallExecuteSequence>

From 4ce268c5aedd89df11bc1d3fc145963c2dc23efb Mon Sep 17 00:00:00 2001
From: Soubhagya Mohapatra <ssm.allrounder@gmail.com>
Date: Wed, 26 Mar 2025 15:56:07 +0530
Subject: [PATCH 23/25] try new approach:

---
 .../build-windows-executable-app.yaml         | 26 +++++++++++++++----
 1 file changed, 21 insertions(+), 5 deletions(-)

diff --git a/.github/workflows/build-windows-executable-app.yaml b/.github/workflows/build-windows-executable-app.yaml
index c9b0ab1e6..b33574487 100644
--- a/.github/workflows/build-windows-executable-app.yaml
+++ b/.github/workflows/build-windows-executable-app.yaml
@@ -392,17 +392,33 @@ jobs:
             <Binary Id="ShowMessageScript" SourceFile="SourceDir/ShowSuccessMessage.vbs" />
             <CustomAction Id="ShowSuccessMessage" BinaryKey="ShowMessageScript" VBScriptCall="" Execute="immediate" Return="check" />
         
-            <!-- Custom Action: Write WORKSPACES_FOLDER to settings file -->
-            <CustomAction Id="WriteWorkspacePath" Directory="INSTALLFOLDER" Execute="deferred" Impersonate="no" 
-              ExeCommand="powershell.exe -NoProfile -ExecutionPolicy Bypass -Command &quot;`$settingsPath='[AppSubFolder]settings.json'; `$settings = Get-Content -Raw `$settingsPath | ConvertFrom-Json; `$settings.workspaces_dir = '[WORKSPACES_FOLDER]'; `$settings | ConvertTo-Json -Depth 100 | Set-Content `$settingsPath&quot;" 
-              Return="check" />
+            <!-- Step 1: Pass variables to CustomActionData -->
+            <CustomAction Id="SetWriteWorkspacePathData"
+                          Property="WriteWorkspacePath"
+                          Value="AppSubFolder=[AppSubFolder];WORKSPACES_FOLDER=[WORKSPACES_FOLDER]" />
+
+            <!-- Step 2: Actual PowerShell inline script -->
+            <CustomAction Id="WriteWorkspacePath"
+                Directory="INSTALLFOLDER"
+                Execute="deferred"
+                Impersonate="no"
+                Return="check"
+                ExeCommand="powershell.exe -NoProfile -ExecutionPolicy Bypass -Command &quot;
+                  $props = @{}; ('[CustomActionData]' -split ';') | 
+                  ForEach-Object { $k,$v = $_ -split '=',2; $props[$k]=$v }; 
+                  $settingsPath = Join-Path $props.AppSubFolder 'settings.json'; 
+                  $settings = Get-Content -Raw -Path $settingsPath | ConvertFrom-Json; 
+                  $settings.workspaces_dir = $props.WORKSPACES_FOLDER; 
+                  $settings | ConvertTo-Json -Depth 100 | Set-Content -Path $settingsPath&quot;" />
+
             <!-- Add all Custom Actions -->
             <InstallExecuteSequence>
               <!-- Custom action display success message -->
               <Custom Action="ShowSuccessMessage" After="InstallFinalize">NOT Installed</Custom>
               <!-- Run app directly after installation -->
               <!-- <Custom Action="RunApp" Before="InstallFinalize">NOT REMOVE</Custom> -->
-              <Custom Action="WriteWorkspacePath" Before="InstallFinalize">NOT Installed</Custom>
+              <Custom Action="SetWriteWorkspacePathData" Before="WriteWorkspacePath">NOT Installed</Custom>
+              <Custom Action="WriteWorkspacePath"Before="InstallFinalize"">NOT Installed</Custom>
             </InstallExecuteSequence>
 
             <!-- Interface options -->

From 6044d817092ee3a029a0a4d081582e75b20ea381 Mon Sep 17 00:00:00 2001
From: Soubhagya Mohapatra <ssm.allrounder@gmail.com>
Date: Wed, 26 Mar 2025 16:26:05 +0530
Subject: [PATCH 24/25] add whitespace

---
 .github/workflows/build-windows-executable-app.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/build-windows-executable-app.yaml b/.github/workflows/build-windows-executable-app.yaml
index b33574487..43904ae63 100644
--- a/.github/workflows/build-windows-executable-app.yaml
+++ b/.github/workflows/build-windows-executable-app.yaml
@@ -418,7 +418,7 @@ jobs:
               <!-- Run app directly after installation -->
               <!-- <Custom Action="RunApp" Before="InstallFinalize">NOT REMOVE</Custom> -->
               <Custom Action="SetWriteWorkspacePathData" Before="WriteWorkspacePath">NOT Installed</Custom>
-              <Custom Action="WriteWorkspacePath"Before="InstallFinalize"">NOT Installed</Custom>
+              <Custom Action="WriteWorkspacePath" Before="InstallFinalize"">NOT Installed</Custom>
             </InstallExecuteSequence>
 
             <!-- Interface options -->

From 278e64eefd2cdd30d773f7b618d3e4c41567e493 Mon Sep 17 00:00:00 2001
From: Soubhagya Mohapatra <ssm.allrounder@gmail.com>
Date: Wed, 26 Mar 2025 17:20:00 +0530
Subject: [PATCH 25/25] remove unused quote

---
 .github/workflows/build-windows-executable-app.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/build-windows-executable-app.yaml b/.github/workflows/build-windows-executable-app.yaml
index 43904ae63..d90c6403a 100644
--- a/.github/workflows/build-windows-executable-app.yaml
+++ b/.github/workflows/build-windows-executable-app.yaml
@@ -418,7 +418,7 @@ jobs:
               <!-- Run app directly after installation -->
               <!-- <Custom Action="RunApp" Before="InstallFinalize">NOT REMOVE</Custom> -->
               <Custom Action="SetWriteWorkspacePathData" Before="WriteWorkspacePath">NOT Installed</Custom>
-              <Custom Action="WriteWorkspacePath" Before="InstallFinalize"">NOT Installed</Custom>
+              <Custom Action="WriteWorkspacePath" Before="InstallFinalize">NOT Installed</Custom>
             </InstallExecuteSequence>
 
             <!-- Interface options -->