From 0b55306ce32f82669808e40c0bcabdd489a504ce Mon Sep 17 00:00:00 2001 From: Tom David Mueller Date: Sat, 1 Feb 2025 17:12:12 +0100 Subject: [PATCH 1/5] enable test and apply fixes to cab --- .github/workflows/test-win-exe-w-embed-py.yaml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test-win-exe-w-embed-py.yaml b/.github/workflows/test-win-exe-w-embed-py.yaml index 3af5f5231..597f30080 100644 --- a/.github/workflows/test-win-exe-w-embed-py.yaml +++ b/.github/workflows/test-win-exe-w-embed-py.yaml @@ -2,6 +2,8 @@ name: Test streamlit executable for Windows with embeddable python on: push: branches: [ "main" ] + pull_request: + branches: [ "main" ] workflow_dispatch: jobs: @@ -118,7 +120,7 @@ jobs: - + @@ -193,7 +195,7 @@ jobs: - name: Link .wixobj file into .msi with light.exe run: | - ./wix/light.exe -ext WixUIExtension -sice:ICE60 -o ${{ env.APP_NAME }}.msi streamlit_exe_files.wixobj streamlit_exe.wixobj + ./wix/light.exe -ext WixUIExtension -sice:ICE60 -o ${{ env.APP_NAME }}.msi streamlit_exe_files.wixobj streamlit_exe.wixobj -b SourceDir - name: Archive build artifacts uses: actions/upload-artifact@v4 From fe2220a13e1c980c3f5b77d1e5204f006511012c Mon Sep 17 00:00:00 2001 From: Tom David Mueller Date: Fri, 31 Jan 2025 14:32:44 +0100 Subject: [PATCH 2/5] distribute data across multiple cab files --- .github/workflows/build-windows-executable-app.yaml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build-windows-executable-app.yaml b/.github/workflows/build-windows-executable-app.yaml index cebe29c29..33c5f2aee 100644 --- a/.github/workflows/build-windows-executable-app.yaml +++ b/.github/workflows/build-windows-executable-app.yaml @@ -321,7 +321,9 @@ jobs: - + + + @@ -396,7 +398,7 @@ jobs: - name: Link .wixobj file into .msi with light.exe run: | - ./wix/light.exe -ext WixUIExtension -sice:ICE60 -o ${{ env.APP_NAME }}.msi streamlit_exe_files.wixobj streamlit_exe.wixobj + ./wix/light.exe -ext WixUIExtension -sice:ICE60 -o ${{ env.APP_NAME }}.msi streamlit_exe_files.wixobj streamlit_exe.wixobj -b SourceDir - name: Compress Installer run: | From 68f5cda0585f28c77a1190be637a91a90735a0fe Mon Sep 17 00:00:00 2001 From: Tom David Mueller Date: Fri, 31 Jan 2025 16:27:51 +0100 Subject: [PATCH 3/5] change naming scheme --- .github/workflows/build-windows-executable-app.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build-windows-executable-app.yaml b/.github/workflows/build-windows-executable-app.yaml index 33c5f2aee..454f83155 100644 --- a/.github/workflows/build-windows-executable-app.yaml +++ b/.github/workflows/build-windows-executable-app.yaml @@ -321,9 +321,9 @@ jobs: - - - + + + From f5f12ba6d0683d89154fdf9d5ba5c2da3d7b0b5b Mon Sep 17 00:00:00 2001 From: axelwalter Date: Sat, 1 Feb 2025 08:42:43 +0100 Subject: [PATCH 4/5] split into multiple cab files automatically --- .github/workflows/build-windows-executable-app.yaml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/build-windows-executable-app.yaml b/.github/workflows/build-windows-executable-app.yaml index 454f83155..f745d360c 100644 --- a/.github/workflows/build-windows-executable-app.yaml +++ b/.github/workflows/build-windows-executable-app.yaml @@ -321,9 +321,7 @@ jobs: - - - + From 2c788c1010691eaf0c50124e02363f47d6e4f055 Mon Sep 17 00:00:00 2001 From: Arslan Siraj Date: Wed, 5 Mar 2025 10:45:56 +0100 Subject: [PATCH 5/5] keep with workflow_dispatch:: Update test-win-exe-w-embed-py.yaml --- .github/workflows/test-win-exe-w-embed-py.yaml | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/.github/workflows/test-win-exe-w-embed-py.yaml b/.github/workflows/test-win-exe-w-embed-py.yaml index 597f30080..6d63ccbbe 100644 --- a/.github/workflows/test-win-exe-w-embed-py.yaml +++ b/.github/workflows/test-win-exe-w-embed-py.yaml @@ -1,9 +1,5 @@ name: Test streamlit executable for Windows with embeddable python on: - push: - branches: [ "main" ] - pull_request: - branches: [ "main" ] workflow_dispatch: jobs: @@ -202,4 +198,4 @@ jobs: with: name: OpenMS-App-Test path: | - ${{ env.APP_NAME }}.msi \ No newline at end of file + ${{ env.APP_NAME }}.msi