oiecommand hangs after failed login attempt

[VillePekka]

Thank you for creating and working on this fork!

When logging in with wrong password a stacktrace is printed and the process stays running. A suggestion is to print message "Login failed, please try again" or something similar and stop the process.

Behaviour was reproduced on Ubuntu 24.04 with at the moment newest release of OIE, V4.5.2.

Steps to reproduce the behaviour:

1. Download newest release: $ wget https://github.com/OpenIntegrationEngine/engine/releases/download/v4.5.2/oie_unix_4_5_2-with-JRE.sh
2. Make it executable
   $ chmod u+x oie_unix_4_5_2-with-JRE.sh
3. run the installer
   $ sudo ./oie_unix_4_5_2-with-JRE.sh
4. Start oieservice
   $ sudo oieservice start
5. Check oieservice is running
   $ sudo oieservice status
6. try to login with wrong password
   $ oiecommand -a https://localhost:8443 -u admin -p admin2
7. A stacktrace is printed

com.mirth.connect.client.core.UnauthorizedException: HTTP/1.1 401 Unauthorized
at com.mirth.connect.client.core.ServerConnection.handleResponse(ServerConnection.java:481)
at com.mirth.connect.client.core.ServerConnection.executeSync(ServerConnection.java:257)
at com.mirth.connect.client.core.ServerConnection.apply(ServerConnection.java:167)
at org.glassfish.jersey.client.ClientRuntime.invoke(ClientRuntime.java:255)
at org.glassfish.jersey.client.JerseyInvocation$3.call(JerseyInvocation.java:722)
at org.glassfish.jersey.internal.Errors.process(Errors.java:315)
at org.glassfish.jersey.internal.Errors.process(Errors.java:297)
at org.glassfish.jersey.internal.Errors.process(Errors.java:228)
at org.glassfish.jersey.process.internal.RequestScope.runInScope(RequestScope.java:444)
at org.glassfish.jersey.client.JerseyInvocation.invoke(JerseyInvocation.java:718)
at org.glassfish.jersey.client.JerseyInvocation$Builder.method(JerseyInvocation.java:459)
at org.glassfish.jersey.client.proxy.WebResourceFactory.invoke(WebResourceFactory.java:379)
at jdk.proxy3/jdk.proxy3.$Proxy25.login(Unknown Source)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:569)
at com.mirth.connect.client.core.Client$2.invoke(Client.java:273)
at jdk.proxy3/jdk.proxy3.$Proxy25.login(Unknown Source)
at com.mirth.connect.client.core.Client.login(Client.java:338)
at com.mirth.connect.cli.CommandLineInterface.runShell(CommandLineInterface.java:182)
at com.mirth.connect.cli.CommandLineInterface.run(CommandLineInterface.java:165)
at com.mirth.connect.cli.CommandLineInterface.(CommandLineInterface.java:108)
at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)
at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:481)
at com.mirth.connect.cli.launcher.CommandLineLauncher.main(CommandLineLauncher.java:71)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:569)
at com.exe4j.runtime.LauncherEngine.launch(LauncherEngine.java:84)
at com.install4j.runtime.launcher.UnixLauncher.start(UnixLauncher.java:71)
at install4j.com.mirth.connect.cli.launcher.CommandLineLauncher.main(Unknown Source)

[tonygermano]

Confirmed. When a login fails, it returns the failed LoginStatus with a 401 http status code. The GUI login actually checks for a thrown UnauthorizedException

engine/client/src/com/mirth/connect/client/ui/LoginPanel.java

Lines 434 to 443 in eb36362

	loginStatus = client.getServlet(UserServletInterface.class, null, customHeaders).login(username.getText(), String.valueOf(password.getPassword()));
	} catch (ClientException ex) {
	ex.printStackTrace();
	if (ex instanceof UnauthorizedException) {
	UnauthorizedException e2 = (UnauthorizedException) ex;
	if (e2.getResponse() != null && e2.getResponse() instanceof LoginStatus) {
	loginStatus = (LoginStatus) e2.getResponse();
	}
	}

whereas the cli just checks for the failed status in the happy path

engine/command/src/com/mirth/connect/cli/CommandLineInterface.java

Lines 182 to 187 in eb36362

	LoginStatus loginStatus = client.login(user, password);
	if (loginStatus.getStatus() != LoginStatus.Status.SUCCESS) {
	error("Could not login to server.", null);
	return;
	}