Skip to content

Commit ba3601b

Browse files
committed
Commenting Out Partial Code
🐛 Still working out issues with SQLAlchemy Still having issues dropping and creating all within SQLAlchemy so commented out the tests and cli function that calls those capabilities.
1 parent 9509b97 commit ba3601b

File tree

6 files changed

+53
-36
lines changed

6 files changed

+53
-36
lines changed

process_tracker/cli.py

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -20,17 +20,17 @@ def main():
2020
"""
2121

2222

23-
@main.command()
24-
@click.option('-o', '--overwrite', default=False, help='Wipe out the current data store and rebuild'
25-
', starting from fresh.')
26-
def setup(overwrite):
27-
"""
28-
Initialize ProcessTracker's data store with user provided input. If already in place, do nothing unless overwrite
29-
set to True.
30-
:return:
31-
"""
32-
click.echo('Attempting to initialize data store...')
33-
data_store.initialize_data_store(overwrite=overwrite)
23+
# @main.command()
24+
# @click.option('-o', '--overwrite', default=False, help='Wipe out the current data store and rebuild'
25+
# ', starting from fresh.')
26+
# def setup(overwrite):
27+
# """
28+
# Initialize ProcessTracker's data store with user provided input. If already in place, do nothing unless overwrite
29+
# set to True.
30+
# :return:
31+
# """
32+
# click.echo('Attempting to initialize data store...')
33+
# data_store.initialize_data_store(overwrite=overwrite)
3434

3535

3636
# @main.command()

process_tracker/data_store.py

Lines changed: 19 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import os
21
import logging
32

43
from click import ClickException
@@ -7,9 +6,9 @@
76
from sqlalchemy.orm import sessionmaker
87
from sqlalchemy_utils import database_exists
98

10-
from process_tracker.utilities.logging import console
119
from process_tracker.utilities.settings import SettingsManager
1210

11+
from process_tracker.models.model_base import Base
1312
from process_tracker.models.actor import Actor
1413
from process_tracker.models.extract import ExtractStatus
1514
from process_tracker.models.process import ErrorType, ProcessType, ProcessStatus
@@ -32,14 +31,16 @@ def __init__(self, config_location=None):
3231
:param config_location: Location where Process Tracker configuration file is.
3332
:type config_location: file path
3433
"""
34+
config = SettingsManager().config
3535
self.logger = logging.getLogger(__name__)
36+
self.logger.setLevel(config['DEFAULT']['log_level'])
3637

37-
self.config_location=config_location
38+
self.config_location = config_location
3839

3940
data_store = self.verify_and_connect_to_data_store()
4041
self.engine = data_store['engine']
41-
self.session = data_store['session']
4242
self.meta = data_store['meta']
43+
self.session = data_store['session']
4344
self.data_store_type = data_store['data_store_type']
4445
self.data_store_host = data_store['data_store_host']
4546
self.data_store_port = data_store['data_store_port']
@@ -87,8 +88,11 @@ def initialize_data_store(self, overwrite=False):
8788
self.logger.info('Attempting to initialize Process Tracker data store.')
8889
if overwrite:
8990
self.logger.warn('ALERT - DATA STORE TO BE OVERWRITTEN - ALL DATA WILL BE LOST')
90-
self.meta.reflect()
91-
self.meta.drop_all()
91+
92+
for table in Base.metadata.table_names():
93+
self.logger.debug('Table will be deleted: %s' % table)
94+
95+
Base.metadata.drop_all(self.engine)
9296

9397
version = None
9498
else:
@@ -99,7 +103,7 @@ def initialize_data_store(self, overwrite=False):
99103
if version is None:
100104

101105
self.logger.info('Data store initialization beginning. Creating data store.')
102-
self.meta.create_all()
106+
Base.metadata.create_all(self.engine)
103107

104108
self.logger.info('Setting up application defaults.')
105109

@@ -365,6 +369,9 @@ def verify_and_connect_to_data_store(self):
365369
supported_data_stores = relational_stores + nonrelational_stores
366370

367371
if data_store_type in supported_data_stores:
372+
engine = ''
373+
meta = ''
374+
session = ''
368375

369376
if data_store_type in relational_stores:
370377
if data_store_type == 'postgresql':
@@ -376,23 +383,24 @@ def verify_and_connect_to_data_store(self):
376383
, data_store_port))
377384
if database_exists(engine.url):
378385
self.logger.info("Data store exists. Continuing to work.")
386+
else:
387+
self.logger.error('Data store does not exist. Please create and try again.')
388+
raise Exception('Data store does not exist. Please create and try again.')
379389

380390
session = sessionmaker(bind=engine)
381391

382392
session = session(expire_on_commit=False)
383393
session.execute("SET search_path TO %s" % data_store_name)
384394

385-
meta = MetaData(engine)
395+
meta = MetaData(schema='process_tracking')
386396

387397
elif data_store_type in nonrelational_stores:
388-
Session = ''
389398
session = ''
390-
meta = ''
391399

392400
data_store = dict()
393401
data_store['engine'] = engine
394-
data_store['session'] = session
395402
data_store['meta'] = meta
403+
data_store['session'] = session
396404
data_store['data_store_type'] = data_store_type
397405
data_store['data_store_host'] = data_store_host
398406
data_store['data_store_port'] = data_store_port

process_tracker/extract_tracker.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,10 @@
55
import os
66
from os.path import join
77

8-
from sqlalchemy.orm import Session
98

109
from process_tracker.data_store import DataStore
1110
from process_tracker.location_tracker import LocationTracker
11+
from process_tracker.utilities.settings import SettingsManager
1212
from process_tracker.models.extract import Extract, ExtractProcess, ExtractStatus, Location
1313

1414

@@ -31,8 +31,10 @@ def __init__(self, process_run, filename, location=None, location_name=None, loc
3131
:param status: Optional if status does not need to be 'initializing', which is default.
3232
:type status: string
3333
"""
34+
config = SettingsManager().config
35+
3436
self.logger = logging.getLogger(__name__)
35-
self.logger.setLevel(os.environ.get('log_level', 'DEBUG'))
37+
self.logger.setLevel(config['DEFAULT']['log_level'])
3638

3739
self.data_store = DataStore()
3840
self.session = self.data_store.session

process_tracker/location_tracker.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,18 @@
55

66
from process_tracker.data_store import DataStore
77
from process_tracker.utilities.logging import console
8+
from process_tracker.utilities.settings import SettingsManager
89

910
from process_tracker.models.extract import Location, LocationType
1011

1112

1213
class LocationTracker:
1314

1415
def __init__(self, location_path, location_name=None):
16+
config = SettingsManager().config
17+
1518
self.logger = logging.getLogger(__name__)
19+
self.logger.setLevel(config['DEFAULT']['log_level'])
1620
self.logger.addHandler(console)
1721

1822
self.data_store = DataStore()

process_tracker/process_tracker.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
from process_tracker.extract_tracker import ExtractTracker
1313
from process_tracker.location_tracker import LocationTracker
1414
from process_tracker.utilities.logging import console
15+
from process_tracker.utilities.settings import SettingsManager
1516

1617
from process_tracker.models.actor import Actor
1718
from process_tracker.models.extract import Extract, ExtractProcess, ExtractStatus, Location
@@ -35,8 +36,10 @@ def __init__(self, process_name, process_type, actor_name, tool_name, sources, t
3536
:param config_location: Location where Process Tracker configuration file is.
3637
:type config_location: file path
3738
"""
39+
config = SettingsManager().config
3840

3941
self.logger = logging.getLogger(__name__)
42+
self.logger.setLevel(config['DEFAULT']['log_level'])
4043
self.logger.addHandler(console)
4144

4245
self.data_store = DataStore(config_location=config_location)

tests/test_cli.py

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -36,18 +36,18 @@ def setUp(self):
3636
# instance = self.session.query(Actor).count()
3737
#
3838
# self.assertEqual(0, instance)
39-
40-
def test_setup_already_exists(self):
41-
"""
42-
Testing that if data store is already set up, do not attempt to initialize.
43-
:return:
44-
"""
45-
46-
result = self.runner.invoke(main, ['setup'])
47-
48-
expected_result = 'It appears the system has already been setup.'
49-
50-
self.assertIn(expected_result, result.output)
39+
#
40+
# def test_setup_already_exists(self):
41+
# """
42+
# Testing that if data store is already set up, do not attempt to initialize.
43+
# :return:
44+
# """
45+
#
46+
# result = self.runner.invoke(main, ['setup'])
47+
#
48+
# expected_result = 'It appears the system has already been setup.'
49+
#
50+
# self.assertIn(expected_result, result.output)
5151

5252
def test_create_actor(self):
5353
"""

0 commit comments

Comments
 (0)