Configuring Coveralls

🐛 Coveralls over covering and including files made by Travis.

Trying to get coveralls to ignore travisci home/ dir from coverage as
it's not something that needs coverage.

Author: OpenDataAlex

.coveragerc

@@ -0,0 +1,3 @@
+[report]
+omit =
+    *home/*

process_tracker/extract_tracker.py

@@ -69,14 +69,9 @@ def __init__(self, process_run, filename, location=None, location_name=None, loc
 
         self.extract_process = self.retrieve_extract_process()
 
-        if status is not None and self.extract_status_types[status]:
-            self.logger.info('Setting extract status to %s' % status)
-            self.extract.extract_status_id = self.extract_status_types[status]
-            self.extract_process.extract_process_status_id = self.extract_status_types[status]
+        if status is not None:
+            self.change_extract_status(new_status=status)
         else:
-            if status is not None:
-                self.logger.error('Provided status %s is not in extract_status_types_lkup.  '
-                                  'Setting to initializing.' % status)
             self.extract.extract_status_id = self.extract_status_initializing
 
         self.session.commit()
@@ -86,10 +81,13 @@ def change_extract_status(self, new_status):
         Change an extract record status.
         :return:
         """
+
         status_date = datetime.now()
-        new_status = self.extract_status_types[new_status]
+        if new_status in self.extract_status_types:
+            self.logger.info('Setting extract status to %s' % new_status)
+
+            new_status = self.extract_status_types[new_status]
 
-        if new_status:
             self.extract.extract_status_id = new_status
 
             self.extract_process.extract_process_status_id = new_status

tests/test_extract_tracker.py

@@ -57,6 +57,19 @@ def tearDown(self):
         self.session.query(Location).delete()
         self.session.commit()
 
+    def test_initialization_no_location_no_location_path(self):
+        """
+        Testing that if no location or location path is set, an error is thrown.
+        :return:
+        """
+
+        with self.assertRaises(Exception) as context:
+            # Running registration a second time to mimic job being run twice
+            ExtractTracker(process_run=self.process_run
+                           , filename='test_extract_filename.csv')
+
+        return self.assertTrue('A location object or location_path must be provided.' in str(context.exception))
+
     def test_change_extract_status(self):
         """
         Testing that when changing the extract status, the extract record and extract process record updates
@@ -77,6 +90,19 @@ def test_change_extract_status(self):
 
         self.assertEqual(expected_result, given_result)
 
+    def test_change_extract_status_invalid_type(self):
+        """
+        When trying to change a extract's status and the status is an invalid type, throw and error.
+        :return:
+        """
+
+        with self.assertRaises(Exception) as context:
+            # Running registration a second time to mimic job being run twice
+            self.extract.change_extract_status(new_status='blarg')
+
+        return self.assertTrue('blarg is not a valid extract status type.  '
+                               'Please add the status to extract_status_lkup' in str(context.exception))
+
     def test_change_extract_status_initialization(self):
         """
         Testing that when the extract is first being worked on by a process, the status is set to 'initializing'