process_tracker_python-9 Process can have more than one source

✨ Process now can have more than one source.  Can also have more than one target

Finished testing of multiple sources/targets for given process.

Closes: #8 and #9

Author: OpenDataAlex

process_tracker/process_tracker.py

@@ -297,9 +297,8 @@ def register_process_sources(self, sources):
         :param sources: List of source name(s)
         :return: List of source objects.
         """
-        if sources != list:
+        if isinstance(sources, str):
             sources = [sources]
-
         source_list = []
 
         for source in sources:
@@ -317,19 +316,18 @@ def register_process_targets(self, targets):
         :param targets: List of source name(s)
         :return: List of source objects.
         """
-        if targets != list:
+        if isinstance(targets, str):
             targets = [targets]
-
-        source_list = []
+        target_list = []
 
         for target in targets:
             source = self.data_store.get_or_create(model=Source, source_name=target)
 
             self.data_store.get_or_create(model=ProcessTarget, target_source_id=source.source_id
                                           , process_id=self.process.process_id)
 
-            source_list.append(source)
-        return source_list
+            target_list.append(source)
+        return target_list
 
     def set_process_run_low_high_dates(self, low_date=None, high_date=None):
         """

tests/test_process_tracker.py

@@ -405,24 +405,70 @@ def test_register_process_sources_one_source(self):
         Testing that when a new process is registered, a source registered as well.
         :return:
         """
+        given_result = self.session.query(ProcessSource) \
+                                 .join(Process) \
+                                 .filter(Process.process_name == 'Testing Process Tracking Initialization') \
+                                 .count()
+
+        expected_result = 1
+
+        self.assertEqual(expected_result, given_result)
 
     def test_register_process_sources_two_sources(self):
         """
         Testing that when a new process is registered, multiple sources can be registered as well.
         :return:
         """
+        ProcessTracker(process_name='Multiple Source, Target Test'
+                       , process_type='Extract'
+                       , actor_name='UnitTesting'
+                       , tool_name='Spark'
+                       , sources=['Unittests', 'Unittests2']
+                       , targets=['Unittests', 'Unittests2'])
+
+        given_result = self.session.query(ProcessSource) \
+            .join(Process) \
+            .filter(Process.process_name == 'Multiple Source, Target Test') \
+            .count()
+
+        expected_result = 2
+
+        self.assertEqual(expected_result, given_result)
 
     def test_register_process_targets_one_target(self):
         """
         Testing that when a new process is registered, a target registered as well.
         :return:
         """
+        given_result = self.session.query(ProcessTarget) \
+                                 .join(Process) \
+                                 .filter(Process.process_name == 'Testing Process Tracking Initialization') \
+                                 .count()
+
+        expected_result = 1
+
+        self.assertEqual(expected_result, given_result)
 
     def test_register_process_targets_two_targets(self):
         """
         Testing that when a new process is registered, multiple targets can be registered as well.
         :return:
         """
+        ProcessTracker(process_name='Multiple Source, Target Test'
+                       , process_type='Extract'
+                       , actor_name='UnitTesting'
+                       , tool_name='Spark'
+                       , sources=['Unittests', 'Unittests2']
+                       , targets=['Unittests', 'Unittests2'])
+
+        given_result = self.session.query(ProcessTarget) \
+            .join(Process) \
+            .filter(Process.process_name == 'Multiple Source, Target Test') \
+            .count()
+
+        expected_result = 2
+
+        self.assertEqual(expected_result, given_result)
 
     def test_change_run_status_complete(self):
         """