Inspection improvements.

Author: Oren (electricessence)

.editorconfig

@@ -0,0 +1,19 @@
+[*.cs]
+
+# CA1707: Identifiers should not contain underscores
+dotnet_diagnostic.CA1707.severity = silent
+
+# CA1303: Do not pass literals as localized parameters
+dotnet_diagnostic.CA1303.severity = silent
+
+# CA1051: Do not declare visible instance fields
+dotnet_diagnostic.CA1051.severity = silent
+
+# CA1063: Implement IDisposable Correctly
+dotnet_diagnostic.CA1063.severity = silent
+
+# CA1816: Dispose methods should call SuppressFinalize
+dotnet_diagnostic.CA1816.severity = silent
+
+# CA2008: Do not create tasks without passing a TaskScheduler
+dotnet_diagnostic.CA2008.severity = silent

ActionRunner.cs

@@ -9,7 +9,7 @@ public class ActionRunner : ICancellable
 		public ActionRunner(Action action, TaskScheduler? scheduler = default)
 		{
 			_action = action;
-			_scheduler = scheduler; // No need to hold a refernce to the default, just keep it null.
+			Scheduler = scheduler; // No need to hold a refernce to the default, just keep it null.
 			LastStart = DateTime.MaxValue;
 			LastComplete = DateTime.MaxValue;
 		}
@@ -22,7 +22,7 @@ public static ActionRunner Create<T>(Func<T> action, TaskScheduler? scheduler =
 
 		Action? _action;
 		// ReSharper disable once NotAccessedField.Global
-		protected TaskScheduler? _scheduler;
+		protected TaskScheduler? Scheduler { get; private set; }
 
 		protected int _count;
 		public int Count => _count;
@@ -60,7 +60,7 @@ public void Dispose()
 		{
 			Cancel();
 			_action = null;
-			_scheduler = null;
+			Scheduler = null;
 		}
 
 		Action GetAction()
@@ -96,7 +96,9 @@ CancellableTask Prepare()
 					}
 					Interlocked.CompareExchange(ref _task, null, task);
 				},
-				TaskContinuationOptions.ExecuteSynchronously);
+				CancellationToken.None,
+				TaskContinuationOptions.ExecuteSynchronously,
+				Scheduler);
 			return task;
 		}
 

CancellableTask.cs

@@ -9,7 +9,9 @@ namespace Open.Threading.Tasks
 	/// </summary>
 	public class CancellableTask : Task, ICancellable
 	{
-		protected CancellationTokenSource? TokenSource;
+#pragma warning disable CA2213 // Is disposed in Cancel method.
+		CancellationTokenSource? TokenSource;
+#pragma warning restore CA2213
 
 		public bool Cancel(bool onlyIfNotRunning)
 		{

Open.Threading.Tasks.csproj

@@ -27,11 +27,19 @@ Part of the "Open" set of libraries.</Description>
 		<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0" PrivateAssets="All" />
 	</ItemGroup>
 
+	<ItemGroup>
+		<PackageReference Include="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="3.0.0">
+			<PrivateAssets>all</PrivateAssets>
+			<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+		</PackageReference>
+	</ItemGroup>
+
   <ItemGroup>
+    <None Remove=".editorconfig" />
     <None Remove=".git" />
     <None Remove=".gitignore" />
     <None Remove="LICENSE" />
-    <None Remove="README.md" />
+    <AdditionalFiles Include=".editorconfig" />
     <None Include="logo.png">
       <Pack>True</Pack>
       <PackagePath></PackagePath>

README.md

@@ -2,4 +2,4 @@
 
 A set of utilities and extensions for working with Tasks.
 
-[![NuGet](http://img.shields.io/nuget/v/Open.Threading.Tasks.svg)](https://www.nuget.org/packages/Open.Threading.Tasks/)
+[![NuGet](https://img.shields.io/nuget/v/Open.Threading.Tasks.svg)](https://www.nuget.org/packages/Open.Threading.Tasks/)

TaskExtensions.cs

@@ -10,8 +10,7 @@ public static class TaskExtensions
 		/// </summary>
 		public static bool IsActive(this Task target)
 		{
-			if (target is null)
-				throw new NullReferenceException();
+			if (target is null) throw new ArgumentNullException(nameof(target));
 
 			switch (target.Status)
 			{
@@ -38,8 +37,7 @@ public static bool IsActive(this Task target)
 		/// <returns>True if start attempt was successful.</returns>
 		public static bool EnsureStarted(this Task target, TaskScheduler? scheduler = default)
 		{
-			if (target is null) throw new NullReferenceException();
-
+			if (target is null) throw new ArgumentNullException(nameof(target));
 			if (target.Status != TaskStatus.Created) return false;
 			try
 			{
@@ -70,6 +68,7 @@ public static bool EnsureStarted(this Task target, TaskScheduler? scheduler = de
 		public static TTask OnFullfilled<TTask>(this TTask target, Action action)
 			where TTask : Task
 		{
+			if (target is null) throw new ArgumentNullException(nameof(target));
 			target.ContinueWith(task =>
 			{
 				if (task.Status == TaskStatus.RanToCompletion) action();
@@ -87,6 +86,7 @@ public static TTask OnFullfilled<TTask>(this TTask target, Action action)
 		/// <returns>The target object.  Allows for method chaining.</returns>
 		public static Task<T> OnFullfilled<T>(this Task<T> target, Action<T> action)
 		{
+			if (target is null) throw new ArgumentNullException(nameof(target));
 			target.ContinueWith(task =>
 			{
 				if (task.Status == TaskStatus.RanToCompletion) action(task.Result);
@@ -106,6 +106,7 @@ public static Task<T> OnFullfilled<T>(this Task<T> target, Action<T> action)
 		public static TTask OnFullfilled<TTask, T>(this TTask target, Func<T> action)
 			where TTask : Task
 		{
+			if (target is null) throw new ArgumentNullException(nameof(target));
 			target.ContinueWith(task =>
 			{
 				if (task.Status == TaskStatus.RanToCompletion) action();
@@ -124,6 +125,7 @@ public static TTask OnFullfilled<TTask, T>(this TTask target, Func<T> action)
 		public static TTask OnFaulted<TTask>(this TTask target, Action<Exception> action)
 			where TTask : Task
 		{
+			if (target is null) throw new ArgumentNullException(nameof(target));
 			target.ContinueWith(task =>
 			{
 				if (task.IsFaulted) action(task.Exception);
@@ -143,6 +145,7 @@ public static TTask OnFaulted<TTask>(this TTask target, Action<Exception> action
 		public static TTask OnCancelled<TTask>(this TTask target, Action action)
 			where TTask : Task
 		{
+			if (target is null) throw new ArgumentNullException(nameof(target));
 			target.ContinueWith(task =>
 			{
 				if (!task.IsCanceled) action();
@@ -162,6 +165,7 @@ public static TTask OnCancelled<TTask>(this TTask target, Action action)
 		public static TTask OnCancelled<TTask, T>(this TTask target, Func<T> action)
 			where TTask : Task
 		{
+			if (target is null) throw new ArgumentNullException(nameof(target));
 			target.ContinueWith(task =>
 			{
 				if (!task.IsCanceled) action();

TimeoutHandler.cs

@@ -4,9 +4,11 @@
 
 namespace Open.Threading.Tasks
 {
-	public class TimeoutHandler : IDisposable
+	public sealed class TimeoutHandler : IDisposable
 	{
+#pragma warning disable CA2213 // Is disposed properly.
 		CancellationTokenSource? TokenSource;
+#pragma warning restore CA2213
 		TimeoutHandler(TimeSpan delay, Action<TimeSpan> onTimeout)
 		{
 			TokenSource = new CancellationTokenSource();