Skip to content

Commit a4cfb5e

Browse files
committed
[#28] fixed getAllModels, added unit tests
1 parent a4e89e4 commit a4cfb5e

File tree

2 files changed

+11
-3
lines changed

2 files changed

+11
-3
lines changed

odm2api/ODM2/services/readService.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -908,7 +908,7 @@ def getDeploymentActionByCode(self, deploymentCode):
908908
def getAllModels(self):
909909

910910
try:
911-
return self._session.query(Model).all()
911+
return self._session.query(Models).all()
912912
except:
913913
return None
914914

@@ -927,7 +927,7 @@ def getAllSimulations(self):
927927

928928
def getSimulationByName(self, simulationName):
929929
try:
930-
return self._session.query(Simulation).filter(Simulation.SimulationName.ilike(simulationName)).first()
930+
return self._session.query(Simulations).filter(Simulations.SimulationName.ilike(simulationName)).first()
931931
except:
932932
return None
933933

tests/test_odm2/test_readservice.py

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,15 @@ def test_getModelByCode(self):
113113
"""
114114

115115
def test_getRelatedModelsByID(self):
116-
pass
116+
117+
# get one model from the database
118+
res = self.engine.execute('SELECT * FROM Models').fetchone()
119+
model_id = res[0]
120+
121+
# get related models by id using the api
122+
resapi = self.reader.getRelatedModelsByID(model_id)
123+
124+
assert False
117125

118126
def test_getRelatedModelsByCode(self):
119127
pass

0 commit comments

Comments
 (0)