Skip to content

Commit 0077a7b

Browse files
author
Miguel Leon
committed
Update for exceptions and print statements for python 3.x
1 parent 2e85eba commit 0077a7b

File tree

6 files changed

+23
-23
lines changed

6 files changed

+23
-23
lines changed

odm2api/ODM1_1_1/services/edit_service.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -457,7 +457,7 @@ def updateSeries(self, var=None, method=None, qcl=None, is_new_series=False):
457457
print("Save existing series ID: %s" % str(series.id))
458458
series = tseries
459459
else:
460-
print "Series doesn't exist (if you are not, you should be running SaveAs)"
460+
print("Series doesn't exist (if you are not, you should be running SaveAs)")
461461

462462
if is_new_series:
463463

odm2api/ODM1_1_1/services/export_service.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ def export_series_data(self, series_id, filename, utc=False, site=False, var=Fal
1919
return False
2020

2121
writer = csv.writer(open(filename, 'wb'))
22-
print "filename: ", filename
22+
print("filename: ", filename)
2323
self.write_data_header(writer, utc, site, var, offset, qual, src, qcl)
2424
for dv in series.data_values:
2525
self.write_data_row(writer, series, dv, utc, site, var, offset, qual, src, qcl)

odm2api/ODM1_1_1/services/series_service.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -286,7 +286,7 @@ def get_series_by_id(self, series_id):
286286
try:
287287
return self._session.query(ODM.Series).filter_by(id=series_id).first()
288288
except Exception as e:
289-
print e
289+
print(e)
290290
return None
291291

292292
def get_series_by_id_quint(self, site_id, var_id, method_id, source_id, qcl_id):

odm2api/ODM2/services/createService.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -262,7 +262,7 @@ def createAffiliation(self, personid, organizationid, email, phone=None, address
262262
#self._session.flush()
263263
# self._session.refresh(a)
264264

265-
print a.OrganizationID
265+
print(a.OrganizationID)
266266

267267
return a
268268

@@ -523,8 +523,8 @@ def createTimeSeriesResultValues(self, datavalues):
523523

524524

525525
return datavalues
526-
except Exception, e:
527-
print e
526+
except(Exception, e):
527+
print(e)
528528
return None
529529

530530

odm2api/ODM2/services/readService.py

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -331,8 +331,8 @@ def getProcessingLevelByCode(self, processingCode):
331331
"""
332332
try:
333333
return self._session.query(ProcessingLevels).filter_by(ProcessingLevelCode=str(processingCode)).first()
334-
except Exception, e:
335-
print e
334+
except Exception as e:
335+
print(e)
336336
return None
337337

338338
"""
@@ -387,7 +387,7 @@ def getSamplingFeaturesByType(self, samplingFeatureTypeCV):
387387
try:
388388
return self._session.query(SamplingFeatures).filter_by(SamplingFeatureTypeCV=samplingFeatureTypeCV).all()
389389
except Exception as e:
390-
print e
390+
print(e)
391391
return None
392392

393393
def getSamplingFeatureByGeometry(self, wkt_geometry):
@@ -396,17 +396,17 @@ def getSamplingFeatureByGeometry(self, wkt_geometry):
396396
# ST_Equals(geometry, geometry)
397397
return self._session.query(SamplingFeatures).filter(
398398
func.ST_AsText(SamplingFeatures.FeatureGeometry) == func.ST_AsText(wkt_geometry)).first()
399-
except Exception, e:
400-
print e
399+
except Exception as e:
400+
print(e)
401401
return None
402402

403403
def getGeometryTest(self, TestGeom):
404404
Geom = self._session.query(SamplingFeatures).first()
405-
print "Queried Geometry: ", self._session.query(Geom.FeatureGeometry.ST_AsText()).first()
405+
print("Queried Geometry: ", self._session.query(Geom.FeatureGeometry.ST_AsText()).first())
406406
GeomText = self._session.query(
407407
func.ST_Union(Geom.FeatureGeometry, func.ST_GeomFromText(TestGeom)).ST_AsText()).first()
408408

409-
print GeomText
409+
print(GeomText)
410410

411411
"""
412412
Action
@@ -773,13 +773,13 @@ def getTimeSeriesResultValuesByResultId(self, resultId):
773773
"""
774774
try:
775775
q = self._session.query(TimeSeriesResultValues).filter_by(ResultID=resultId).all()
776-
print type(q[0]), q[0]
776+
print(type(q[0]), q[0])
777777
df = pd.DataFrame([dv.list_repr() for dv in q])
778778
df.columns = q[0].get_columns()
779779
return df
780780
# return self._session.query(Timeseriesresultvalue).filter_by(ResultID=resultId).all()
781781
except Exception as e:
782-
print e
782+
print(e)
783783
return None
784784

785785
def getTimeSeriesResultValuesByCode(self, timeSeriesCode):
@@ -945,8 +945,8 @@ def getRelatedModelsByID(self, modelid):
945945
"""
946946
try:
947947
return self._session.query(RelatedModels).filter_by(RelatedModelID=modelid).all()
948-
except Exception, e:
949-
print e
948+
except Exception as e:
949+
print(e)
950950
return None
951951

952952
def getRelatedModelsByCode(self, modelcode):
@@ -958,8 +958,8 @@ def getRelatedModelsByCode(self, modelcode):
958958
try:
959959
return self._session.query(RelatedModels).join(Models, RelatedModels.RelatedModelID == Models.ModelID) \
960960
.filter(Models.ModelCode == modelcode).all()
961-
except Exception, e:
962-
print e
961+
except Exception as e:
962+
print(e)
963963
return None
964964

965965
def getResultsBySimulationID(self, simulationID):
@@ -969,8 +969,8 @@ def getResultsBySimulationID(self, simulationID):
969969
.join(Actions) \
970970
.join(Simulations) \
971971
.filter(Simulations.SimulationID == simulationID).all()
972-
except Exception, e:
973-
print e
972+
except Exception as e:
973+
print(e)
974974
return None
975975

976976
# ################################################################################

odm2api/ODMconnection.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ def testEngine(self, connection_string):
117117
s.test_Session().query(Variable2.VariableCode).limit(1).first()
118118

119119
except Exception as e:
120-
print "Connection was unsuccessful ", e.message
120+
print("Connection was unsuccessful ", e.message)
121121
return False
122122
return True
123123

@@ -129,7 +129,7 @@ def testEngine1_1(self, connection_string):
129129
s.test_Session().query(ODM.Variable.code).limit(1).first()
130130

131131
except Exception as e:
132-
print "Connection was unsuccessful ", e.message
132+
print("Connection was unsuccessful ", e.message)
133133
return False
134134
return True
135135

0 commit comments

Comments
 (0)