Small Lightning Driver Fixes (#358)

dnakhooda · web-flow · commit 95bd265aeffa · 2026-01-13T10:31:43.000-05:00
diff --git a/general/src/as3935.c b/general/src/as3935.c
@@ -29,7 +29,7 @@ uint8_t as3935_read(as3935_t *as3935, uint8_t reg)
 
 	// HAL SPI wants an 8 bit array of length 2 for tx_data
 	HAL_StatusTypeDef status = HAL_SPI_TransmitReceive(
-		as3935->hspi, (uint8_t *)&tx_data, &rx_buf, 2, HAL_MAX_DELAY);
+		as3935->hspi, (uint8_t *)&tx_data, rx_buf, 2, HAL_MAX_DELAY);
 
 	if (status != HAL_OK) {
 		return 0xFF;
@@ -164,7 +164,7 @@ uint32_t as3935_get_energy(as3935_t *as3935)
 	}
 
 	// combine the three values. Only read the first 5 bits for energy_mm
-	energy = ((energy_mm & 0b11111) << 16) | (energy_m << 8) | energy_l;
+	energy = ((energy_mm & 0x1F) << 16) | (energy_m << 8) | energy_l;
 
 	return energy;
 }

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ uint8_t as3935_read(as3935_t *as3935, uint8_t reg)`
`29`	`29`
`30`	`30`	`// HAL SPI wants an 8 bit array of length 2 for tx_data`
`31`	`31`	`HAL_StatusTypeDef status = HAL_SPI_TransmitReceive(`
`32`		`- as3935->hspi, (uint8_t *)&tx_data, &rx_buf, 2, HAL_MAX_DELAY);`
	`32`	`+ as3935->hspi, (uint8_t *)&tx_data, rx_buf, 2, HAL_MAX_DELAY);`
`33`	`33`
`34`	`34`	`if (status != HAL_OK) {`
`35`	`35`	`return 0xFF;`
`@@ -164,7 +164,7 @@ uint32_t as3935_get_energy(as3935_t *as3935)`
`164`	`164`	`}`
`165`	`165`
`166`	`166`	`// combine the three values. Only read the first 5 bits for energy_mm`
`167`		`- energy = ((energy_mm & 0b11111) << 16) \| (energy_m << 8) \| energy_l;`
	`167`	`+ energy = ((energy_mm & 0x1F) << 16) \| (energy_m << 8) \| energy_l;`
`168`	`168`
`169`	`169`	`return energy;`
`170`	`170`	`}`