From 2a57b531ebda3a21e3fd0def8cf9741bbef450c8 Mon Sep 17 00:00:00 2001 From: cgombauld Date: Sat, 31 May 2025 17:17:33 +0200 Subject: [PATCH 1/3] feat(Settings): disable experimental warnings by default --- package.json | 1 + src/http-server/config.js | 9 ++++++++- test/config.test.js | 5 ++++- 3 files changed, 13 insertions(+), 2 deletions(-) diff --git a/package.json b/package.json index 84605563..e20593bb 100644 --- a/package.json +++ b/package.json @@ -82,6 +82,7 @@ "@nodesecure/documentation-ui": "^1.3.0", "@nodesecure/flags": "^3.0.3", "@nodesecure/i18n": "^4.0.1", + "@nodesecure/js-x-ray": "^8.2.0", "@nodesecure/licenses-conformance": "^2.1.0", "@nodesecure/npm-registry-sdk": "^3.0.0", "@nodesecure/ossf-scorecard-sdk": "^3.2.1", diff --git a/src/http-server/config.js b/src/http-server/config.js index 974dd726..c4bf1215 100644 --- a/src/http-server/config.js +++ b/src/http-server/config.js @@ -1,11 +1,18 @@ +// Import Third-party Dependencies +import { warnings } from "@nodesecure/js-x-ray"; + // Import Internal Dependencies import { appCache } from "../cache.js"; import { logger } from "../logger.js"; +const experimentalWarnings = Object.entries(warnings) + .filter(([_, { experimental }]) => experimental) + .map(([warning]) => warning); + // CONSTANTS const kDefaultConfig = { defaultPackageMenu: "info", - ignore: { flags: [], warnings: [] } + ignore: { flags: [], warnings: experimentalWarnings } }; export async function get() { diff --git a/test/config.test.js b/test/config.test.js index 795d243d..aed1b3b3 100644 --- a/test/config.test.js +++ b/test/config.test.js @@ -4,6 +4,7 @@ import assert from "node:assert"; // Import Third-party Dependencies import cacache from "cacache"; +import { warnings } from "@nodesecure/js-x-ray"; // Import Internal Dependencies import { get, set } from "../src/http-server/config.js"; @@ -29,7 +30,9 @@ describe("config", { concurrency: 1 }, () => { assert.deepStrictEqual(value, { defaultPackageMenu: "info", - ignore: { flags: [], warnings: [] } + ignore: { flags: [], warnings: Object.entries(warnings) + .filter(([_, { experimental }]) => experimental) + .map(([warning]) => warning) } }); }); From 999a48a5ee230582b475c3803b5e7bdf8e171e00 Mon Sep 17 00:00:00 2001 From: Clement Gombauld Date: Sat, 31 May 2025 20:15:58 +0200 Subject: [PATCH 2/3] refacto(cache): imporve experimental warning filtering Co-authored-by: Thomas.G --- src/http-server/config.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/http-server/config.js b/src/http-server/config.js index c4bf1215..a71d2ead 100644 --- a/src/http-server/config.js +++ b/src/http-server/config.js @@ -6,8 +6,7 @@ import { appCache } from "../cache.js"; import { logger } from "../logger.js"; const experimentalWarnings = Object.entries(warnings) - .filter(([_, { experimental }]) => experimental) - .map(([warning]) => warning); + .flatMap(([warning, { experimental }]) => experimental ? [warning] : []) // CONSTANTS const kDefaultConfig = { From 30b32e63b174770fecfff888ecfd89d0c6b7945a Mon Sep 17 00:00:00 2001 From: cgombauld Date: Sat, 31 May 2025 22:10:57 +0200 Subject: [PATCH 3/3] fix(config): fix style --- src/http-server/config.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/http-server/config.js b/src/http-server/config.js index a71d2ead..ae234284 100644 --- a/src/http-server/config.js +++ b/src/http-server/config.js @@ -6,7 +6,7 @@ import { appCache } from "../cache.js"; import { logger } from "../logger.js"; const experimentalWarnings = Object.entries(warnings) - .flatMap(([warning, { experimental }]) => experimental ? [warning] : []) + .flatMap(([warning, { experimental }]) => (experimental ? [warning] : [])); // CONSTANTS const kDefaultConfig = {