Skip to content

Commit 4f7fe43

Browse files
nadimkobeissinadimkobeissi
committed
Avoid polluting top-level repo directory
This might break things, will test first.
1 parent a0de7ec commit 4f7fe43

File tree

8 files changed

+7
-7
lines changed

8 files changed

+7
-7
lines changed

Dockerfile.nginx renamed to .github/assets/Dockerfile.nginx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ FROM nginx:alpine
55
COPY site /usr/share/nginx/html
66

77
#Replace default nginx.conf with custom configuration
8-
COPY nginx.conf /etc/nginx/conf.d/default.conf
8+
COPY .github/assets/nginx.conf /etc/nginx/conf.d/default.conf
99

1010
# Expose the desired port (default is 80 for NGINX)
1111
EXPOSE 80

dev-taskdef.json renamed to .github/assets/dev-taskdef.json

File renamed without changes.

nginx.conf renamed to .github/assets/nginx.conf

File renamed without changes.

prod-taskdef.json renamed to .github/assets/prod-taskdef.json

File renamed without changes.

staging-taskdef.json renamed to .github/assets/staging-taskdef.json

File renamed without changes.

‎.github/workflows/dev_deployment.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
ECR_REPOSITORY: docs-dev-ecr
1818
ECS_SERVICE: docs-dev-ecs-service
1919
ECS_CLUSTER: frontend-dev-ecs-cluster
20-
ECS_TASK_DEFINITION: dev-taskdef.json
20+
ECS_TASK_DEFINITION: .github/assets/dev-taskdef.json
2121
CONTAINER_NAME: docs-dev
2222
steps:
2323
- name: Checkout
@@ -53,7 +53,7 @@ jobs:
5353
ECR_REGISTRY: ${{ steps.login-ecr.outputs.registry }}
5454
IMAGE_TAG: ${{ github.sha }}
5555
run: |
56-
docker build -t $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG -f Dockerfile.nginx .
56+
docker build -t $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG -f .github/assets/Dockerfile.nginx .
5757
docker push $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG
5858
echo "image=$ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG" >> $GITHUB_OUTPUT
5959

‎.github/workflows/prod_deployment.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ jobs:
2424
ECR_REPOSITORY: docs-ecr
2525
ECS_SERVICE: docs-ecs-service
2626
ECS_CLUSTER: frontend-prod-ecs-cluster
27-
ECS_TASK_DEFINITION: prod-taskdef.json
27+
ECS_TASK_DEFINITION: .github/assets/prod-taskdef.json
2828
CONTAINER_NAME: docs
2929
steps:
3030
- name: Checkout
@@ -60,7 +60,7 @@ jobs:
6060
ECR_REGISTRY: ${{ steps.login-ecr.outputs.registry }}
6161
IMAGE_TAG: ${{ github.sha }}
6262
run: |
63-
docker build -t $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG -f Dockerfile.nginx .
63+
docker build -t $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG -f .github/assets/Dockerfile.nginx .
6464
docker push $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG
6565
echo "image=$ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG" >> $GITHUB_OUTPUT
6666

‎.github/workflows/staging_deployment.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
ECR_REPOSITORY: docs-staging-ecr
1818
ECS_SERVICE: docs-staging-ecs-service
1919
ECS_CLUSTER: frontend-staging-ecs-cluster
20-
ECS_TASK_DEFINITION: staging-taskdef.json
20+
ECS_TASK_DEFINITION: .github/assets/staging-taskdef.json
2121
CONTAINER_NAME: docs-staging
2222
steps:
2323
- name: Checkout
@@ -53,7 +53,7 @@ jobs:
5353
ECR_REGISTRY: ${{ steps.login-ecr.outputs.registry }}
5454
IMAGE_TAG: ${{ github.sha }}
5555
run: |
56-
docker build -t $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG -f Dockerfile.nginx .
56+
docker build -t $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG -f .github/assets/Dockerfile.nginx .
5757
docker push $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG
5858
echo "image=$ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG" >> $GITHUB_OUTPUT
5959

0 commit comments

Comments
 (0)