Phase 112 Part 2: Encapsulate opcode properties in InstructionView

Moved luaP_opmodes array access into InstructionView methods:
- Added getOpMode() method - returns OpMode enum
- Added testAMode() method - tests if instruction sets register A
- Added testTMode() method - tests if instruction is a test/jump
- Added testITMode() method - tests if instruction uses top from previous
- Added testOTMode() method - tests if instruction sets top for next
- Added testMMMode() method - tests if instruction is metamethod call

Impact:
- Better encapsulation - opcode properties accessed through InstructionView
- Cleaner code - view.testTMode() instead of testTMode(view.opcode())
- Eliminated redundant InstructionView creations at call sites
- Zero-cost abstraction - all methods are inline

Files changed:
- src/compiler/lopcodes.h (method declarations and implementations)
- src/compiler/lopcodes.cpp (luaP_isIT, luaP_isOT - use view methods)
- src/compiler/lcode.cpp (getjumpcontrol, negatecondition - use view methods)
- src/core/ldebug.cpp (findsetreg - use view methods, eliminated duplicate views)

Performance: 4.33s avg (baseline 4.20s, exactly at target!)
All tests passing: "final OK !!!"

Author: claude

src/compiler/lcode.cpp

@@ -126,7 +126,7 @@ int FuncState::condjump(OpCode o, int A, int B, int C, int k) {
 */
 Instruction *FuncState::getjumpcontrol(int position) {
   Instruction *pi = &getProto()->getCode()[position];
-  if (position >= 1 && testTMode(InstructionView(*(pi-1)).opcode()))
+  if (position >= 1 && InstructionView(*(pi-1)).testTMode())
     return pi-1;
   else
     return pi;
@@ -663,9 +663,10 @@ void FuncState::codeABRK(OpCode o, int A, int B, expdesc *ec) {
 */
 void FuncState::negatecondition(expdesc *e) {
   Instruction *instr = getjumpcontrol(e->getInfo());
-  lua_assert(testTMode(InstructionView(*instr).opcode()) && InstructionView(*instr).opcode() != OP_TESTSET &&
-                                           InstructionView(*instr).opcode() != OP_TEST);
-  SETARG_k(*instr, static_cast<unsigned int>(InstructionView(*instr).k() ^ 1));
+  InstructionView view(*instr);
+  lua_assert(view.testTMode() && view.opcode() != OP_TESTSET &&
+                                  view.opcode() != OP_TEST);
+  SETARG_k(*instr, static_cast<unsigned int>(view.k() ^ 1));
 }
 
 /*

src/compiler/lopcodes.cpp

@@ -113,11 +113,12 @@ LUAI_DDEF const lu_byte luaP_opmodes[NUM_OPCODES] = {
 ** it results in multiple values.
 */
 int luaP_isOT (Instruction i) {
-  OpCode op = static_cast<OpCode>(InstructionView(i).opcode());
+  InstructionView view(i);
+  OpCode op = static_cast<OpCode>(view.opcode());
   switch (op) {
     case OP_TAILCALL: return 1;
     default:
-      return testOTMode(op) && InstructionView(i).c() == 0;
+      return view.testOTMode() && view.c() == 0;
   }
 }
 
@@ -127,12 +128,13 @@ int luaP_isOT (Instruction i) {
 ** it accepts multiple results.
 */
 int luaP_isIT (Instruction i) {
-  OpCode op = static_cast<OpCode>(InstructionView(i).opcode());
+  InstructionView view(i);
+  OpCode op = static_cast<OpCode>(view.opcode());
   switch (op) {
     case OP_SETLIST:
-      return testITMode(InstructionView(i).opcode()) && InstructionView(i).vb() == 0;
+      return view.testITMode() && view.vb() == 0;
     default:
-      return testITMode(InstructionView(i).opcode()) && InstructionView(i).b() == 0;
+      return view.testITMode() && view.b() == 0;
   }
 }
 

src/compiler/lopcodes.h

@@ -288,6 +288,15 @@ class InstructionView {
 	constexpr int sj() const noexcept {
 		return getarg(inst_, POS_sJ, SIZE_sJ) - OFFSET_sJ;
 	}
+
+	/* Instruction property accessors - encapsulate luaP_opmodes array access */
+	/* Defined below after luaP_opmodes declaration */
+	inline OpMode getOpMode() const noexcept;
+	inline bool testAMode() const noexcept;
+	inline bool testTMode() const noexcept;
+	inline bool testITMode() const noexcept;
+	inline bool testOTMode() const noexcept;
+	inline bool testMMMode() const noexcept;
 };
 
 
@@ -565,6 +574,31 @@ inline bool testMMMode(int m) noexcept {
 	return (luaP_opmodes[m] & (1 << 7)) != 0;
 }
 
+/* InstructionView property method implementations (defined after luaP_opmodes) */
+inline OpMode InstructionView::getOpMode() const noexcept {
+	return static_cast<OpMode>(luaP_opmodes[opcode()] & 7);
+}
+
+inline bool InstructionView::testAMode() const noexcept {
+	return (luaP_opmodes[opcode()] & (1 << 3)) != 0;
+}
+
+inline bool InstructionView::testTMode() const noexcept {
+	return (luaP_opmodes[opcode()] & (1 << 4)) != 0;
+}
+
+inline bool InstructionView::testITMode() const noexcept {
+	return (luaP_opmodes[opcode()] & (1 << 5)) != 0;
+}
+
+inline bool InstructionView::testOTMode() const noexcept {
+	return (luaP_opmodes[opcode()] & (1 << 6)) != 0;
+}
+
+inline bool InstructionView::testMMMode() const noexcept {
+	return (luaP_opmodes[opcode()] & (1 << 7)) != 0;
+}
+
 
 LUAI_FUNC int luaP_isOT (Instruction i);
 LUAI_FUNC int luaP_isIT (Instruction i);

src/core/ldebug.cpp

@@ -456,16 +456,17 @@ static int findsetreg (const Proto *p, int lastpc, int reg) {
   int pc;
   int setreg = -1;  /* keep last instruction that changed 'reg' */
   int jmptarget = 0;  /* any code before this address is conditional */
-  if (testMMMode(InstructionView(p->getCode()[lastpc]).opcode()))
+  if (InstructionView(p->getCode()[lastpc]).testMMMode())
     lastpc--;  /* previous instruction was not actually executed */
   for (pc = 0; pc < lastpc; pc++) {
     Instruction i = p->getCode()[pc];
-    OpCode op = static_cast<OpCode>(InstructionView(i).opcode());
-    int a = InstructionView(i).a();
+    InstructionView view(i);
+    OpCode op = static_cast<OpCode>(view.opcode());
+    int a = view.a();
     int change;  /* true if current instruction changed 'reg' */
     switch (op) {
       case OP_LOADNIL: {  /* set registers from 'a' to 'a+b' */
-        int b = InstructionView(i).b();
+        int b = view.b();
         change = (a <= reg && reg <= a + b);
         break;
       }
@@ -479,7 +480,7 @@ static int findsetreg (const Proto *p, int lastpc, int reg) {
         break;
       }
       case OP_JMP: {  /* doesn't change registers, but changes 'jmptarget' */
-        int b = InstructionView(i).sj();
+        int b = view.sj();
         int dest = pc + 1 + b;
         /* jump does not skip 'lastpc' and is larger than current one? */
         if (dest <= lastpc && dest > jmptarget)
@@ -488,7 +489,7 @@ static int findsetreg (const Proto *p, int lastpc, int reg) {
         break;
       }
       default:  /* any instruction that sets A */
-        change = (testAMode(op) && reg == a);
+        change = (view.testAMode() && reg == a);
         break;
     }
     if (change)