From 544edbde67cc9b90a739e7621ba44172bffba6df Mon Sep 17 00:00:00 2001 From: David Whittaker Date: Tue, 14 Jan 2025 14:35:45 -0800 Subject: [PATCH] fix(signal): log exception instead of warning for bad signal id --- src/dispatch/signal/service.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/dispatch/signal/service.py b/src/dispatch/signal/service.py index f60e9bd0ebaa..670690093abb 100644 --- a/src/dispatch/signal/service.py +++ b/src/dispatch/signal/service.py @@ -574,7 +574,7 @@ def create_instance( # remove non-serializable entities from the raw JSON: signal_instance_in_raw = signal_instance_in.raw.copy() if signal_instance_in.oncall_service: - signal_instance_in_raw.pop('oncall_service') + signal_instance_in_raw.pop("oncall_service") # we round trip the raw data to json-ify date strings signal_instance = SignalInstance( @@ -603,7 +603,7 @@ def create_instance( if signal_instance.id and not is_valid_uuid(signal_instance.id): msg = f"Invalid signal id format. Expecting UUIDv4 format. Signal id: {signal_instance.id}. Signal name/variant: {signal_instance.raw['name'] if signal_instance and signal_instance.raw and signal_instance.raw.get('name') else signal_instance.raw['variant']}" - log.warn(msg) + log.exception(msg) raise HTTPException( status_code=status.HTTP_400_BAD_REQUEST, detail=[{"msg": msg}],